Merge pull request resilient-tech#3770 from resilient-tech/better-gstin-error-msg

refactor: enhance GSTIN validation error messages

Author: karm1000

india_compliance/public/js/utils.js

@@ -307,20 +307,30 @@ Object.assign(india_compliance, {
     },
 
     validate_gstin(gstin, show_msg = true) {
+        const opts = { title: __("Error"), indicator: "red" };
+
         if (!gstin || gstin.length !== 15) {
-            if (show_msg) frappe.msgprint(__("GSTIN must be 15 characters long"));
+            if (show_msg) {
+                frappe.msgprint({
+                    message: __("GSTIN must be 15 characters long"),
+                    ...opts,
+                });
+            }
+
             return;
         }
 
         gstin = gstin.trim().toUpperCase();
 
         if (GSTIN_REGEX.test(gstin) && is_gstin_check_digit_valid(gstin)) {
             return gstin;
-        } else {
-            if (show_msg) frappe.msgprint(__("Invalid GSTIN"));
+        } else if (show_msg) {
+            frappe.msgprint({
+                message: __("Invalid GSTIN"),
+                ...opts,
+            });
         }
     },
-
     guess_gst_category(gstin, country) {
         if (!gstin) {
             if (country && country !== "India") return "Overseas";