Skip to content

Commit 7e32158

Browse files
manodeepccarouge
andauthored
Add performance check section to PR template and re-numbered later sections (#293)
* Add performance check section to PR template * Update section numbers in pull request template * Update .github/pull_request_template.md Co-authored-by: Claire Carouge <ccarouge@users.noreply.github.com> * Added a note about requiring a note when performance testing is marked not applicable - Added clarification for performance testing necessity - Added a newline after the performance testing section. --------- Co-authored-by: Claire Carouge <ccarouge@users.noreply.github.com>
1 parent a4935d6 commit 7e32158

1 file changed

Lines changed: 12 additions & 2 deletions

File tree

.github/pull_request_template.md

Lines changed: 12 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -34,6 +34,16 @@ Is this reproducible with the previous commit? (If not, why not?)
3434
- [ ] Yes
3535
- [ ] No - `!test repro commit` has been run. <!-- add detail below for why it's answer changing -->
3636

37+
**7. Performance**
38+
<!-- check the throughput of the model by running 6 months with and without your changes and recording the walltime-->
39+
40+
Has the model performance (say, throughput of model-years/wall-day) changed?
41+
- [ ] Yes
42+
- [ ] No
43+
- [ ] N/A (if selected, please add a brief explanation why performance testing is not necessary for this PR)
44+
45+
If yes, provide the numbers from your testing. Is the performance better or worse?
46+
3747
**8. Manifests**
3848

3949
Have you changed the executable, the input files and/or the restart files?
@@ -58,14 +68,14 @@ runlog:
5868
Then commit the newly created manifest files (under manifests/) only to the branch for this PR.
5969
6070
61-
**7. Documentation**
71+
**9. Documentation**
6272
<!--Does this impact documentation? -->
6373
6474
Is the documentation updated?
6575
- [ ] Yes
6676
- [ ] N/A
6777
68-
**9. Merge Strategy**
78+
**10. Merge Strategy**
6979
<!-- What is the planned merge strategy (Merge commit, Rebase and merge, or squash) ?
7080
If not squash, link to the related issue in the commit descriptions -->
7181

0 commit comments

Comments
 (0)