Conversation
There was a problem hiding this comment.
Thankyou for starting this.
The normal procedure is to make an issue, agree/document an approach and use the issue number in the branch name. Along those lines .. there's no information on what the scope of this change is or should be, so it's hard to confirm its been completed.
Could all the files with .un~ be removed please? I can't see what they are for. There are numerous other copy/paste errors /unused files - e.g. in assets, references.bib, the docs/index.md (as opposed to the docs/pages/index.md file)
All the ACCESS-NRI authored files should have a copyright / license statement at the top, e.g:
# Copyright 2025 ACCESS-NRI and contributors. See the top-level COPYRIGHT file for details.
# SPDX-License-Identifier: Apache-2.0
Should CSIRO be listed in the copyright statement too ?
Co-authored-by: Anton Steketee <79179784+anton-seaice@users.noreply.github.com>
234fe34 to
2d04ea2
Compare
|
Thanks for the feedback @anton-seaice
Okay, in this instance, the need for an esm1.6 config' doc has been discussed a few times and I thought was uncontentious? The point of this PR then is just to start an empty document.
They have been removed.
This was based on om3 config doc that I gather didn't have those files? Feel free to add where you think it's appropriate.
I guess they are covered under the |
|
@aidanheerdegen / @micaeljtoliveira - I am confused about how to license this. This change adds documentation for the access-esm1.6-configs, which exists in the main branch of the repo. The repo is licensed with Apache-2.0 but it says in dev-docs to use cc-by-4.0 for documentation. I suspect Apache-2.0 is fine? I am also confused about the need for a header statement. In python files we tend/sometimes have : but we don't seem to have this header in documentation or config files etc ? |
|
@chrisb13 - youll need to sign your commits. Will you raise an issue to encourage people to add content ? |
I'm happy to, but I think it's best if we decide on the (at least temporary) hosting choice. As in, are we going to not merge this PR and then people can just commit to it? This gives PR previews at least for the interim. Or is the preference to have it hosted somewhere first and then ask for contributions? (@atteggiani has said it's impractical to organise a subdomain before the workshop.) |
I think its fine to merge and use https://access-nri.github.io/access-esm1.6-configs/ temporarily until there is a subdomain ? |
Yeah I think that's a tidy solution for the time being. If there's no objections @ACCESS-NRI/hivedocsteam ? |
clean up of files further clean up of files
2d04ea2 to
e978272
Compare
|
@anton-seaice looks like we can merge now, pending resolving your licence query / everyone ok with https://access-nri.github.io/access-esm1.6-configs/. |
I would suggest not to advertise urls that will then be changed. |
I think Anton and I could have been clearer. We're looking for a temporary home for dev work, so it wouldn't be "advertised" beyond the development team. |
Co-authored-by: Anton Steketee <79179784+anton-seaice@users.noreply.github.com>
anton-seaice
left a comment
There was a problem hiding this comment.
This is a useful starting point, thanks @chrisb13
I think the license thing could be clearer, we seem a bit inconsistent in our approach, but there is a license file in the top level in the repo, so it is communicated to some extent that the docs are under an open source license
|
@anton-seaice @chrisb13 Can you access the preview? I can only see the landing page. "Home" takes me to "404" and "Configuration" keeps me on the landing page. Makes it hard to review the text. |
|
Yeah, it's just a container for the moment, I think when I merge this, it'll break a few more links that I'll need to fix... Update: actually seems to have worked! |
|
Important, a copyright can only be held by one legal entity, so the copyright line can not read: "ACCESS-NRI, CSIRO and contributors". The acknowledgement of CSIRO and other contributors need to come differently. Can add the logos and some text on the home page. @chrisb13 |
Thanks @ccarouge, can you please make the changes you suggest. |
|
It is fairly common to see it in software, e.g. although that doesn't mean its correct of course |
Copyright laws are different from country to country, so what is valid in the US might not be in Australia.
@ccarouge Is this a special feature of Australian copyright laws? Because most other countries do allow multiple copyright holders, provided they are legal entities (which also includes individuals). |
Just to follow up, I think we should check in with the relevant person at CSIRO before adding logos and explicit text. @ccarouge perhaps you have a contact for that? It sounds like you've been down this road before. |
|
Or I'm misremembering what I learnt before because I don't use it much. :D |
Note that if the concept is to have a subdomain config, e.g. https://access-esm1.6-configs.access-hive.org.au/, then that takes some times to organise.
(fyi @AndyHoggANU, finally!)