Conversation
|
!test repro commit |
|
❌ The Bitwise Reproducibility Check Failed ❌ When comparing:
🔧 The new checksums will be committed to this PR, if they differ from what is on this branch. Further informationThe experiment can be found on Gadi at The checksums generated by this The checksums compared against are found here https://github.com/ACCESS-NRI/access-esm1.6-configs/tree/b4a7e1148dd7618d0491017ae62a2a3758cfc09b/testing/checksum Test summary: |
JhanSrbinovsky
left a comment
There was a problem hiding this comment.
The executable was updated in the prev I guess - otherwise LGTM
|
Automatic Git cherry-picking of commit(s) 45c0871 dc19da2 6ef9d9d into dev-1pctCO2-rad was successful. The new pull request can be reviewed and approved here. |
|
Automatic Git cherry-picking of commit(s) 45c0871 dc19da2 6ef9d9d into dev-1pctCO2-bgc was successful. The new pull request can be reviewed and approved here. |
|
Automatic Git cherry-picking of commit(s) 45c0871 dc19da2 into dev-4xCO2+concentrations was successful. The new pull request can be reviewed and approved here. |
1. Summary:
This PR swaps to the Ndep v2 nitrogen forcing dataset for the 1pctCO2 configuration. It also updates the restart to use a copy of
/g/data/p66/jxs599/ESM16/PAYU/Dev/Ndep2-PI-CNP-concentrations/archive/restart099, from the end of the 100th year of the concentration driven PI control run.No dates have been changed, and so the initial year will be year 201.
Once merged, the Ndep and restart changes will be copied over to the 1pctCO2-rad, 1pctCO2-bgc, and 4xCO2+concentrations configurations.
2. Issues Addressed:
3. Dependencies (e.g. on payu, or model)
This change requires changes to (note pull request(s) where relevant):
4. Ad-hoc Testing
What ad-hoc testing was done? How are you convinced this change is correct (plots are good)?
5. CI Testing
!test reprohas been run6. Reproducibility
Is this reproducible with the previous commit? (If not, why not?)
!test repro commithas been run.Change in restart and nitrogen forcing change answers.
7. Performance
Has the model performance (say, throughput of model-years/wall-day) changed?
Change in restart and input file not expected to affect performance.
If yes, provide the numbers from your testing. Is the performance better or worse?
8. Manifests
Have you changed the executable, the input files and/or the restart files?
If yes, have you updated the manifests?
To update the manifests, run payu setup (in a cloned copy of your feature branch) with reproducibility tests turned off:
Then commit the newly created manifest files (under manifests/) only to the branch for this PR.
9. Documentation
Is the documentation updated?
10. Merge Strategy