deploy-1-setup: Validate all repos using get-git-ref-info action

check-config: Validate all repositories referenced in build-cd and the caller, including new access-spack-package and builtin spack-packages

Author: CodeGat

.github/workflows/deploy-1-setup.yml

@@ -106,14 +106,22 @@ on:
     #     value: ${{ jobs.check-config.outputs.spack-config-git-hash }}
     #     description: |
     #       Git hash of the 'access-nri/spack-config' repository at the specified version.
-    #   spack-packages-version:
-    #     value: ${{ jobs.check-config.outputs.spack-packages-version }}
+    #   builtin-spack-packages-version:
+    #     value: ${{ jobs.check-config.outputs.builtin-spack-packages-version }}
     #     description: |
-    #       Git ref of 'access-nri/spack-packages' that is used to reference custom packages in spack.
-    #   spack-packages-git-hash:
-    #     value: ${{ jobs.check-config.outputs.spack-packages-git-hash }}
+    #       Git ref of 'spack/spack-packages' that is used to reference builtin packages in spack.
+    #   builtin-spack-packages-git-hash:
+    #     value: ${{ jobs.check-config.outputs.builtin-spack-packages-git-hash }}
     #     description: |
-    #       Git hash of the 'access-nri/spack-packages' repository at the specified version.
+    #       Git hash of the 'spack/spack-packages' repository at the specified version.
+    #   access-spack-packages-version:
+    #     value: ${{ jobs.check-config.outputs.access-spack-packages-version }}
+    #     description: |
+    #       Git ref of 'access-nri/access-spack-packages' that is used to reference custom packages in spack.
+    #   access-spack-packages-git-hash:
+    #     value: ${{ jobs.check-config.outputs.access-spack-packages-git-hash }}
+    #     description: |
+    #       Git hash of the 'access-nri/access-spack-packages' repository at the specified version.
     #   release-deployment-version:
     #     value: ${{ jobs.check-spack-yaml.outputs.release }}
     #     description: |
@@ -146,80 +154,115 @@ jobs:
   check-config:
     name: '${{ inputs.deployment-target }}: Check Config'
     runs-on: ubuntu-latest
+    # A lot of outputs, versions for repositories are taken from different sources:
+    #   Taken from central build-cd config/settings.json: spack (SHA), spack-config, builtin spack-packages
+    #   Taken from caller config/versions.json: spack (branch), access-spack-packages
     outputs:
-      spack-version: ${{ steps.spack.outputs.version }}
-      spack-git-hash: ${{ steps.spack.outputs.git-hash }}
-      spack-packages-version: ${{ steps.spack-packages.outputs.version }}
-      spack-packages-git-hash: ${{ steps.spack-packages.outputs.git-hash }}
-      spack-config-version:  ${{ steps.spack-config.outputs.version }}
-      spack-config-git-hash: ${{ steps.spack-config.outputs.git-hash }}
+      spack-version: ${{ steps.config-versions-refs.outputs.spack-branch }}
+      spack-git-hash: ${{ steps.spack-sha.outputs.sha }}
+
+      builtin-spack-packages-version: ${{ steps.config-settings-refs.outputs.builtin-spack-packages-ref }}
+      builtin-spack-packages-git-hash: ${{ steps.builtin-spack-packages-sha.outputs.sha }}
+
+      access-spack-packages-version: ${{ steps.config-versions-refs.outputs.access-spack-packages-ref }}
+      access-spack-packages-git-hash: ${{ steps.access-spack-packages-sha.outputs.sha }}
+
+      spack-config-version:  ${{ steps.config-settings-refs.outputs.spack-config-ref }}
+      spack-config-git-hash: ${{ steps.spack-config-sha.outputs.sha }}
+
       config-settings-failures: ${{ steps.settings.outputs.failures }}
     steps:
-      - name: Checkout ${{ github.repository }} Config
+      # Validate the caller repository's config files and versions
+      - name: '${{ github.repository }}: Checkout ${{ github.repository }} Config'
         uses: actions/checkout@v4
         with:
           path: model
           ref: ${{ inputs.deployment-ref }}
 
-      - name: Validate ${{ github.repository }} config/versions.json
+      - name: '${{ github.repository }}: Validate config/versions.json'
         uses: access-nri/schema/.github/actions/validate-with-schema@main
         with:
           schema-version: ${{ inputs.config-versions-schema-version }}
           schema-location: au.org.access-nri/model/deployment/config/versions
           data-location: ./model/config/versions.json
 
-      - name: Validate ${{ github.repository }} config/packages.json
+      - name: '${{ github.repository }}: Validate config/packages.json'
         uses: access-nri/schema/.github/actions/validate-with-schema@main
         with:
           schema-version: ${{ inputs.config-packages-schema-version }}
           schema-location: au.org.access-nri/model/deployment/config/packages
           data-location: ./model/config/packages.json
 
-      - name: Validate spack-packages version
-        id: spack-packages
-        uses: access-nri/build-cd/.github/actions/validate-repo-version@v6
+      - name: '${{ github.repository }}: Get repository refs from config/versions.json'
+        id: config-versions-refs
+        run: |
+          echo "spack-branch=$(jq --compact-output --raw-output '.spack' model/config/versions.json)" >> $GITHUB_OUTPUT
+          echo "access-spack-packages-ref=$(jq --compact-output --raw-output '."access-spack-packages"' model/config/versions.json)" >> $GITHUB_OUTPUT
+
+      - name: '${{ github.repository }}: Validate spack branch'
+        id: spack-branch-check
+        uses: access-nri/actions/.github/actions/get-git-ref-info@main
         with:
-          repo-to-check: spack-packages
-          pr: ${{ inputs.deployment-ref }}
+          repository: ACCESS-NRI/spack
+          ref: releases/v${{ steps.config-versions-refs.outputs.spack-branch }}
 
-      - name: Validate spack version
-        id: spack
-        uses: access-nri/build-cd/.github/actions/validate-repo-version@v6
+      - name: '${{ github.repository }}: Get access-spack-packages SHA'
+        id: access-spack-packages-sha
+        uses: access-nri/actions/.github/actions/get-git-ref-info@main
         with:
-          repo-to-check: spack
-          pr: ${{ inputs.deployment-ref }}
+          repository: ACCESS-NRI/access-spack-packages
+          ref: ${{ steps.config-versions-refs.outputs.builtin-spack-packages-ref }}
 
-      - name: Checkout build-cd Config
+      # Validate the build-cd repository's config/settings.json for the deployment target
+      - name: 'build-cd: Checkout build-cd Config'
         uses: actions/checkout@v4
         with:
           repository: access-nri/build-cd
           path: cd
 
-      - name: Get spack-config version
-        id: spack-config
-        env:
-          GH_TOKEN: ${{ secrets.GITHUB_TOKEN }}
-        run: |
-          version=$(jq --compact-output --raw-output \
-              --arg spack_version "${{ steps.spack.outputs.version }}" \
-              '.deployment.${{ inputs.deployment-target }}.${{ inputs.deployment-type }}[$spack_version]."spack-config"' cd/config/settings.json
-          )
-          echo $version
-          echo "version=$version" >> $GITHUB_OUTPUT
-
-          git_hash=$(gh api /repos/access-nri/spack-config/tags \
-            | jq --compact-output --raw-output --arg v "$version" '.[] | select(.name == $v) | .commit.sha'
-          )
-          echo $git_hash
-          echo "git-hash=$git_hash" >> $GITHUB_OUTPUT
-
-      - name: Validate build-cd config/settings.json
+      - name: 'build-cd: Validate config/settings.json'
         id: settings
         uses: access-nri/build-cd/.github/actions/validate-deployment-settings@v6
         with:
           settings-path: ./cd/config/settings.json
           target: ${{ inputs.deployment-target }}
 
+      - name: 'build-cd: Get repository refs from config/settings.json'
+        id: config-settings-refs
+        run: |
+          refs_for_deployment=$(jq \
+              --arg spack_version "${{ steps.config-versions-refs.outputs.spack-branch }}" \
+              '.deployment.${{ inputs.deployment-target }}.${{ inputs.deployment-type }}[$spack_version]' \
+              cd/config/settings.json
+          )
+
+          echo "$refs_for_deployment"
+
+          echo "spack-ref=$(jq --compact-output --raw-output '.spack' <<< "$refs_for_deployment")" >> $GITHUB_OUTPUT
+          echo "spack-config-ref=$(jq --compact-output --raw-output '."spack-config"' <<< "$refs_for_deployment")" >> $GITHUB_OUTPUT
+          echo "builtin-spack-packages-ref=$(jq --compact-output --raw-output '."builtin-spack-packages"' <<< "$refs_for_deployment")" >> $GITHUB_OUTPUT
+
+      - name: 'build-cd: Get spack SHA'
+        id: spack-sha
+        uses: access-nri/actions/.github/actions/get-git-ref-info@main
+        with:
+          repository: ACCESS-NRI/spack
+          ref: ${{ steps.config-settings-refs.outputs.spack-ref }}
+
+      - name: 'build-cd: Get spack-config SHA'
+        id: spack-config-sha
+        uses: access-nri/actions/.github/actions/get-git-ref-info@main
+        with:
+          repository: ACCESS-NRI/spack-config
+          ref: ${{ steps.config-settings-refs.outputs.spack-config-ref }}
+
+      - name: 'build-cd: Get builtin spack-packages SHA'
+        id: builtin-spack-packages-sha
+        uses: access-nri/actions/.github/actions/get-git-ref-info@main
+        with:
+          repository: spack/spack-packages
+          ref: ${{ steps.config-settings-refs.outputs.builtin-spack-packages-ref }}
+
   check-spack-yaml:
     name: '${{ inputs.deployment-target }}: Check Spack Manifest'
     runs-on: ubuntu-latest
@@ -369,8 +412,10 @@ jobs:
             spack_git_hash: "${{ needs.check-config.outputs.spack-git-hash }}",
             spack_config_version: "${{ needs.check-config.outputs.spack-config-version }}",
             spack_config_git_hash: "${{ needs.check-config.outputs.spack-config-git-hash }}",
-            spack_packages_version: "${{ needs.check-config.outputs.spack-packages-version }}",
-            spack_packages_git_hash: "${{ needs.check-config.outputs.spack-packages-git-hash }}",
+            builtin_spack_packages_version: "${{ needs.check-config.outputs.builtin-spack-packages-version }}",
+            builtin_spack_packages_git_hash: "${{ needs.check-config.outputs.builtin-spack-packages-git-hash }}",
+            access_spack_packages_version: "${{ needs.check-config.outputs.access-spack-packages-version }}",
+            access_spack_packages_git_hash: "${{ needs.check-config.outputs.access-spack-packages-git-hash }}",
             ci_configuration_check_failure: ${{ needs.check-config.outputs.config-settings-failures != '' }},
             release_deployment_version: "${{ needs.check-spack-yaml.outputs.release }}",
             spack_environment_name: "${{ needs.check-spack-yaml.outputs.spack-env-name }}",