Fix bug in multiply_bsdf for GLSL (#2328)

niklasharrysson · web-flow · commit 47a63325f4d9 · 2025-04-03T13:03:25.000-07:00
This change list fixes a bug in the GLSL implementation of node multiply_bsdf, as logged in #2324.
diff --git a/libraries/pbrlib/genglsl/mx_multiply_bsdf_color3.glsl b/libraries/pbrlib/genglsl/mx_multiply_bsdf_color3.glsl
@@ -4,5 +4,5 @@ void mx_multiply_bsdf_color3(ClosureData closureData, BSDF in1, vec3 in2, out BS
 {
     vec3 tint = clamp(in2, 0.0, 1.0);
     result.response = in1.response * tint;
-    result.throughput = in1.throughput * tint;
+    result.throughput = in1.throughput;
 }
diff --git a/libraries/pbrlib/genglsl/mx_multiply_bsdf_float.glsl b/libraries/pbrlib/genglsl/mx_multiply_bsdf_float.glsl
@@ -4,5 +4,5 @@ void mx_multiply_bsdf_float(ClosureData closureData, BSDF in1, float in2, out BS
 {
     float weight = clamp(in2, 0.0, 1.0);
     result.response = in1.response * weight;
-    result.throughput = in1.throughput * weight;
+    result.throughput = in1.throughput;
 }

Original file line number	Diff line number	Diff line change
`@@ -4,5 +4,5 @@ void mx_multiply_bsdf_color3(ClosureData closureData, BSDF in1, vec3 in2, out BS`
`4`	`4`	`{`
`5`	`5`	`vec3 tint = clamp(in2, 0.0, 1.0);`
`6`	`6`	`result.response = in1.response * tint;`
`7`		`- result.throughput = in1.throughput * tint;`
	`7`	`+ result.throughput = in1.throughput;`
`8`	`8`	`}`
Original file line number	Diff line number	Diff line change
`@@ -4,5 +4,5 @@ void mx_multiply_bsdf_float(ClosureData closureData, BSDF in1, float in2, out BS`
`4`	`4`	`{`
`5`	`5`	`float weight = clamp(in2, 0.0, 1.0);`
`6`	`6`	`result.response = in1.response * weight;`
`7`		`- result.throughput = in1.throughput * weight;`
	`7`	`+ result.throughput = in1.throughput;`
`8`	`8`	`}`