Address co-pilot comment about shadername generation

Author: ashwinbhat

source/MaterialXTest/MaterialXRender/RenderUtil.h

@@ -190,30 +190,22 @@ struct RenderItem
         : element(std::move(elem)),
           imageSearchPath(std::move(searchPath)),
           outputPath(std::move(outPath)),
-          imageVec(images) {}
+          imageVec(images)
+    {
+        mx::StringMap pathMap;
+        pathMap["/"] = "_";
+        pathMap[":"] = "_";
+        shaderName = mx::createValidName(
+            mx::replaceSubstrings(element->getNamePath(), pathMap));
+    }
 
     mx::TypedElementPtr element;
     mx::FileSearchPath imageSearchPath;
     mx::FilePath outputPath;
     mx::ImageVec* imageVec = nullptr;
-
-    const std::string& shaderName() const
-    {
-        if (_cachedShaderName.empty())
-        {
-            mx::StringMap pathMap;
-            pathMap["/"] = "_";
-            pathMap[":"] = "_";
-            _cachedShaderName = mx::createValidName(
-                mx::replaceSubstrings(element->getNamePath(), pathMap));
-        }
-        return _cachedShaderName;
-    }
+    std::string shaderName;
 
     mx::DocumentPtr doc() const { return element->getDocument(); }
-
-  private:
-    mutable std::string _cachedShaderName;
 };
 
 // Returned by runRenderer — each call produces its own isolated profiling data.

source/MaterialXTest/MaterialXRenderGlsl/RenderGlsl.cpp

@@ -151,7 +151,7 @@ RenderUtil::RenderProfileResult GlslShaderRenderTester::runRenderer(
     mx::GenContext& context)
 {
     RenderUtil::RenderProfileResult result;
-    const std::string& shaderName = item.shaderName();
+    const std::string& shaderName = item.shaderName;
     mx::DocumentPtr doc = item.doc();
     mx::TypedElementPtr element = item.element;
     const GenShaderUtil::TestSuiteOptions& testOptions = session.testOptions;

source/MaterialXTest/MaterialXRenderMdl/RenderMdl.cpp

@@ -46,7 +46,7 @@ RenderUtil::RenderProfileResult MdlShaderRenderTester::runRenderer(
     mx::GenContext& context)
 {
     RenderUtil::RenderProfileResult result;
-    const std::string& shaderName = item.shaderName();
+    const std::string& shaderName = item.shaderName;
     mx::DocumentPtr doc = item.doc();
     mx::TypedElementPtr element = item.element;
     const GenShaderUtil::TestSuiteOptions& testOptions = session.testOptions;

source/MaterialXTest/MaterialXRenderMsl/RenderMsl.mm

@@ -158,7 +158,7 @@ void registerLights(mx::DocumentPtr document, const GenShaderUtil::TestSuiteOpti
     mx::GenContext& context)
 {
     RenderUtil::RenderProfileResult result;
-    const std::string& shaderName = item.shaderName();
+    const std::string& shaderName = item.shaderName;
     mx::DocumentPtr doc = item.doc();
     mx::TypedElementPtr element = item.element;
     const GenShaderUtil::TestSuiteOptions& testOptions = session.testOptions;

source/MaterialXTest/MaterialXRenderOsl/RenderOsl.cpp

@@ -194,7 +194,7 @@ RenderUtil::RenderProfileResult OslShaderRenderTester::runRenderer(
     mx::GenContext& context)
 {
     RenderUtil::RenderProfileResult result;
-    const std::string& shaderName = item.shaderName();
+    const std::string& shaderName = item.shaderName;
     mx::DocumentPtr doc = item.doc();
     mx::TypedElementPtr element = item.element;
     const GenShaderUtil::TestSuiteOptions& testOptions = session.testOptions;

source/MaterialXTest/MaterialXRenderSlang/RenderSlang.cpp

@@ -150,7 +150,7 @@ RenderUtil::RenderProfileResult SlangShaderRenderTester::runRenderer(
     mx::GenContext& context)
 {
     RenderUtil::RenderProfileResult result;
-    const std::string& shaderName = item.shaderName();
+    const std::string& shaderName = item.shaderName;
     mx::DocumentPtr doc = item.doc();
     mx::TypedElementPtr element = item.element;
     const GenShaderUtil::TestSuiteOptions& testOptions = session.testOptions;