Static analysis fixes (#2320)

This changelist addresses two static analysis warnings flagged by PVS-Studio:

- Favor defaulted destructors over explicit empty destructors for performance.
- Add a missing initializer for the _inlined member of SourceCodeNode.

Author: jstone-lucasfilm

source/MaterialXCore/Document.cpp

@@ -32,7 +32,7 @@ class Document::Cache
         valid(false)
     {
     }
-    ~Cache() { }
+    ~Cache() = default;
 
     void refresh()
     {

source/MaterialXCore/Element.cpp

@@ -933,7 +933,7 @@ template <class T> class ElementRegistry
     {
         Element::_creatorMap[T::CATEGORY] = Element::createElement<T>;
     }
-    ~ElementRegistry() { }
+    ~ElementRegistry() = default;
 };
 
 //

source/MaterialXCore/Element.h

@@ -1366,7 +1366,7 @@ class MX_CORE_API ElementEquivalenceOptions
         floatPrecision = Value::getFloatPrecision();
         attributeExclusionList = {};
     };
-    ~ElementEquivalenceOptions() { }
+    ~ElementEquivalenceOptions() = default;
 
     /// Perform value comparisons as opposed to literal string comparisons.
     /// Default is true.

source/MaterialXCore/Geom.h

@@ -64,7 +64,7 @@ class MX_CORE_API GeomPath
         _empty(true)
     {
     }
-    ~GeomPath() { }
+    ~GeomPath() = default;
 
     bool operator==(const GeomPath& rhs) const
     {

source/MaterialXCore/Traversal.h

@@ -35,7 +35,7 @@ class MX_CORE_API Edge
         _elemUp(elemUp)
     {
     }
-    ~Edge() { }
+    ~Edge() = default;
 
     bool operator==(const Edge& rhs) const
     {
@@ -94,7 +94,7 @@ class MX_CORE_API TreeIterator
         _holdCount(0)
     {
     }
-    ~TreeIterator() { }
+    ~TreeIterator() = default;
 
   private:
     using StackFrame = std::pair<ElementPtr, size_t>;
@@ -198,7 +198,7 @@ class MX_CORE_API GraphIterator
     {
         _pathElems.insert(elem);
     }
-    ~GraphIterator() { }
+    ~GraphIterator() = default;
 
   private:
     using ElementSet = std::set<ElementPtr>;
@@ -341,7 +341,7 @@ class MX_CORE_API InheritanceIterator
     {
         _pathElems.insert(elem);
     }
-    ~InheritanceIterator() { }
+    ~InheritanceIterator() = default;
 
   private:
     using ConstElementSet = std::set<ConstElementPtr>;

source/MaterialXCore/Value.cpp

@@ -421,7 +421,7 @@ template <class T> class ValueRegistry
             Value::_creatorMap[TypedValue<T>::TYPE] = TypedValue<T>::createFromString;
         }
     }
-    ~ValueRegistry() { }
+    ~ValueRegistry() = default;
 };
 
 //

source/MaterialXFormat/File.h

@@ -49,7 +49,7 @@ class MX_FORMAT_API FilePath
         _type(TypeRelative)
     {
     }
-    ~FilePath() { }
+    ~FilePath() = default;
 
     bool operator==(const FilePath& rhs) const
     {

source/MaterialXFormat/XmlIo.h

@@ -35,7 +35,7 @@ class MX_FORMAT_API XmlReadOptions
 {
   public:
     XmlReadOptions();
-    ~XmlReadOptions() { }
+    ~XmlReadOptions() = default;
 
     /// If true, then XML comments will be read into documents as comment elements.
     /// Defaults to false.
@@ -64,7 +64,7 @@ class MX_FORMAT_API XmlWriteOptions
 {
   public:
     XmlWriteOptions();
-    ~XmlWriteOptions() { }
+    ~XmlWriteOptions() = default;
 
     /// If true, elements with source file markings will be written as
     /// XIncludes rather than explicit data.  Defaults to true.

source/MaterialXGenShader/Nodes/SourceCodeNode.h

@@ -29,7 +29,7 @@ class MX_GENSHADER_API SourceCodeNode : public ShaderNodeImpl
     /// Resolve the source file and read the source code during the initialization of the node.
     virtual void resolveSourceCode(const InterfaceElement& element, GenContext& context);
 
-    bool _inlined;
+    bool _inlined = false;
     string _functionName;
     string _functionSource;
     FilePath _sourceFilename;

source/MaterialXGenShader/ShaderGraph.h

@@ -235,7 +235,7 @@ class MX_GENSHADER_API ShaderGraphEdgeIterator
 {
   public:
     ShaderGraphEdgeIterator(ShaderOutput* output);
-    ~ShaderGraphEdgeIterator() { }
+    ~ShaderGraphEdgeIterator() = default;
 
     bool operator==(const ShaderGraphEdgeIterator& rhs) const
     {