Skip to content

Commit e1b6197

Browse files
authored
Update values in example materials (#2314)
Fixes: * In the division matrix33 test, the divisor was still a singular matrix, now it is aligned with matrix44. * In rotate3d, the rotation was 180 degrees which, if used as an actual test, would miss transposed rotation matrices. The rotation is now 135 degrees to clearly separate the left and right rotation. * In rotate2d, the rotation was 90 degrees, and it was updated to 135 degrees (3/4 PI) to also avoid missing possible bugs in rotation matrix. This set of changes makes running tests on all of `resources/Materials` more useful.
1 parent 5f3bc0f commit e1b6197

2 files changed

Lines changed: 3 additions & 3 deletions

File tree

resources/Materials/TestSuite/stdlib/math/math_operators.mtlx

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -702,7 +702,7 @@
702702
<nodegraph name="divide_matrix33">
703703
<divide name="divide1" type="matrix33">
704704
<input name="in1" type="matrix33" value="1.5, 1.5, 0.0, 0.0, 1.5, 1.5, 0.0, 0.0, 1.0" />
705-
<input name="in2" type="matrix33" value="1.0, 1.0, 1.0, 1.0, 1.0, 1.0, 1.0, 1.0, 1.0" />
705+
<input name="in2" type="matrix33" value="1.0, 1.0, 0.0, 0.0, 1.0, 1.0, 0.0, 0.0, 1.0" />
706706
</divide>
707707
<transformmatrix name="transformmatrix1" type="vector3">
708708
<input name="in" type="vector3" value="0.5, 0.5, 0.5" />

resources/Materials/TestSuite/stdlib/math/vector_math.mtlx

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -71,7 +71,7 @@
7171
<output name="out" type="vector2" nodename="rotate1" />
7272
<rotate2d name="rotate1" type="vector2">
7373
<input name="in" type="vector2" nodename="combine1" />
74-
<input name="amount" type="float" value="1.5708" unittype="angle" unit="radian" />
74+
<input name="amount" type="float" value="2.356" unittype="angle" unit="radian" />
7575
</rotate2d>
7676
<separate3 name="separate" type="multioutput">
7777
<input name="in" type="vector3" nodename="position1" />
@@ -87,7 +87,7 @@
8787
</position>
8888
<rotate3d name="rotate1" type="vector3">
8989
<input name="in" type="vector3" nodename="position1" />
90-
<input name="amount" type="float" value="180.0000" unittype="angle" unit="degree" />
90+
<input name="amount" type="float" value="135.0000" unittype="angle" unit="degree" />
9191
<input name="axis" type="vector3" value="0.0, 1.0000, 1.0000" />
9292
</rotate3d>
9393
<output name="out" type="vector3" nodename="rotate1" />

0 commit comments

Comments
 (0)