Remove reservedWords from ShaderGraph constructor#2600
Merged
ld-kerley merged 1 commit intoAcademySoftwareFoundation:mainfrom Oct 2, 2025
Merged
Conversation
niklasharrysson
approved these changes
Oct 2, 2025
Contributor
niklasharrysson
left a comment
niklasharrysson
left a comment
There was a problem hiding this comment.
This looks good to me.
It's highly unlikely that this constructor is used outside this library. But also, if someone are using it, it's probably a good thing that it breaks their build, since the behavior has changed as the input is no longer used.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR removes the
reservedWordsargument from theShaderGraphconstructor as its no longer needed after #2598 was merged.This is a separate PR, to be easy to revert if it causes any downstream API issues.
I think there may be more reservedWord related clean up possible - but that might need a little more investigation - so I'll post that as a separate PR.