Commit 8d306ac
[scheduler] Allow jobs without an OS constraint to dispatch (#2246)
## Related Issues
Fixes #2172
## Summarize your change.
Jobs that do not set a layer or job OS were being rejected by the Rust
scheduler because the matcher compared every host OS against `None`
literally. This change only applies the OS filter when an OS constraint
is present, so jobs launched without `OL_OS` or an explicit `os`
continue to dispatch normally.
It also adds matcher regression tests covering unset, matching, and
mismatched OS constraints.
## Validation
- `cargo test -p scheduler pipeline::matcher::tests -- --nocapture`
<!-- This is an auto-generated comment: release notes by coderabbit.ai
-->
## Summary by CodeRabbit
* **Tests**
* Added unit tests validating OS compatibility matching in the scheduler
to ensure hosts are correctly assigned to layers based on their
operating system.
<!-- end of auto-generated comment: release notes by coderabbit.ai -->
Co-authored-by: Diego Tavares <dtavares@imageworks.com>1 parent a94e690 commit 8d306ac
1 file changed
Lines changed: 57 additions & 1 deletion
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
185 | 185 | | |
186 | 186 | | |
187 | 187 | | |
| 188 | + | |
| 189 | + | |
| 190 | + | |
| 191 | + | |
188 | 192 | | |
189 | 193 | | |
190 | 194 | | |
| |||
206 | 210 | | |
207 | 211 | | |
208 | 212 | | |
209 | | - | |
| 213 | + | |
210 | 214 | | |
211 | 215 | | |
212 | 216 | | |
| |||
500 | 504 | | |
501 | 505 | | |
502 | 506 | | |
| 507 | + | |
| 508 | + | |
| 509 | + | |
| 510 | + | |
| 511 | + | |
| 512 | + | |
| 513 | + | |
| 514 | + | |
| 515 | + | |
| 516 | + | |
| 517 | + | |
| 518 | + | |
| 519 | + | |
| 520 | + | |
| 521 | + | |
| 522 | + | |
| 523 | + | |
| 524 | + | |
| 525 | + | |
| 526 | + | |
| 527 | + | |
| 528 | + | |
| 529 | + | |
| 530 | + | |
| 531 | + | |
| 532 | + | |
| 533 | + | |
| 534 | + | |
| 535 | + | |
| 536 | + | |
| 537 | + | |
| 538 | + | |
| 539 | + | |
| 540 | + | |
| 541 | + | |
| 542 | + | |
| 543 | + | |
| 544 | + | |
| 545 | + | |
| 546 | + | |
| 547 | + | |
| 548 | + | |
| 549 | + | |
| 550 | + | |
| 551 | + | |
| 552 | + | |
| 553 | + | |
| 554 | + | |
| 555 | + | |
| 556 | + | |
| 557 | + | |
| 558 | + | |
0 commit comments