Skip to content

Commit 34b2b22

Browse files
authored
MaterialX: metal edge tint should not be multiplied by specular_weight (#240)
Fixes a bug in the MtlX graph. The edge-tint color for the `generalized_schlick_bsdf` should not be multiplied by `specular_weight`, as the whole lobe is multiplied by `specular_weight` as well.
1 parent 3845bc1 commit 34b2b22

1 file changed

Lines changed: 2 additions & 6 deletions

File tree

reference/open_pbr_surface.mtlx

Lines changed: 2 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -410,22 +410,18 @@
410410
<input name="in1" type="color3" interfacename="base_color" />
411411
<input name="in2" type="float" interfacename="base_weight" />
412412
</multiply>
413-
<multiply name="metal_edgecolor" type="color3">
414-
<input name="in1" type="color3" interfacename="specular_color" />
415-
<input name="in2" type="float" interfacename="specular_weight" />
416-
</multiply>
417413
<generalized_schlick_bsdf name="metal_bsdf" type="BSDF">
418414
<input name="weight" type="float" interfacename="specular_weight" />
419415
<input name="color0" type="color3" nodename="metal_reflectivity" />
420-
<input name="color82" type="color3" nodename="metal_edgecolor" />
416+
<input name="color82" type="color3" interfacename="specular_color" />
421417
<input name="roughness" type="vector2" nodename="main_roughness" />
422418
<input name="normal" type="vector3" interfacename="geometry_normal" />
423419
<input name="tangent" type="vector3" interfacename="geometry_tangent" />
424420
</generalized_schlick_bsdf>
425421
<generalized_schlick_bsdf name="metal_bsdf_tf" type="BSDF">
426422
<input name="weight" type="float" interfacename="specular_weight" />
427423
<input name="color0" type="color3" nodename="metal_reflectivity" />
428-
<input name="color82" type="color3" nodename="metal_edgecolor" />
424+
<input name="color82" type="color3" interfacename="specular_color" />
429425
<input name="roughness" type="vector2" nodename="main_roughness" />
430426
<input name="normal" type="vector3" interfacename="geometry_normal" />
431427
<input name="tangent" type="vector3" interfacename="geometry_tangent" />

0 commit comments

Comments
 (0)