Skip to content
This repository was archived by the owner on Jun 21, 2023. It is now read-only.

Commit 081a903

Browse files
author
Michal Vlasák
committed
Show logger name in default format message
1 parent dfc4c73 commit 081a903

2 files changed

Lines changed: 21 additions & 1 deletion

File tree

src/stackdriver.ts

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -13,6 +13,9 @@ class StackDriverFormatStream extends Transform {
1313
// tslint:disable-next-line:function-name
1414
public _transform(chunk: any, _encoding: string, callback: (error?: Error | undefined, data?: any) => void) {
1515
const obj = JSON.parse(chunk);
16+
if (obj.name) {
17+
obj.message = `[${obj.name}] ${obj.message}`;
18+
}
1619
obj.severity = PINO_TO_STACKDRIVER[obj.level] || 'UNKNOWN';
1720

1821
this.push(`${JSON.stringify(obj)}\n`);

src/tests/index.test.ts

Lines changed: 18 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,5 @@
11
import * as express from 'express';
2+
import 'jest-extended';
23
import { Writable } from 'stream';
34
import * as supertest from 'supertest';
45
import { levels } from '../levels';
@@ -59,7 +60,7 @@ test('child logger has warning level', () =>
5960
loggerFactory({
6061
streams: [
6162
testWriteStream(resolve, json => {
62-
expect(json.message).toBe('Hello');
63+
expect(json.message).toContain('Hello');
6364
expect(json.level).toBe(levels.warn);
6465
}),
6566
],
@@ -182,3 +183,19 @@ test('silent stream does not write', () => {
182183
logger.fatal('Hello');
183184
expect(loggerWrites).not.toBeCalled();
184185
});
186+
187+
test('logger name is shown in non-pretty message', () =>
188+
new Promise((resolve, reject) => {
189+
const loggerName = 'database';
190+
loggerFactory({
191+
streams: [
192+
testWriteStream(resolve, json => {
193+
expect(json.name).toBe(loggerName);
194+
expect(json.message).toStartWith(`[${loggerName}] `);
195+
}),
196+
],
197+
});
198+
const logger = loggerFactory(loggerName);
199+
200+
logger.fatal('Hello');
201+
}));

0 commit comments

Comments
 (0)