Skip to content
This repository was archived by the owner on Jun 21, 2023. It is now read-only.

Commit 25a7a0f

Browse files
author
Michal Vlasák
committed
Refactor tests and moduleName variable
1 parent 1bc3d75 commit 25a7a0f

2 files changed

Lines changed: 8 additions & 8 deletions

File tree

src/index.ts

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -97,31 +97,31 @@ let rootLogger: AckeeLogger;
9797
let rootOptions: AckeeLoggerOptions;
9898

9999
const parseLoggerData = (data: string | AckeeLoggerOptions = {}) => {
100-
let moduleName: string | undefined;
100+
let loggerName: string | undefined;
101101
let options: AckeeLoggerOptions = {};
102102
if (data) {
103103
if (isString(data)) {
104-
moduleName = data;
104+
loggerName = data;
105105
} else if (isObject(data)) {
106106
options = data;
107107
} else {
108108
throw new TypeError(`Invalid argument of type ${typeof data}`);
109109
}
110110
}
111-
return { moduleName, options };
111+
return { loggerName, options };
112112
};
113113

114114
const loggerFactory = (data: string | AckeeLoggerOptions = {}): AckeeLogger => {
115-
const { moduleName, options } = parseLoggerData(data);
115+
const { loggerName, options } = parseLoggerData(data);
116116

117117
if (!rootLogger) {
118118
rootLogger = defaultLogger(options);
119119
rootOptions = options;
120120
}
121-
if (!moduleName) {
121+
if (!loggerName) {
122122
return rootLogger;
123123
}
124-
return defaultLogger(Object.assign({ loggerName: moduleName }, rootOptions));
124+
return defaultLogger(Object.assign({ loggerName }, rootOptions));
125125
};
126126

127127
const factoryProxy = new Proxy(loggerFactory, {

src/tests/index.test.ts

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -192,7 +192,7 @@ const exampleMessages = [
192192

193193
exampleMessages.forEach(data => {
194194
test(`logger name is shown in non-pretty ${data.type} message`, () =>
195-
new Promise((resolve, reject) => {
195+
new Promise(resolve => {
196196
const loggerName = 'database';
197197
loggerFactory({
198198
pretty: false,
@@ -210,7 +210,7 @@ exampleMessages.forEach(data => {
210210

211211
exampleMessages.forEach(data => {
212212
test(`logger name is propagated to pretty object with ${data.type} message`, () =>
213-
new Promise((resolve, reject) => {
213+
new Promise(resolve => {
214214
const loggerName = 'database';
215215
loggerFactory({
216216
pretty: true,

0 commit comments

Comments
 (0)