Merge pull request #37 from AckeeCZ/feat/remove-time-and-agent

🔥 Remove time and user agent from express messages

Author: vlasy

CHANGELOG.md

@@ -8,6 +8,7 @@
 ### Changed
 - `pino.pretty` replaced with `util.inspect`
 - rename interfaces
+- removed user agent and response time from express middleware logs
 
 ## [1.1.0] - 2019-08-05
 

src/express.ts

@@ -28,11 +28,12 @@ const expressOnFinished = (logger: Cosmas, req: AckeeRequest) => (_err: Error |
     }
     const error = res[errorSymbol];
     const userAgent = req.headers['user-agent'];
-    const reqOut = `${res.statusCode} ${req.method} ${req.originalUrl} ${res.time} ms ${userAgent ? userAgent : ''}`;
+    const reqOut = `${res.statusCode} ${req.method} ${req.originalUrl}`;
     const standardOutput = {
         data: {
             req,
             res,
+            userAgent,
             ackId: req.ackId,
         },
         message: `${reqOut} - Standard output`,
@@ -55,8 +56,7 @@ const expressMiddleware: RequestHandler = function(
     response: AckeeResponse,
     next: any
 ) {
-    const userAgent = req.headers['user-agent'];
-    const reqIn = `--- ${req.method} ${req.originalUrl} ${userAgent ? userAgent : ''}`;
+    const reqIn = `--- ${req.method} ${req.originalUrl}`;
     if (!shouldSkipLogging(this, req)) {
         this.debug({ req, ackId: req.ackId }, `${reqIn} - Request accepted`);
     }

src/tests/express.test.ts

@@ -125,15 +125,15 @@ test('route can be ignored using regexp helper', () => {
     });
 });
 
-test('user-agent is logged', () => {
+test('user-agent is not logged', () => {
     const loggerWrites = jest.fn();
     const logger = loggerFactory({
         streams: [
             {
                 stream: new Writable({
                     write: (chunk, encoding, next) => {
                         const json = JSON.parse(chunk);
-                        expect(json.message).toMatch('dummy agent');
+                        expect(json.message).not.toMatch('dummy agent');
                         loggerWrites();
                         next();
                     },