Skip to content
This repository was archived by the owner on Jun 21, 2023. It is now read-only.

Commit 94903ee

Browse files
author
Michal Vlasák
committed
♻️ Rename interfaces
1 parent b995e3e commit 94903ee

5 files changed

Lines changed: 26 additions & 30 deletions

File tree

CHANGELOG.md

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -6,6 +6,7 @@
66

77
### Changed
88
- `pino.pretty` replaced with `util.inspect`
9+
- rename interfaces
910

1011
## [1.1.0] - 2019-08-05
1112

src/express.ts

Lines changed: 5 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -1,19 +1,14 @@
11
import { ErrorRequestHandler, Request, RequestHandler, Response } from 'express';
22
import * as onFinished from 'on-finished';
33
import onHeaders = require('on-headers');
4-
import { AckeeLogger } from '.';
4+
import { Cosmas } from '.';
55

66
const errorSymbol = Symbol.for('error');
77

88
type AckeeRequest = Request & { _startAt?: [number, number]; ackId?: string };
99
type AckeeResponse = Response & { _startAt?: [number, number]; time?: string; out?: object; [errorSymbol]?: any };
1010

11-
export type AckeeLoggerExpressMiddleware = (
12-
this: AckeeLogger,
13-
req: AckeeRequest,
14-
response: AckeeResponse,
15-
next: any
16-
) => void;
11+
export type CosmasExpressMiddleware = (this: Cosmas, req: AckeeRequest, response: AckeeResponse, next: any) => void;
1712

1813
const expressOnHeaders = (req: AckeeRequest, res: AckeeResponse) => () => {
1914
res._startAt = process.hrtime();
@@ -23,11 +18,11 @@ const expressOnHeaders = (req: AckeeRequest, res: AckeeResponse) => () => {
2318
res.time = ms.toFixed(3);
2419
};
2520

26-
const shouldSkipLogging = (logger: AckeeLogger, req: AckeeRequest, res?: AckeeResponse) =>
21+
const shouldSkipLogging = (logger: Cosmas, req: AckeeRequest, res?: AckeeResponse) =>
2722
(logger.options.skip && logger.options.skip(req, res)) ||
2823
(logger.options.ignoredHttpMethods && logger.options.ignoredHttpMethods.includes(req.method));
2924

30-
const expressOnFinished = (logger: AckeeLogger, req: AckeeRequest) => (_err: Error | null, res: AckeeResponse) => {
25+
const expressOnFinished = (logger: Cosmas, req: AckeeRequest) => (_err: Error | null, res: AckeeResponse) => {
3126
if (shouldSkipLogging(logger, req, res)) {
3227
return;
3328
}
@@ -55,7 +50,7 @@ const expressOnFinished = (logger: AckeeLogger, req: AckeeRequest) => (_err: Err
5550
};
5651

5752
const expressMiddleware: RequestHandler = function(
58-
this: AckeeLogger,
53+
this: Cosmas,
5954
req: AckeeRequest,
6055
response: AckeeResponse,
6156
next: any

src/index.ts

Lines changed: 12 additions & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -4,25 +4,25 @@ import isString = require('lodash.isstring');
44
import * as pino from 'pino';
55
import * as pinoms from 'pino-multi-stream';
66
import { Writable } from 'stream';
7-
import { AckeeLoggerExpressMiddleware, expressErrorMiddleware, expressMiddleware } from './express';
8-
import { AckeeLoggerOptions } from './interfaces';
7+
import { CosmasExpressMiddleware, expressErrorMiddleware, expressMiddleware } from './express';
8+
import { CosmasOptions } from './interfaces';
99
import * as serializers from './serializers';
1010
import { initLoggerStreams } from './streams';
1111

1212
export type PinoLogger = pino.BaseLogger;
1313
export type Level = pino.LevelWithSilent;
1414

15-
export interface AckeeLogger extends PinoLogger {
15+
export interface Cosmas extends PinoLogger {
1616
warning: pino.LogFn;
17-
options: AckeeLoggerOptions;
18-
express: AckeeLoggerExpressMiddleware;
17+
options: CosmasOptions;
18+
express: CosmasExpressMiddleware;
1919
expressError: ErrorRequestHandler;
2020
stream: Writable;
2121
(childName: string): any;
2222
}
2323

24-
export interface AckeeLoggerFactory extends AckeeLogger {
25-
(data?: string | AckeeLoggerOptions): AckeeLogger;
24+
export interface CosmasFactory extends Cosmas {
25+
(data?: string | CosmasOptions): Cosmas;
2626
}
2727

2828
// cannot use Symbols, because they aren't JSON.stringifyable
@@ -65,7 +65,7 @@ const maxLevelWrite: pino.WriteFn = function(this: any, data: object): void {
6565
}
6666
};
6767

68-
const defaultLogger = (options: AckeeLoggerOptions & { loggerName?: string } = {}): AckeeLogger => {
68+
const defaultLogger = (options: CosmasOptions & { loggerName?: string } = {}): Cosmas => {
6969
serializers.disablePaths(options.disableFields);
7070
serializers.enablePaths(options.enableFields);
7171

@@ -96,7 +96,7 @@ const defaultLogger = (options: AckeeLoggerOptions & { loggerName?: string } = {
9696
options.config
9797
),
9898
(pinoms as any).multistream(streams)
99-
) as PinoLogger) as AckeeLogger;
99+
) as PinoLogger) as Cosmas;
100100

101101
// Add maxLevel support to pino-multi-stream
102102
// This could be replaced with custom pass-through stream being passed to multistream, which would filter the messages
@@ -114,9 +114,9 @@ const defaultLogger = (options: AckeeLoggerOptions & { loggerName?: string } = {
114114
});
115115
};
116116

117-
const parseLoggerData = (data: string | AckeeLoggerOptions = {}) => {
117+
const parseLoggerData = (data: string | CosmasOptions = {}) => {
118118
let loggerName: string | undefined;
119-
let options: AckeeLoggerOptions = {};
119+
let options: CosmasOptions = {};
120120
if (data) {
121121
if (isString(data)) {
122122
loggerName = data;
@@ -129,7 +129,7 @@ const parseLoggerData = (data: string | AckeeLoggerOptions = {}) => {
129129
return { loggerName, options };
130130
};
131131

132-
const loggerFactory = (data: string | AckeeLoggerOptions = {}, loggerOptions: AckeeLoggerOptions = {}): AckeeLogger => {
132+
const loggerFactory = (data: string | CosmasOptions = {}, loggerOptions: CosmasOptions = {}): Cosmas => {
133133
const { loggerName, options } = parseLoggerData(data);
134134
loggerOptions = objEmpty(options) ? loggerOptions : options;
135135
const logger = defaultLogger(Object.assign({ loggerName }, loggerOptions));

src/interfaces.ts

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -6,18 +6,18 @@ interface LoggerOptions extends pino.LoggerOptions {
66
}
77

88
// this is basically enhanced version of pino-multi-stream.Streams type
9-
export interface AckeeLoggerStream {
9+
export interface CosmasStream {
1010
level?: pino.LevelWithSilent;
1111
maxLevel?: number; // this is not processed by pino, so we need the number directly
1212
stream: NodeJS.WritableStream;
1313
}
1414

15-
export interface AckeeLoggerOptions {
15+
export interface CosmasOptions {
1616
disableFields?: string[];
1717
enableFields?: string[];
1818
defaultLevel?: pino.LevelWithSilent;
1919
disableStackdriverFormat?: boolean;
20-
streams?: AckeeLoggerStream[];
20+
streams?: CosmasStream[];
2121
ignoredHttpMethods?: string[];
2222
config?: LoggerOptions;
2323
pretty?: boolean;

src/streams.ts

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -4,14 +4,14 @@ import * as pino from 'pino';
44
import { Transform, TransformCallback } from 'stream';
55
import * as util from 'util';
66
import { loggerNameKey, pkgVersionKey } from '.';
7-
import { AckeeLoggerOptions, AckeeLoggerStream } from './interfaces';
7+
import { CosmasOptions, CosmasStream } from './interfaces';
88
import { levels } from './levels';
99
import { SentryTransformStream } from './sentry';
1010
import { StackDriverFormatStream } from './stackdriver';
1111

1212
const pkgJson = JSON.parse(fs.readFileSync(path.resolve(path.join(__dirname, '..', 'package.json')), 'utf8'));
1313

14-
const getDefaultTransformStream = (options: AckeeLoggerOptions & { messageKey: string; loggerName?: string }) => {
14+
const getDefaultTransformStream = (options: CosmasOptions & { messageKey: string; loggerName?: string }) => {
1515
class DefaultTransformStream extends Transform {
1616
// tslint:disable-next-line:function-name
1717
public _transform(chunk: any, _encoding: string, callback: TransformCallback) {
@@ -42,7 +42,7 @@ const getDefaultTransformStream = (options: AckeeLoggerOptions & { messageKey: s
4242
return DefaultTransformStream;
4343
};
4444

45-
const decorateStreams = <T extends Transform>(streams: AckeeLoggerStream[], streamClass: new () => T) => {
45+
const decorateStreams = <T extends Transform>(streams: CosmasStream[], streamClass: new () => T) => {
4646
return streams.map(stream => {
4747
const newStream = new streamClass();
4848
newStream.pipe(stream.stream);
@@ -56,9 +56,9 @@ const decorateStreams = <T extends Transform>(streams: AckeeLoggerStream[], stre
5656

5757
const initLoggerStreams = (
5858
defaultLevel: pino.LevelWithSilent,
59-
options: AckeeLoggerOptions & { messageKey: string; loggerName?: string }
59+
options: CosmasOptions & { messageKey: string; loggerName?: string }
6060
) => {
61-
let streams: AckeeLoggerStream[];
61+
let streams: CosmasStream[];
6262
if (options.streams) {
6363
streams = options.streams.map(stream => Object.assign({ level: defaultLevel }, stream));
6464
} else {

0 commit comments

Comments
 (0)