fix: allow defaults to be set to false to disable setting

Author: mehalter

lua/astrolsp/config.lua

@@ -56,8 +56,8 @@
 ---@field operations AstroLSPFileOperationsOperationsOpts? enable/disable file operations
 
 ---@class AstroLSPDefaultOpts
----@field hover vim.lsp.buf.hover.Opts? control the default options for `vim.lsp.buf.hover()` (`:h vim.lsp.buf.hover.Opts`)
----@field signature_help vim.lsp.buf.signature_help.Opts? control the default options for `vim.lsp.buf.signature_help()` (`:h vim.lsp.buf.signature_help.Opts`)
+---@field hover vim.lsp.buf.hover.Opts|false? control the default options for `vim.lsp.buf.hover()` (`:h vim.lsp.buf.hover.Opts`)
+---@field signature_help vim.lsp.buf.signature_help.Opts|false? control the default options for `vim.lsp.buf.signature_help()` (`:h vim.lsp.buf.signature_help.Opts`)
 
 ---@class AstroLSPMasonLspconfigServer
 ---@field public package string the Mason package name
@@ -339,10 +339,7 @@ local M = {
   capabilities = {},
   ---@diagnostic disable-next-line: missing-fields
   config = {},
-  defaults = {
-    hover = {},
-    signature_help = {},
-  },
+  defaults = {},
   file_operations = { timeout = 10000, operations = {} },
   flags = {},
   formatting = { format_on_save = { enabled = true }, disabled = {} },

lua/astrolsp/init.lua

@@ -353,21 +353,23 @@ function M.setup(opts)
   end
 
   for method, default in pairs(M.config.defaults) do
-    -- TODO: remove conditional after dropping support for Neovim v0.10
-    if vim.fn.has "nvim-0.11" == 1 then
-      local original_method = vim.lsp.buf[method]
-      if type(original_method) == "function" then
-        vim.lsp.buf[method] = function(user_opts)
-          return original_method(vim.tbl_deep_extend("force", default or {}, user_opts or {}))
+    if default then
+      -- TODO: remove conditional after dropping support for Neovim v0.10
+      if vim.fn.has "nvim-0.11" == 1 then
+        local original_method = vim.lsp.buf[method]
+        if type(original_method) == "function" then
+          vim.lsp.buf[method] = function(user_opts)
+            return original_method(vim.tbl_deep_extend("force", default, user_opts or {}))
+          end
+        end
+      else
+        local deprecated_handler = ({
+          hover = "textDocument/hover",
+          signature_help = "textDocument/signatureHelp",
+        })[method]
+        if deprecated_handler and default then
+          vim.lsp.handlers[deprecated_handler] = vim.lsp.with(vim.lsp.handlers[deprecated_handler], default)
         end
-      end
-    else
-      local deprecated_handler = ({
-        hover = "textDocument/hover",
-        signature_help = "textDocument/signatureHelp",
-      })[method]
-      if deprecated_handler and default then
-        vim.lsp.handlers[deprecated_handler] = vim.lsp.with(vim.lsp.handlers[deprecated_handler], default)
       end
     end
   end