feat: continue migrating more tooling

Author: mehalter

.luacheckrc

@@ -1,5 +1,5 @@
 -- Global objects
-globals = { "vim" }
+globals = { "vim", "astronvim" }
 
 -- Rerun tests only if their modification time changed
 cache = true

.neoconf.json

@@ -14,7 +14,10 @@
   },
   "lspconfig": {
     "lua_ls": {
-      "Lua.format.enable": false
+      "Lua.format.enable": false,
+      "Lua.diagnostics.globals": [
+        "astronvim"
+      ]
     }
   }
 }

lua/astrolsp/config/init.lua

@@ -1,3 +1,5 @@
+local schemastore_avail, schemastore = pcall(require, "schemastore")
+
 return {
   diagnostics = {
     virtual_text = true,
@@ -48,15 +50,38 @@ return {
 
   flags = {},
 
-  config = {},
+  config = {
+    jsonls = {
+      settings = {
+        json = {
+          schemas = schemastore_avail and schemastore.json.schemas() or nil,
+          validate = { enable = schemastore_avail },
+        },
+      },
+    },
+    yamlls = { settings = { yaml = { schemas = schemastore_avail and schemastore.json.schemas() or nil } } },
+    lua_ls = {
+      before_init = function(param, config)
+        if vim.b.neodev_enabled and type(astronvim) == "table" and type(astronvim.supported_configs) == "table" then
+          for _, astronvim_config in ipairs(astronvim.supported_configs) do
+            if param.rootPath:match(astronvim_config) then
+              table.insert(config.settings.Lua.workspace.library, astronvim.install.home .. "/lua")
+              break
+            end
+          end
+        end
+      end,
+      settings = { Lua = { workspace = { checkThirdParty = false } } },
+    },
+  },
+
+  servers = {},
 
   -- on_attach = function(client, bufnr) ... end, -- user can pass in an extension of the on_attach
 
-  setup_handlers = {
-    function(server, opts) require("lspconfig")[server].setup(opts) end,
-  },
+  setup_handlers = { function(server, opts) require("lspconfig")[server].setup(opts) end },
 
-  formatting = { format_on_save = { enabled = true }, disable = {} },
+  formatting = { format_on_save = { enabled = true }, disabled = {} },
 
   mappings = require "astrolsp.config.mappings",
 }

lua/astrolsp/config/mappings.lua

@@ -42,13 +42,19 @@ M.n["gd"] = {
   cond = "textDocument/definition",
 }
 
--- TODO: Add proper conditions
-M.n["<leader>lf"] = { function() vim.lsp.buf.format(M.format_opts) end, desc = "Format buffer" }
+M.n["<leader>lf"] =
+  { function() vim.lsp.buf.format(M.format_opts) end, desc = "Format buffer", cond = "textDocument/formatting" }
 M.v["<leader>lf"] = M.n["<leader>lf"]
-M.n["<leader>uf"] =
-  { function() require("astronvim.utils.ui").toggle_buffer_autoformat() end, desc = "Toggle autoformatting (buffer)" }
-M.n["<leader>uF"] =
-  { function() require("astronvim.utils.ui").toggle_autoformat() end, desc = "Toggle autoformatting (global)" }
+M.n["<leader>uf"] = {
+  function() require("astrolsp.utils").toggle_buffer_autoformat() end,
+  desc = "Toggle autoformatting (buffer)",
+  cond = "textDocument/formatting",
+}
+M.n["<leader>uF"] = {
+  function() require("astrolsp.utils").toggle_autoformat() end,
+  desc = "Toggle autoformatting (global)",
+  cond = "textDocument/formatting",
+}
 
 M.n["K"] = { function() vim.lsp.buf.hover() end, desc = "Hover symbol details", cond = "textDocument/hover" }
 
@@ -58,7 +64,6 @@ M.n["gI"] = {
   cond = "textDocument/implementation",
 }
 
--- TODO: add proper conditions
 M.n["<leader>uH"] = {
   function()
     vim.b.inlay_hints_enabled = not vim.b.inlay_hints_enabled
@@ -69,6 +74,7 @@ M.n["<leader>uH"] = {
     end
   end,
   desc = "Toggle LSP inlay hints (buffer)",
+  cond = vim.lsp.inlay_hint and "textDocument/inlayHint" or false,
 }
 
 M.n["gr"] =
@@ -94,7 +100,7 @@ M.n["<leader>lG"] =
 M.n["<leader>uY"] = {
   function()
     vim.b.semantic_tokens_enabled = not vim.b.semantic_tokens_enabled
-    for _, client in ipairs(vim.lsp.get_active_clients()) do
+    for _, client in ipairs((vim.lsp.get_clients or vim.lsp.get_active_clients)()) do
       if client.server_capabilities.semanticTokensProvider then
         vim.lsp.semantic_tokens[vim.b.semantic_tokens_enabled and "start" or "stop"](0, client.id)
         vim.notify(("Buffer lsp semantic highlighting %s"):format(vim.b.semantic_tokens_enabled and "on" or "off"))
@@ -105,40 +111,27 @@ M.n["<leader>uY"] = {
   cond = "textDocument/semanticTokens/full",
 }
 
-if not vim.tbl_isempty(M.v) then M.v["<leader>l"] = { desc = " LSP" } end
+-- TODO: FIX this
+-- if not vim.tbl_isempty(M.v) then M.v["<leader>l"] = { desc = " LSP" } end
 
--- if is_available "telescope.nvim" then
---   lsp_mappings.n["<leader>lD"] =
---     { function() require("telescope.builtin").diagnostics() end, desc = "Search diagnostics" }
--- end
---
--- if is_available "mason-lspconfig.nvim" then
---   lsp_mappings.n["<leader>li"] = { "<cmd>LspInfo<cr>", desc = "LSP information" }
--- end
+if vim.fn.exists ":LspInfo" > 0 then M.n["<leader>li"] = { "<cmd>LspInfo<cr>", desc = "LSP information" } end
 --
--- if is_available "null-ls.nvim" then
---   lsp_mappings.n["<leader>lI"] = { "<cmd>NullLsInfo<cr>", desc = "Null-ls information" }
--- end
-
--- if is_available "telescope.nvim" then -- setup telescope mappings if available
---   if lsp_mappings.n.gd then lsp_mappings.n.gd[1] = function() require("telescope.builtin").lsp_definitions() end end
---   if lsp_mappings.n.gI then
---     lsp_mappings.n.gI[1] = function() require("telescope.builtin").lsp_implementations() end
---   end
---   if lsp_mappings.n.gr then lsp_mappings.n.gr[1] = function() require("telescope.builtin").lsp_references() end end
---   if lsp_mappings.n["<leader>lR"] then
---     lsp_mappings.n["<leader>lR"][1] = function() require("telescope.builtin").lsp_references() end
---   end
---   if lsp_mappings.n.gT then
---     lsp_mappings.n.gT[1] = function() require("telescope.builtin").lsp_type_definitions() end
---   end
---   if lsp_mappings.n["<leader>lG"] then
---     lsp_mappings.n["<leader>lG"][1] = function()
---       vim.ui.input({ prompt = "Symbol Query: " }, function(query)
---         if query then require("telescope.builtin").lsp_workspace_symbols { query = query } end
---       end)
---     end
---   end
--- end
+if vim.fn.exists ":NullLsInfo" > 0 then M.n["<leader>lI"] = { "<cmd>NullLsInfo<cr>", desc = "Null-ls information" } end
+
+if vim.fn.exists ":Telescope" > 0 or pcall(require, "telescope") then -- setup telescope mappings if available
+  M.n["<leader>lD"] = { function() require("telescope.builtin").diagnostics() end, desc = "Search diagnostics" }
+  if M.n.gd then M.n.gd[1] = function() require("telescope.builtin").lsp_definitions() end end
+  if M.n.gI then M.n.gI[1] = function() require("telescope.builtin").lsp_implementations() end end
+  if M.n.gr then M.n.gr[1] = function() require("telescope.builtin").lsp_references() end end
+  if M.n["<leader>lR"] then M.n["<leader>lR"][1] = function() require("telescope.builtin").lsp_references() end end
+  if M.n.gT then M.n.gT[1] = function() require("telescope.builtin").lsp_type_definitions() end end
+  if M.n["<leader>lG"] then
+    M.n["<leader>lG"][1] = function()
+      vim.ui.input({ prompt = "Symbol Query: " }, function(query)
+        if query then require("telescope.builtin").lsp_workspace_symbols { query = query } end
+      end)
+    end
+  end
+end
 
 return M