feat(plugins): support avante.nvim#139
Merged
mehalter merged 6 commits intoAstroNvim:mainfrom Aug 27, 2024
aarnphm:feat/avante.nvim
Merged
feat(plugins): support avante.nvim#139mehalter merged 6 commits intoAstroNvim:mainfrom aarnphm:feat/avante.nvim
mehalter merged 6 commits intoAstroNvim:mainfrom
aarnphm:feat/avante.nvim
Conversation
Signed-off-by: Aaron Pham <contact@aarnphm.xyz>
mehalter
requested changes
Aug 27, 2024
Member
mehalter
left a comment
mehalter
left a comment
There was a problem hiding this comment.
This looks great, thanks so much for the addition! Made one comment about the hardcoded values in the config, and the only other thing is to please update the README file with the new plugin and a link to it's repo!
Signed-off-by: Aaron Pham <contact@aarnphm.xyz>
Signed-off-by: Aaron Pham <contact@aarnphm.xyz>
Signed-off-by: Aaron Pham <contact@aarnphm.xyz>
mehalter
requested changes
Aug 27, 2024
Member
mehalter
left a comment
mehalter
left a comment
There was a problem hiding this comment.
Awesome, looks great. A couple other nitpicks and then it's good to go. I have also pushed to main the updates to the diff highlight groups so it should be good to go as well
Co-authored-by: Micah Halter <micah@mehalter.com>
Co-authored-by: Micah Halter <micah@mehalter.com>
mehalter
approved these changes
Aug 27, 2024
Member
mehalter
left a comment
mehalter
left a comment
There was a problem hiding this comment.
Awesome, thanks so much again for the contribution!
4 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Aaron Pham contact@aarnphm.xyz
📑 Description
Add support for yetone/avante.nvim colorscheme. I'm not entirely sure what to do with the diff color here, see yetone/avante.nvim#283.
The current color I have for diff is not in the palette. Would definitely need a second opinion here.