refactor!: require Neovim v0.10+

Author: mehalter

README.md

@@ -10,7 +10,7 @@ AstroUI provides a simple API for configuring and setting up the user interface
 
 ## ⚡️ Requirements
 
-- Neovim >= 0.9
+- Neovim >= 0.10
 - [astrocore][astrocore] (_optional_)
 
 ## 📦 Installation

lua/astroui/status/condition.lua

@@ -75,7 +75,7 @@ function M.is_hlsearch() return vim.v.hlsearch ~= 0 end
 --- A condition function if showcmdloc is set to statusline
 ---@return boolean # whether or not statusline showcmd is enabled
 -- @usage local heirline_component = { provider = "Example Provider", condition = require("astroui.status").condition.is_statusline_showcmd }
-function M.is_statusline_showcmd() return vim.fn.has "nvim-0.9" == 1 and vim.opt.showcmdloc:get() == "statusline" end
+function M.is_statusline_showcmd() return vim.opt.showcmdloc:get() == "statusline" end
 
 --- A condition function if the current file is in a git repo
 ---@param bufnr table|integer a buffer number to check the condition for, a table with bufnr property, or nil to get the current buffer
@@ -134,12 +134,7 @@ function M.has_diagnostics(bufnr)
   if type(bufnr) == "table" then bufnr = bufnr.bufnr end
   if not bufnr then bufnr = 0 end
   if package.loaded["astrocore"] and require("astrocore").config.features.diagnostics_mode == 0 then return false end
-  -- TODO: remove when dropping support for neovim 0.9
-  if vim.diagnostic.count then
-    return vim.tbl_contains(vim.diagnostic.count(bufnr), function(v) return v > 0 end, { predicate = true })
-  else
-    return #vim.diagnostic.get(bufnr) > 0
-  end
+  return vim.tbl_contains(vim.diagnostic.count(bufnr), function(v) return v > 0 end, { predicate = true })
 end
 
 --- A condition function if there is a defined filetype
@@ -182,11 +177,8 @@ function M.lsp_attached(bufnr)
   if type(bufnr) == "table" then bufnr = bufnr.bufnr end
   if not bufnr then bufnr = 0 end
   return (
-        -- HACK: Check for lsp utilities loaded first, get_active_clients seems to have a bug if called too early (tokyonight colorscheme seems to be a good way to expose this for some reason)
-package.loaded["astrolsp"]
-    -- TODO: remove get_active_clients when dropping support for Neovim 0.9
-    ---@diagnostic disable-next-line: deprecated
-    and next((vim.lsp.get_clients or vim.lsp.get_active_clients) { bufnr = bufnr }) ~= nil
+        -- HACK: Check for lsp utilities loaded first, get_clients seems to have a bug if called too early (tokyonight colorscheme seems to be a good way to expose this for some reason)
+package.loaded["astrolsp"] and next(vim.lsp.get_clients { bufnr = bufnr }) ~= nil
   )
     or (package.loaded["conform"] and next(require("conform").list_formatters(bufnr)) ~= nil)
     or (package.loaded["lint"] and next(require("lint")._resolve_linter_by_ft(vim.bo[bufnr].filetype or "")) ~= nil)

lua/astroui/status/init.lua

@@ -137,8 +137,7 @@ end
 ---@return function # The Heirline init function
 -- @usage local heirline_component = { init = require("astroui.status").init.update_events { "BufEnter", { "User", pattern = "LspProgressUpdate" } } }
 function M.update_events(opts)
-  -- TODO: remove check after dropping support for Neovim v0.9
-  if not (vim.islist or vim.tbl_islist)(opts) then opts = { opts } end
+  if not vim.islist(opts) then opts = { opts } end
   ---@cast opts AstroUIUpdateEvent[]
   return function(self)
     if not rawget(self, "once") then

lua/astroui/status/provider.lua

@@ -12,7 +12,6 @@ local M = {}
 local astro = require "astrocore"
 local extend_tbl = astro.extend_tbl
 local is_available = astro.is_available
-local luv = vim.uv or vim.loop -- TODO: REMOVE WHEN DROPPING SUPPORT FOR Neovim v0.9
 
 local ui = require "astroui"
 local config = assert(ui.config.status)
@@ -38,14 +37,6 @@ end
 -- local function to resolve the first sign in the signcolumn
 -- specifically for usage when `signcolumn=number`
 local function resolve_sign(bufnr, lnum)
-  --- TODO: remove when dropping support for Neovim v0.9
-  if vim.fn.has "nvim-0.10" == 0 then
-    for _, sign in ipairs(vim.fn.sign_getplaced(bufnr, { group = "*", lnum = lnum })[1].signs) do
-      local defined = vim.fn.sign_getdefined(sign.name)[1]
-      if defined then return defined end
-    end
-  end
-
   local row = lnum - 1
   local extmarks = vim.api.nvim_buf_get_extmarks(bufnr, -1, { row, 0 }, { row, -1 }, { details = true, type = "sign" })
   local ret
@@ -462,13 +453,7 @@ function M.diagnostics(opts)
   if not opts or not opts.severity then return end
   return function(self)
     local bufnr = self and self.bufnr or 0
-    local count
-    -- TODO: remove when dropping support for neovim 0.9
-    if vim.diagnostic.count then
-      count = vim.diagnostic.count(bufnr)[vim.diagnostic.severity[opts.severity]] or 0
-    else
-      count = #vim.diagnostic.get(bufnr, opts.severity and { severity = vim.diagnostic.severity[opts.severity] })
-    end
+    local count = vim.diagnostic.count(bufnr)[vim.diagnostic.severity[opts.severity]] or 0
     return status_utils.stylize(count ~= 0 and tostring(count) or "", opts)
   end
 end
@@ -486,7 +471,7 @@ function M.lsp_progress(opts)
     if astrolsp_avail and astrolsp.lsp_progress then
       _, status = next(astrolsp.lsp_progress)
     end
-    return status_utils.stylize(status and (spinner[math.floor(luv.hrtime() / 12e7) % #spinner + 1] .. table.concat({
+    return status_utils.stylize(status and (spinner[math.floor(vim.uv.hrtime() / 12e7) % #spinner + 1] .. table.concat({
       status.title or "",
       status.message or "",
       status.percentage and "(" .. status.percentage .. "%)" or "",
@@ -512,9 +497,7 @@ function M.lsp_client_names(opts)
   return function(self)
     local bufnr = self and self.bufnr or 0
     local buf_client_names = {}
-    -- TODO: remove get_active_clients when dropping support for Neovim 0.9
-    ---@diagnostic disable-next-line: deprecated
-    for _, client in pairs((vim.lsp.get_clients or vim.lsp.get_active_clients) { bufnr = bufnr }) do
+    for _, client in pairs(vim.lsp.get_clients { bufnr = bufnr }) do
       if client.name == "null-ls" and opts.integrations.null_ls then
         local null_ls_sources = {}
         local ft = vim.bo[bufnr].filetype

lua/astroui/status/utils.lua

@@ -255,13 +255,6 @@ function M.statuscolumn_clickargs(self, minwid, clicks, button, mods)
   if not self.signs then self.signs = {} end
   args.sign = self.signs[args.char]
   if not args.sign then -- update signs if not found on first click
-    ---TODO: remove when dropping support for Neovim v0.9
-    if vim.fn.has "nvim-0.10" == 0 then
-      for _, sign_def in ipairs(assert(vim.fn.sign_getdefined())) do
-        if sign_def.text then self.signs[sign_def.text:gsub("%s", "")] = sign_def end
-      end
-    end
-
     if not self.bufnr then self.bufnr = vim.api.nvim_get_current_buf() end
     local row = args.mousepos.line - 1
     for _, extmark in