Retain attributes ordering in the ndr registry#1552
Merged
sebastienblor merged 3 commits intoAutodesk:masterfrom Jun 6, 2023
Merged
Retain attributes ordering in the ndr registry#1552sebastienblor merged 3 commits intoAutodesk:masterfrom
sebastienblor merged 3 commits intoAutodesk:masterfrom
Conversation
cpichard
previously approved these changes
Jun 6, 2023
Collaborator
cpichard
left a comment
cpichard
left a comment
There was a problem hiding this comment.
looks good to me, a line in the changelog is missing though
sebastienblor
added a commit
that referenced
this pull request
Jun 13, 2023
sebastienblor
added a commit
that referenced
this pull request
Jun 13, 2023
* Update changelog for branch fix 7.2.2 (#1558) * Updating testsuite in fix-7.2.2 (#1560) * Update test references (#1539) (cherry picked from commit d13ebc7) * Add test for scene exported from maxUSD (#1537) (cherry picked from commit 042608f) * Bump threshold for test_0226 (#1540) (cherry picked from commit 37e1628) * Support UsdPrimvarReader_float2 correctly under a procedural (#1551) (#1561) * Retain attributes ordering in the ndr registry (#1552) (#1562) * read the arnold:driver value when it is a string (#1549) (#1564) Co-authored-by: cpichard <cpichard@users.noreply.github.com> * Fix changelog --------- Co-authored-by: cpichard <cpichard@users.noreply.github.com>
sebastienblor
added a commit
that referenced
this pull request
Jun 21, 2023
* Update changelog for branch fix 7.2.2 (#1558) * Updating testsuite in fix-7.2.2 (#1560) * Update test references (#1539) (cherry picked from commit d13ebc7) * Add test for scene exported from maxUSD (#1537) (cherry picked from commit 042608f) * Bump threshold for test_0226 (#1540) (cherry picked from commit 37e1628) * Support UsdPrimvarReader_float2 correctly under a procedural (#1551) (#1561) * Retain attributes ordering in the ndr registry (#1552) (#1562) * read the arnold:driver value when it is a string (#1549) (#1564) Co-authored-by: cpichard <cpichard@users.noreply.github.com> * Fix metallic attribute in UsdPreviewSurface in the render delegate (#1568) * Fix metallic attribute in UsdPreviewSurface in the render delegate #1567 * Add changelog * Fix relative paths on arnold nodes (#1559) (#1569) * Fix relative paths on arnold nodes #1546 * Add changelo (cherry picked from commit 32de9a1) * Moved the cached render log variables out of RenderParam, now they just have a global scope (#1573) Co-authored-by: Tom Minor <minort@ADSK.ads.autodesk.com> --------- Co-authored-by: cpichard <cpichard@users.noreply.github.com> Co-authored-by: Tom Minor <5022079+TomMinor@users.noreply.github.com> Co-authored-by: Tom Minor <minort@ADSK.ads.autodesk.com>
sebastienblor
added a commit
that referenced
this pull request
Jul 4, 2023
* Update changelog for branch fix 7.2.2 (#1558) * Updating testsuite in fix-7.2.2 (#1560) * Update test references (#1539) (cherry picked from commit d13ebc7) * Add test for scene exported from maxUSD (#1537) (cherry picked from commit 042608f) * Bump threshold for test_0226 (#1540) (cherry picked from commit 37e1628) * Support UsdPrimvarReader_float2 correctly under a procedural (#1551) (#1561) * Retain attributes ordering in the ndr registry (#1552) (#1562) * read the arnold:driver value when it is a string (#1549) (#1564) Co-authored-by: cpichard <cpichard@users.noreply.github.com> * Fix metallic attribute in UsdPreviewSurface in the render delegate (#1568) * Fix metallic attribute in UsdPreviewSurface in the render delegate #1567 * Add changelog * Fix relative paths on arnold nodes (#1559) (#1569) * Fix relative paths on arnold nodes #1546 * Add changelo (cherry picked from commit 32de9a1) * Moved the cached render log variables out of RenderParam, now they just have a global scope (#1573) Co-authored-by: Tom Minor <minort@ADSK.ads.autodesk.com> * Update changelog for 7.2.2.1 (#1581) --------- Co-authored-by: cpichard <cpichard@users.noreply.github.com> Co-authored-by: Tom Minor <5022079+TomMinor@users.noreply.github.com> Co-authored-by: Tom Minor <minort@ADSK.ads.autodesk.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes proposed in this pull request
The ndr registry was returning attributes in the alphabetic order, instead of keeping the attributes order defined in the arnold node entries.
This PR stores this ordering as a metadata for each node type, and then declares attributes in this same order.
We also skip attribute "name" which exists in all arnold nodes, but that doesn't make sense in USD where the name is not an attribute.