Support implicit conversions between Float3 and Float4 ARNOLD-14028#1748
Merged
sebastienblor merged 4 commits intoAutodesk:masterfrom Nov 20, 2023
Merged
Support implicit conversions between Float3 and Float4 ARNOLD-14028#1748sebastienblor merged 4 commits intoAutodesk:masterfrom
sebastienblor merged 4 commits intoAutodesk:masterfrom
Conversation
cpichard
reviewed
Nov 16, 2023
| }; | ||
|
|
||
| auto nodeSetRGBAFromVec3 = [](AtNode* node, const AtString paramName, const GfVec3f& v) { | ||
| AiNodeSetRGBA(node, paramName, v[0], v[1], v[2], 1.f); |
Collaborator
There was a problem hiding this comment.
are we sure we always want 1.f ?
Collaborator
There was a problem hiding this comment.
One test on linux is failing
Collaborator
Author
There was a problem hiding this comment.
this is what the implicit conversion in Arnold does when you convert color3 to color4, alpha is set to 1
cpichard
previously approved these changes
Nov 16, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds implicit conversions between RGB and RGBA values, so that using one type instead of the expected one still manages to read the data. Done in both the procedural and the render delegate.
Added test_14028 to exercise this.
I'm setting this PR as a draft as it's not clear yet whether we want to accept these use cases, or if we want to keep being restrictive about these data types.