Support render settings resolution with windowNDC#2440
Merged
sebastienblor merged 3 commits intomasterfrom Oct 10, 2025
Merged
Conversation
cpichard
previously approved these changes
Oct 9, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes proposed in this pull request
In the different use cases handled for render resolution and crop region, one was missing.
If the render resolution is explicitely set in the render settings AND a windowNDC is provided, then we don't want to change the resolution, and just set the render region accordingly.
Also, we were missing an update dependency between the driver and the options attributes, ensuring the driver update is called again when the options region changes.
Issues fixed in this pull request
Fixes HTOA-3009
Additional context
Add any other context or screenshots about the pull request here.