Skip to content

Commit 3b6300d

Browse files
committed
Comment fixes
1 parent ff42f02 commit 3b6300d

File tree

7 files changed

+8
-29
lines changed

7 files changed

+8
-29
lines changed

src/Bellatrix.Desktop/DesktopPluginsConfiguration.cs

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -150,6 +150,7 @@ public static void ConfigureLLM()
150150
{
151151
if (ConfigurationService.GetSection<LargeLanguageModelsSettings>() == null)
152152
{
153+
Logger.LogError("Could not load LargeLanguageModelsSettings section from testFrameworkSettings.json");
153154
return;
154155
}
155156

@@ -174,4 +175,4 @@ public static void ConfigureLLM()
174175
Logger.LogError(ex.ToString());
175176
}
176177
}
177-
}
178+
}

src/Bellatrix.Desktop/components/Window.cs

Lines changed: 0 additions & 21 deletions
Original file line numberDiff line numberDiff line change
@@ -85,25 +85,4 @@ public virtual void Attach()
8585

8686
Attached?.Invoke(this, new ComponentActionEventArgs(this));
8787
}
88-
89-
// public virtual void Detach()
90-
// {
91-
// Attaching?.Invoke(this, new ComponentActionEventArgs(this));
92-
//
93-
// var currentAppConfiguration = ServicesCollection.Current.Resolve<AppInitializationInfo>("_currentAppConfiguration");
94-
//
95-
// if (currentAppConfiguration.WindowHandle != WindowHandle)
96-
// {
97-
// throw new InvalidOperationException($"This window ({WindowHandle}) is not currently attached. Currently attached window: {currentAppConfiguration.WindowHandle}");
98-
// }
99-
//
100-
// currentAppConfiguration.WindowHandle = null;
101-
// var driver = WrappedWebDriverCreateService.Create(currentAppConfiguration, ServicesCollection.Current);
102-
//
103-
// WrappedDriver.Quit();
104-
// ServicesCollection.Current.UnregisterSingleInstance<WindowsDriver>();
105-
// ServicesCollection.Current.RegisterInstance(driver);
106-
//
107-
// Attached?.Invoke(this, new ComponentActionEventArgs(this));
108-
// }
10988
}

src/Bellatrix.Desktop/infrastructure/App.cs

Lines changed: 0 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -36,13 +36,8 @@ namespace Bellatrix.Desktop;
3636

3737
public class App : IDisposable
3838
{
39-
// TODO: Change to be ThreadLocal.
40-
private static bool _shouldStartLocalService;
41-
// private static Process _appiumProcess;
42-
4339
public App()
4440
{
45-
_shouldStartLocalService = ConfigurationService.GetSection<DesktopSettings>().ExecutionSettings.ShouldStartLocalService;
4641
ServicesCollection.Main.RegisterInstance<IViewSnapshotProvider>(AppService);
4742
}
4843
private static readonly bool ShouldStartLocalService = ConfigurationService.GetSection<DesktopSettings>().ExecutionSettings.ShouldStartLocalService;

src/Bellatrix.Mobile/AndroidPluginsConfiguration.cs

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -159,6 +159,7 @@ public static void ConfigureLLM()
159159
{
160160
if (ConfigurationService.GetSection<LargeLanguageModelsSettings>() == null)
161161
{
162+
Logger.LogError("Could not load LargeLanguageModelsSettings section from testFrameworkSettings.json");
162163
return;
163164
}
164165

@@ -183,4 +184,4 @@ public static void ConfigureLLM()
183184
Logger.LogError(ex.ToString());
184185
}
185186
}
186-
}
187+
}

src/Bellatrix.Mobile/IOSPluginsConfiguration.cs

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -155,6 +155,7 @@ public static void ConfigureLLM()
155155
{
156156
if (ConfigurationService.GetSection<LargeLanguageModelsSettings>() == null)
157157
{
158+
Logger.LogError("Could not load LargeLanguageModelsSettings section from testFrameworkSettings.json");
158159
return;
159160
}
160161

@@ -179,4 +180,4 @@ public static void ConfigureLLM()
179180
Logger.LogError(ex.ToString());
180181
}
181182
}
182-
}
183+
}

src/Bellatrix.Playwright/WebPluginsConfiguration.cs

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -237,6 +237,7 @@ public static void ConfigureLLM()
237237
{
238238
if (ConfigurationService.GetSection<LargeLanguageModelsSettings>() == null)
239239
{
240+
Logger.LogError("Could not load LargeLanguageModelsSettings section from testFrameworkSettings.json");
240241
return;
241242
}
242243

src/Bellatrix.Web/WebPluginsConfiguration.cs

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -234,6 +234,7 @@ public static void ConfigureLLM()
234234
{
235235
if (ConfigurationService.GetSection<LargeLanguageModelsSettings>() == null)
236236
{
237+
Logger.LogError("Could not load LargeLanguageModelsSettings section from testFrameworkSettings.json");
237238
return;
238239
}
239240

0 commit comments

Comments
 (0)