Added workaround for custom checkboxes and radio buttons

teo-nikolov · teo-nikolov · commit 4516f341f4eb · 2025-07-29T15:56:54.000+03:00
diff --git a/src/Bellatrix.Playwright/components/common/CheckBox.cs b/src/Bellatrix.Playwright/components/common/CheckBox.cs
@@ -35,7 +35,31 @@ public class CheckBox : Component, IComponentDisabled, IComponentChecked, ICompo
     /// <param name="options"></param>
     public virtual void Check(LocatorCheckOptions options = default)
     {
-        DefaultCheck(Checking, Checked, options);
+        var tempOptions = options ?? new LocatorCheckOptions();
+        tempOptions.Timeout = 1;
+
+        Checking?.Invoke(this, new ComponentActionEventArgs(this));
+
+        try
+        {
+            DefaultCheck(null, null, tempOptions);
+        }
+        catch
+        {
+            // Fallback to JsClick, checkbox may be custom element with hidden input
+
+            if (!IsChecked)
+            {
+                var clickOptions = new LocatorClickOptions
+                {
+                    Force = true,
+                    Timeout = options?.Timeout,
+                };
+                DefaultClick(null, null, clickOptions);
+            }
+        }
+
+        Checked?.Invoke(this, new ComponentActionEventArgs(this));
     }
 
     /// <summary>
@@ -44,7 +68,32 @@ public virtual void Check(LocatorCheckOptions options = default)
     /// <param name="options"></param>
     public virtual void Uncheck(LocatorUncheckOptions options = default)
     {
-        DefaultUncheck(Unchecking, Unchecked, options);
+        var tempOptions = options ?? new LocatorUncheckOptions();
+        tempOptions.Timeout = 1;
+
+        Unchecking?.Invoke(this, new ComponentActionEventArgs(this));
+
+        try
+        {
+            DefaultUncheck(null, null, tempOptions);
+        }
+        catch
+        {
+            // Fallback to JsClick, checkbox may be custom element with hidden input
+
+            if (IsChecked)
+            {
+                var clickOptions = new LocatorClickOptions
+                {
+                    Force = true,
+                    Timeout = options?.Timeout,
+                };
+                DefaultClick(null, null, clickOptions);
+            }
+
+        }
+
+        Unchecked?.Invoke(this, new ComponentActionEventArgs(this));
     }
 
     public virtual void Hover()
diff --git a/src/Bellatrix.Playwright/components/common/RadioButton.cs b/src/Bellatrix.Playwright/components/common/RadioButton.cs
@@ -47,6 +47,27 @@ public virtual void Hover()
     /// <param name="options"></param>
     public virtual void Click(LocatorCheckOptions options = default)
     {
-        DefaultCheck(Clicking, Clicked, options);
+        var tempOptions = options ?? new LocatorCheckOptions();
+        tempOptions.Timeout = 1;
+
+        Clicking?.Invoke(this, new ComponentActionEventArgs(this));
+
+        try
+        {
+            DefaultCheck(null, null, tempOptions);
+        }
+        catch
+        {
+            // Fallback to JsClick, radio button may be custom element with hidden input
+            var clickOptions = new LocatorClickOptions
+            {
+                Force = true,
+                Timeout = options?.Timeout,
+            };
+
+            DefaultClick(null, null, clickOptions);
+        }
+
+        Clicked?.Invoke(this, new ComponentActionEventArgs(this));
     }
 }
diff --git a/src/Bellatrix.Playwright/components/core/Component.DefaultActions.cs b/src/Bellatrix.Playwright/components/core/Component.DefaultActions.cs
@@ -50,7 +50,7 @@ internal void DefaultClick(EventHandler<ComponentActionEventArgs> clicking, Even
             if (options.Force != null && (bool)options.Force) PerformJsClick();
             else WrappedElement.Click(options);
         }
-        
+
         else WrappedElement.Click();
 
         clicked?.Invoke(this, new ComponentActionEventArgs(this));
@@ -73,7 +73,6 @@ internal void DefaultUncheck(EventHandler<ComponentActionEventArgs> unchecking,
 
         WrappedElement.Uncheck(options);
 
-
         @unchecked?.Invoke(this, new ComponentActionEventArgs(this));
     }
 
diff --git a/src/Bellatrix.Playwright/components/core/Component.cs b/src/Bellatrix.Playwright/components/core/Component.cs
@@ -321,7 +321,7 @@ public bool IsPresent
         {
             try
             {
-                return WrappedElement.ElementHandle(new LocatorElementHandleOptions { Timeout = ConfigurationService.GetSection<WebSettings>().TimeoutSettings.InMilliseconds().ElementToExistTimeout }) != null;
+                return WrappedElement.IsPresent;
             }
             catch
             {
diff --git a/src/Bellatrix.Playwright/components/eventhandlers/RadioButtonEventHandlers.cs b/src/Bellatrix.Playwright/components/eventhandlers/RadioButtonEventHandlers.cs
@@ -33,4 +33,4 @@ public override void UnsubscribeToAll()
         RadioButton.Hovering -= HoveringEventHandler;
         RadioButton.Hovered -= HoveredEventHandler;
     }
-}
+}
diff --git a/src/Bellatrix.Playwright/llm/FindByPrompt.cs b/src/Bellatrix.Playwright/llm/FindByPrompt.cs
@@ -17,10 +17,7 @@
 using Bellatrix.LLM;
 using Bellatrix.LLM.Plugins;
 using Bellatrix.Playwright.LLM.Plugins;
-using Bellatrix.Playwright.Locators;
-using Microsoft.Identity.Client;
 using Microsoft.SemanticKernel;
-using Pipelines.Sockets.Unofficial.Arenas;
 using System.Text.RegularExpressions;
 using System.Threading;
 
@@ -59,7 +56,7 @@ private FindStrategy TryResolveLocator(string location, IViewSnapshotProvider sn
         if (_tryResolveFromPages)
         {
             var ragLocator = TryResolveFromPageObjectMemory(Value);
-            if (ragLocator != null && ragLocator.Resolve(WrappedBrowser.CurrentPage).All().Any())
+            if (ragLocator != null && ragLocator.Resolve(WrappedBrowser.CurrentPage).IsPresent)
             {
                 Logger.LogInformation($"✅ Using RAG-located element '{ragLocator}' For '${Value}'");
                 return ragLocator;
@@ -71,7 +68,7 @@ private FindStrategy TryResolveLocator(string location, IViewSnapshotProvider sn
         var cached = LocatorCacheService.TryGetCached(WrappedBrowser.CurrentPage.Url, Value);
 
         var strategy = new FindXpathStrategy(cached);
-        if (!string.IsNullOrEmpty(cached) && strategy.Resolve(WrappedBrowser.CurrentPage).All().Any())
+        if (!string.IsNullOrEmpty(cached) && strategy.Resolve(WrappedBrowser.CurrentPage).IsPresent)
         {
             Logger.LogInformation("✅ Using cached selector.");
             return strategy;
@@ -145,7 +142,7 @@ private FindStrategy ResolveViaPromptFallback(string location, IViewSnapshotProv
             var rawSelector = result?.GetValue<string>()?.Trim();
 
             var strategy = new FindXpathStrategy(rawSelector);
-            if (!string.IsNullOrWhiteSpace(rawSelector) && strategy.Resolve(WrappedBrowser.CurrentPage).All().Any())
+            if (!string.IsNullOrWhiteSpace(rawSelector) && strategy.Resolve(WrappedBrowser.CurrentPage).IsPresent)
             {
                 LocatorCacheService.Update(location, Value, strategy.Value);
                 return strategy;
diff --git a/templates/Bellatrix.Playwright.GettingStarted/testFrameworkSettings.Debug.json b/templates/Bellatrix.Playwright.GettingStarted/testFrameworkSettings.Debug.json
@@ -10,7 +10,7 @@
     "waitUntilReadyOnElementFound": "false",
     "waitForAngular": "false",
     "shouldHighlightElements": "true",
-    "shouldCaptureHttpTraffic": "true",
+    "shouldCaptureHttpTraffic": "false",
     "pathToSslCertificate": "path",
     "shouldCheckForJavaScriptErrors": "false",
     "timeoutSettings": {
@@ -238,13 +238,13 @@
       }
     ],
     "qdrantMemoryDbEndpoint": "http://localhost:6333",
-    "localCacheConnectionString": "env_LocalCacheConnectionString",
+    "localCacheConnectionString": "Host=localhost;Port=5433;Database=LocatorCacheDb;Username=postgres;Password=devpassword",
     "localCacheProjectName": "playwright_getting_started",
     "shouldIndexPageObjects": false,
     "pageObjectFilesPath": "40. Prompts Support\\Pages",
     "memoryIndex": "PageObjects",
     "resetIndexEverytime": false,
-    "locatorRetryAttempts": 3,
+    "locatorRetryAttempts": 5,
     "validationsTimeout": 15,
     "sleepInterval": 1,
     "enableSelfHealing": true,
diff --git a/templates/Bellatrix.Web.GettingStarted/testFrameworkSettings.Debug.json b/templates/Bellatrix.Web.GettingStarted/testFrameworkSettings.Debug.json
@@ -15,22 +15,22 @@
     "shouldCheckForJavaScriptErrors": "false",
     "fullPageScreenshotsEnabled": "true",
     "timeoutSettings": {
-      "elementWaitTimeout": "5",
-      "pageLoadTimeout": "5",
-      "scriptTimeout": "1",
-      "waitForAjaxTimeout": "5",
+      "elementWaitTimeout": "10",
+      "pageLoadTimeout": "10",
+      "scriptTimeout": "5",
+      "waitForAjaxTimeout": "10",
       "sleepInterval": "1",
-      "waitUntilReadyTimeout": "5",
-      "waitForJavaScriptAnimationsTimeout": "5",
-      "waitForAngularTimeout": "5",
-      "waitForPartialUrl": "5",
-      "validationsTimeout": "5",
-      "elementToBeVisibleTimeout": "5",
-      "elementToExistTimeout": "5",
-      "elementToNotExistTimeout": "5",
-      "elementToBeClickableTimeout": "5",
-      "elementNotToBeVisibleTimeout": "5",
-      "elementToHaveContentTimeout": "5"
+      "waitUntilReadyTimeout": "10",
+      "waitForJavaScriptAnimationsTimeout": "10",
+      "waitForAngularTimeout": "10",
+      "waitForPartialUrl": "10",
+      "validationsTimeout": "10",
+      "elementToBeVisibleTimeout": "10",
+      "elementToExistTimeout": "10",
+      "elementToNotExistTimeout": "10",
+      "elementToBeClickableTimeout": "10",
+      "elementNotToBeVisibleTimeout": "10",
+      "elementToHaveContentTimeout": "10"
     },
     "executionSettings": {
       "executionType": "regular",
@@ -220,7 +220,7 @@
     "modelSettings": [
       {
         "endpoint": "env_AZURE_OPENAI_ENDPOINT",
-        "key": "env_AZURE_OPENAI_KEY",
+        "key": "env_AZURE_OPENAI_API_KEY",
         "deployment": "gpt-4o"
       },
       {
@@ -231,7 +231,7 @@
       }
     ],
     "qdrantMemoryDbEndpoint": "http://localhost:6333",
-    "localCacheConnectionString": "env_LocalCacheConnectionString",
+    "localCacheConnectionString": "Host=localhost;Port=5433;Database=LocatorCacheDb;Username=postgres;Password=devpassword",
     "localCacheProjectName": "web_getting_started",
     "shouldIndexPageObjects": false,
     "pageObjectFilesPath": "40. Prompts Support\\Pages",

Original file line number	Diff line number	Diff line change
`@@ -50,7 +50,7 @@ internal void DefaultClick(EventHandler<ComponentActionEventArgs> clicking, Even`
`50`	`50`	`if (options.Force != null && (bool)options.Force) PerformJsClick();`
`51`	`51`	`else WrappedElement.Click(options);`
`52`	`52`	`}`
`53`		`-`
	`53`	`+`
`54`	`54`	`else WrappedElement.Click();`
`55`	`55`
`56`	`56`	`clicked?.Invoke(this, new ComponentActionEventArgs(this));`
`@@ -73,7 +73,6 @@ internal void DefaultUncheck(EventHandler<ComponentActionEventArgs> unchecking,`
`73`	`73`
`74`	`74`	`WrappedElement.Uncheck(options);`
`75`	`75`
`76`		`-`
`77`	`76`	`@unchecked?.Invoke(this, new ComponentActionEventArgs(this));`
`78`	`77`	`}`
`79`	`78`
Original file line number	Diff line number	Diff line change
`@@ -321,7 +321,7 @@ public bool IsPresent`
`321`	`321`	`{`
`322`	`322`	`try`
`323`	`323`	`{`
`324`		`- return WrappedElement.ElementHandle(new LocatorElementHandleOptions { Timeout = ConfigurationService.GetSection<WebSettings>().TimeoutSettings.InMilliseconds().ElementToExistTimeout }) != null;`
	`324`	`+ return WrappedElement.IsPresent;`
`325`	`325`	`}`
`326`	`326`	`catch`
`327`	`327`	`{`
Original file line number	Diff line number	Diff line change
`@@ -33,4 +33,4 @@ public override void UnsubscribeToAll()`
`33`	`33`	`RadioButton.Hovering -= HoveringEventHandler;`
`34`	`34`	`RadioButton.Hovered -= HoveredEventHandler;`
`35`	`35`	`}`
`36`		`-}`
	`36`	`+}`