fix: set shouldCloseApp's default value to true (#18)

teo-nikolov · web-flow · commit 28dc1d443d41 · 2025-04-25T14:45:39.000+03:00
diff --git a/lib/driver.ts b/lib/driver.ts
@@ -172,6 +172,9 @@ export class NovaWindowsDriver extends BaseDriver<NovaWindowsDriverConstraints,
             if (caps.app && caps.appTopLevelWindow) {
                 throw new errors.InvalidArgumentError('Invalid capabilities. Specify either app or appTopLevelWindow.');
             }
+            if (this.caps.shouldCloseApp === undefined) {
+                this.caps.shouldCloseApp = true; // set default value
+            }
 
             await this.startPowerShellSession();
 

Original file line number	Diff line number	Diff line change
`@@ -172,6 +172,9 @@ export class NovaWindowsDriver extends BaseDriver<NovaWindowsDriverConstraints,`
`172`	`172`	`if (caps.app && caps.appTopLevelWindow) {`
`173`	`173`	`throw new errors.InvalidArgumentError('Invalid capabilities. Specify either app or appTopLevelWindow.');`
`174`	`174`	`}`
	`175`	`+ if (this.caps.shouldCloseApp === undefined) {`
	`176`	`+ this.caps.shouldCloseApp = true; // set default value`
	`177`	`+ }`
`175`	`178`
`176`	`179`	`await this.startPowerShellSession();`
`177`	`180`