fix(lint): lint

Author: yuri-schwab

lib/commands/extension.ts

@@ -5,7 +5,7 @@ import { join, normalize } from 'node:path';
 import { W3C_ELEMENT_KEY, errors } from '@appium/base-driver';
 import { Element, Rect } from '@appium/types';
 import { NovaWindowsDriver } from '../driver';
-import { $, sleep } from '../util';
+import { $, getBundledFfmpegPath, sleep } from '../util';
 import { POWER_SHELL_FEATURE } from '../constants';
 import { keyDown,
     keyUp,
@@ -30,7 +30,6 @@ import {
     pwsh
 } from '../powershell';
 import { ClickType, Enum, Key } from '../enums';
-import { getBundledFfmpegPath } from '../util';
 
 const PLATFORM_COMMAND_PREFIX = 'windows:';
 
@@ -827,7 +826,7 @@ export async function deleteFile(this: NovaWindowsDriver, args: { path: string }
         throw new errors.InvalidArgumentError("'path' must be provided.");
     }
     const escapedPath = args.path.replace(/'/g, "''");
-    const useLiteralPath = /[\[\]?]/.test(args.path);
+    const useLiteralPath = /[[\][]?]/.test(args.path);
     const pathParam = useLiteralPath ? `-LiteralPath '${escapedPath}'` : `-Path '${escapedPath}'`;
     await this.sendPowerShellCommand(`Remove-Item ${pathParam} -Force -ErrorAction Stop`);
 }
@@ -838,7 +837,7 @@ export async function deleteFolder(this: NovaWindowsDriver, args: { path: string
     }
     const { path: pathArg, recursive = true } = args;
     const escapedPath = pathArg.replace(/'/g, "''");
-    const useLiteralPath = /[\[\]?]/.test(pathArg);
+    const useLiteralPath = /[[\][]?]/.test(pathArg);
     const pathParam = useLiteralPath ? `-LiteralPath '${escapedPath}'` : `-Path '${escapedPath}'`;
     const recurseFlag = recursive ? ' -Recurse' : '';
     await this.sendPowerShellCommand(`Remove-Item ${pathParam} -Force${recurseFlag} -ErrorAction Stop`);

lib/util.ts

@@ -6,7 +6,6 @@ import { errors } from '@appium/base-driver';
  */
 export function getBundledFfmpegPath(): string | null {
     try {
-        // eslint-disable-next-line @typescript-eslint/no-require-imports
         const mod = require('ffmpeg-static') as string | { default?: string } | undefined;
         const path = typeof mod === 'string' ? mod : mod?.default;
         return typeof path === 'string' && path.length > 0 ? path : null;

test/commands/extension/deleteFile.test.ts

@@ -25,29 +25,29 @@ describe('deleteFile', () => {
         const driver = createMockDriver();
         await deleteFile.call(driver, { path: 'C:\\temp\\file.txt' });
         expect(driver.sendPowerShellCommand).toHaveBeenCalledWith(
-            expect.stringContaining("Remove-Item")
+            expect.stringContaining('Remove-Item')
         );
         expect(driver.sendPowerShellCommand).toHaveBeenCalledWith(
-            expect.stringContaining("-Path 'C:\\temp\\file.txt'")
+            expect.stringContaining('-Path \'C:\\temp\\file.txt\'')
         );
         expect(driver.sendPowerShellCommand).toHaveBeenCalledWith(
-            expect.stringContaining("-Force")
+            expect.stringContaining('-Force')
         );
     });
 
     it('uses -LiteralPath when path contains brackets', async () => {
         const driver = createMockDriver();
         await deleteFile.call(driver, { path: 'C:\\temp\\file[1].txt' });
         expect(driver.sendPowerShellCommand).toHaveBeenCalledWith(
-            expect.stringContaining("-LiteralPath")
+            expect.stringContaining('-LiteralPath')
         );
     });
 
     it('escapes single quotes in path', async () => {
         const driver = createMockDriver();
         await deleteFile.call(driver, { path: "C:\\temp\\file's.txt" });
         expect(driver.sendPowerShellCommand).toHaveBeenCalledWith(
-            expect.stringContaining("file''s.txt")
+            expect.stringContaining('file\'\'s.txt')
         );
     });
 });

test/commands/extension/deleteFolder.test.ts

@@ -22,7 +22,7 @@ describe('deleteFolder', () => {
         const driver = createMockDriver();
         await deleteFolder.call(driver, { path: 'C:\\temp\\folder' });
         expect(driver.sendPowerShellCommand).toHaveBeenCalledWith(
-            expect.stringContaining("-Recurse")
+            expect.stringContaining('-Recurse')
         );
     });
 
@@ -37,7 +37,7 @@ describe('deleteFolder', () => {
         const driver = createMockDriver();
         await deleteFolder.call(driver, { path: 'C:\\temp\\folder[1]' });
         expect(driver.sendPowerShellCommand).toHaveBeenCalledWith(
-            expect.stringContaining("-LiteralPath")
+            expect.stringContaining('-LiteralPath')
         );
     });
 });

test/commands/extension/execute.test.ts

@@ -3,8 +3,7 @@
  */
 import { describe, it, expect, vi, beforeEach } from 'vitest';
 import * as extension from '../../../lib/commands/extension';
-import { createMockDriver } from '../../fixtures/driver';
-import { MOCK_ELEMENT } from '../../fixtures/driver';
+import { createMockDriver, MOCK_ELEMENT } from '../../fixtures/driver';
 
 describe('execute (command router)', () => {
     let driver: ReturnType<typeof createMockDriver> & Record<string, any>;
@@ -30,7 +29,7 @@ describe('execute (command router)', () => {
     it('routes windows:deleteFile to deleteFile with args', async () => {
         await extension.execute.call(driver, 'windows: deleteFile', [{ path: 'C:\\temp\\file.txt' }]);
         expect(driver.sendPowerShellCommand).toHaveBeenCalledWith(
-            expect.stringContaining("Remove-Item")
+            expect.stringContaining('Remove-Item')
         );
     });
 

test/commands/extension/input.test.ts

@@ -85,8 +85,12 @@ describe('executeClick', () => {
         let callCount = 0;
         driver.sendPowerShellCommand.mockImplementation(() => {
             callCount++;
-            if (callCount === 1) return Promise.resolve('True');
-            if (callCount === 2) return Promise.resolve('1.2.3.4.5');
+            if (callCount === 1) {
+                return Promise.resolve('True');
+            }
+            if (callCount === 2) {
+                return Promise.resolve('1.2.3.4.5');
+            }
             return Promise.resolve(rectJson);
         });
         const { mouseMoveAbsolute } = await import('../../../lib/winapi/user32');

test/commands/extension/pattern.test.ts

@@ -23,8 +23,7 @@ import {
     focusElement,
 } from '../../../lib/commands/extension';
 import { W3C_ELEMENT_KEY } from '@appium/base-driver';
-import { createMockDriver } from '../../fixtures/driver';
-import { MOCK_ELEMENT } from '../../fixtures/driver';
+import { createMockDriver, MOCK_ELEMENT } from '../../fixtures/driver';
 
 const PATTERN_COMMANDS = [
     { name: 'patternInvoke', fn: patternInvoke, expectInCommand: 'InvokePattern' },

test/commands/extension/stopRecordingScreen.test.ts

@@ -35,7 +35,9 @@ describe('stopRecordingScreen', () => {
         driver.recordingProcess = {
             stdin: mockStdin,
             on: vi.fn((event: string, cb: () => void) => {
-                if (event === 'exit') setTimeout(cb, 0);
+                if (event === 'exit') {
+                    setTimeout(cb, 0);
+                }
             }),
         };
         driver.recordingOutputPath = 'C:\\temp\\rec.mp4';
@@ -54,7 +56,9 @@ describe('stopRecordingScreen', () => {
         driver.recordingProcess = {
             stdin: mockStdin,
             on: vi.fn((event: string, cb: () => void) => {
-                if (event === 'exit') setTimeout(cb, 0);
+                if (event === 'exit') {
+                    setTimeout(cb, 0);
+                }
             }),
         };
         driver.recordingOutputPath = 'C:\\temp\\rec.mp4';
@@ -70,7 +74,9 @@ describe('stopRecordingScreen', () => {
         driver.recordingProcess = {
             stdin: { write: vi.fn() },
             on: vi.fn((event: string, cb: () => void) => {
-                if (event === 'exit') setTimeout(cb, 0);
+                if (event === 'exit') {
+                    setTimeout(cb, 0);
+                }
             }),
         };
         driver.recordingOutputPath = 'C:\\temp\\rec.mp4';