Skip to content

Commit e6c3bdc

Browse files
authored
{SQL} fix az sql server ad-admin update , az sql server ad-admin create calls (#12541)
* Fixing az sql server ad-admin update and az sql server ad-admin create. Adding test recording too. * update the comments * Revert update changes and fix it to have generic parameters. re-record test * change aad create from properties to parameters * remove spaces. * Removing comment for issue #6011 as tests are recorded now. * Fixing styling issues Co-authored-by: Amol Agarwal <amagarwa@microsoft.com>
1 parent 74d9ee5 commit e6c3bdc

5 files changed

Lines changed: 973 additions & 34 deletions

File tree

src/azure-cli/azure/cli/command_modules/sql/_params.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1100,7 +1100,7 @@ def _configure_security_policy_storage_params(arg_ctx):
11001100
with self.argument_context('sql server ad-admin create') as c:
11011101
# Create args that will be used to build up the ServerAzureADAdministrator object
11021102
create_args_for_complex_type(
1103-
c, 'properties', ServerAzureADAdministrator, [
1103+
c, 'parameters', ServerAzureADAdministrator, [
11041104
'login',
11051105
'sid',
11061106
])

src/azure-cli/azure/cli/command_modules/sql/commands.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -420,7 +420,7 @@ def load_command_table(self, _):
420420
g.command('delete', 'delete')
421421
g.generic_update_command('update',
422422
custom_func_name='server_ad_admin_update',
423-
setter_arg_name='properties')
423+
setter_arg_name='parameters')
424424

425425
server_keys_operations = CliCommandType(
426426
operations_tmpl='azure.mgmt.sql.operations#ServerKeysOperations.{}',

src/azure-cli/azure/cli/command_modules/sql/custom.py

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -2071,7 +2071,7 @@ def server_ad_admin_set(
20712071
return client.create_or_update(
20722072
server_name=server_name,
20732073
resource_group_name=resource_group_name,
2074-
properties=kwargs)
2074+
parameters=kwargs)
20752075

20762076

20772077
def server_ad_admin_update(
@@ -2090,7 +2090,6 @@ def server_ad_admin_update(
20902090

20912091
return instance
20922092

2093-
20942093
#####
20952094
# sql server firewall-rule
20962095
#####

0 commit comments

Comments
 (0)