Skip to content

Commit 0ff2b53

Browse files
mikeharderhaagha
authored andcommitted
[Contoso.Management] Use ArmResourcePatchSync instead of ArmCustomPatchSync (#31279)
- Recommended to use ArmResourcePatchSync when possible
1 parent 5f597e5 commit 0ff2b53

3 files changed

Lines changed: 26 additions & 37 deletions

File tree

specification/contosowidgetmanager/Contoso.Management/employee.tsp

Lines changed: 1 addition & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -56,13 +56,7 @@ union ProvisioningState {
5656
interface Employees {
5757
get is ArmResourceRead<Employee>;
5858
createOrUpdate is ArmResourceCreateOrReplaceAsync<Employee>;
59-
update is ArmCustomPatchSync<
60-
Employee,
61-
Azure.ResourceManager.Foundations.ResourceUpdateModel<
62-
Employee,
63-
EmployeeProperties
64-
>
65-
>;
59+
update is ArmResourcePatchSync<Employee, EmployeeProperties>;
6660
delete is ArmResourceDeleteWithoutOkAsync<Employee>;
6761
listByResourceGroup is ArmResourceListByParent<Employee>;
6862
listBySubscription is ArmListBySubscription<Employee>;

specification/contosowidgetmanager/Contoso.Management/tspconfig.yaml

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -9,7 +9,6 @@ options:
99
emitter-output-dir: "{project-root}/.."
1010
azure-resource-provider-folder: "resource-manager"
1111
output-file: "{azure-resource-provider-folder}/{service-name}/{version-status}/{version}/contoso.json"
12-
emit-common-types-schema: "never"
1312
"@azure-tools/typespec-csharp":
1413
flavor: azure
1514
package-dir: "Azure.ResourceManager.Contoso"

specification/contosowidgetmanager/resource-manager/Microsoft.Contoso/preview/2021-10-01-preview/contoso.json

Lines changed: 25 additions & 29 deletions
Original file line numberDiff line numberDiff line change
@@ -402,6 +402,24 @@
402402
}
403403
},
404404
"definitions": {
405+
"Azure.ResourceManager.CommonTypes.TrackedResourceUpdate": {
406+
"type": "object",
407+
"description": "The resource model definition for an Azure Resource Manager tracked top level resource which has 'tags' and a 'location'",
408+
"properties": {
409+
"tags": {
410+
"type": "object",
411+
"description": "Resource tags.",
412+
"additionalProperties": {
413+
"type": "string"
414+
}
415+
}
416+
},
417+
"allOf": [
418+
{
419+
"$ref": "../../../../../common-types/resource-management/v5/types.json#/definitions/Resource"
420+
}
421+
]
422+
},
405423
"Employee": {
406424
"type": "object",
407425
"description": "Employee resource",
@@ -465,40 +483,18 @@
465483
},
466484
"EmployeeUpdate": {
467485
"type": "object",
468-
"description": "The type used for update operations of the Employee.",
486+
"description": "Employee resource",
469487
"properties": {
470-
"tags": {
471-
"type": "object",
472-
"description": "Resource tags.",
473-
"additionalProperties": {
474-
"type": "string"
475-
}
476-
},
477488
"properties": {
478-
"$ref": "#/definitions/EmployeeUpdateProperties",
489+
"$ref": "#/definitions/EmployeeProperties",
479490
"description": "The resource-specific properties for this resource."
480491
}
481-
}
482-
},
483-
"EmployeeUpdateProperties": {
484-
"type": "object",
485-
"description": "The updatable properties of the Employee.",
486-
"properties": {
487-
"age": {
488-
"type": "integer",
489-
"format": "int32",
490-
"description": "Age of employee"
491-
},
492-
"city": {
493-
"type": "string",
494-
"description": "City of employee"
495-
},
496-
"profile": {
497-
"type": "string",
498-
"format": "base64url",
499-
"description": "Profile of employee"
492+
},
493+
"allOf": [
494+
{
495+
"$ref": "#/definitions/Azure.ResourceManager.CommonTypes.TrackedResourceUpdate"
500496
}
501-
}
497+
]
502498
},
503499
"ProvisioningState": {
504500
"type": "string",

0 commit comments

Comments
 (0)