Merge branch 'main' into feature/storage/stg94base

Author: seanmcc-msft

.devcontainer/Dockerfile

@@ -1,12 +1,18 @@
 {
   "name": "TypeSpec Dev Container",
-  "build": {
-    "dockerfile": "Dockerfile"
-  },
-  "remoteUser": "root"
-  /*,
-  update below source folder to your local sdk-repos folder
-  "mounts": [
-    "source=/home/rc/repos/tmp/sdk-repos,target=/workspaces/sdk-repos,type=bind,consistency=cached"
-  ]*/
-}
+  "image": "mcr.microsoft.com/devcontainers/typescript-node:dev-20",
+  // Default is 2 cores which is too slow for this codebase
+  "hostRequirements": {"cpus": 4},
+  "postCreateCommand": "npm ci",
+  "customizations": {
+    "vscode": {
+      // Keep in sync with .vscode/extensions.json
+      "extensions": [
+        "EditorConfig.EditorConfig",
+        "esbenp.prettier-vscode",
+        "typespec.typespec-vscode",
+        "docsmsft.docs-authoring-pack"
+      ]
+    }
+  }
+}

.devcontainer/devcontainer.json

@@ -3,45 +3,18 @@
 > [!TIP]
 > Overwhelmed by all this guidance? See the `Getting help` section at the bottom of this PR description.
 
-> [!NOTE]
-> As of January 2024 there is no PR assignee. This is expected. See https://aka.ms/azsdk/pr-arm-review.
-
 ## PR review workflow diagram
 
 Please understand this diagram before proceeding. It explains how to get your PR approved & merged.
 
-![diagram](https://github.com/Azure/azure-rest-api-specs/assets/4429827/f5cdc159-40bd-42a5-8a1c-1e398a1d80fd)
-
-<details>
-<summary>Click here to see the details of Step 1, Breaking Changes review</summary>
-
-If you are in purview of Step 1 of the diagram, follow the [Breaking Changes review process].  
-**IMPORTANT!** This applies even if you believe your PR was mislabeled, for any reason, including tool failure.
-</details>
-
-<details> 
-<summary>Click here to see the details of Step 2, ARM review</summary>
-
-See https://aka.ms/azsdk/pr-arm-review.
-</details>
-
-<details>
-<summary> Click here to see the diagram footnotes</summary>
-
-### Diagram footnotes
-
-[1] See [ARM review queue] (for **PR merge** queues, see [2]).  
-[2] [public repo merge queue], [private repo merge queue] (for **ARM review** queue, [1])  
-The ARM reviewer on-call engineer visits the merge queue twice a day, so the approximate ETA for merges is 12 - 24 hours.
-
-</details>
+![spec_pr_review_workflow_diagram](https://github.com/Azure/azure-rest-api-specs/assets/4429827/5bb5e7ce-8aff-4dbb-a3f8-0d9b68fef5b1)
 
 ## Purpose of this PR
 
 What's the purpose of this PR? Check the specific option that applies. This is **mandatory**!
 
   - [ ] New resource provider.
-  - [ ] New API version for an existing resource provider. (If API spec is not defined in TypeSpec, the PR should have been generated using [OpenAPI Hub](https://aka.ms/openapihub)).
+  - [ ] New API version for an existing resource provider. (If API spec is not defined in TypeSpec, the PR should have been created in adherence to [OpenAPI specs PR creation guidance](https://aka.ms/azsdkdocs/createopenapispec)).
   - [ ] Update existing version for a new feature. (This is applicable only when you are revising a private preview API version.)
   - [ ] Update existing version to fix OpenAPI spec quality issues in S360.
   - [ ] Other, please clarify:
@@ -54,7 +27,7 @@ and followed the instructions by checking all the boxes:
 
 - [ ] I confirm this PR is modifying Azure Resource Manager (ARM) related specifications, and not data plane related specifications.
 - [ ] I have reviewed following [Resource Provider guidelines](https://aka.ms/rpguidelines), including
-  [ARM resource provider contract](https://github.com/Azure/azure-resource-manager-rpc) and
+  [ARM resource provider contract](https://aka.ms/azurerpc) and
   [REST guidelines](https://github.com/microsoft/api-guidelines/blob/vNext/azure/Guidelines.md) (estimated time: 4 hours).  
   I understand this is required before I can proceed to the diagram Step 2, "ARM API changes review", for this PR.
 
@@ -78,15 +51,11 @@ If one or multiple validation error/warning suppression(s) is detected in your P
 ## Getting help
 
 - First, please carefully read through this PR description, from top to bottom. Please fill out the `Purpose of this PR` and `Due diligence checklist`.
+- If you don't have permissions to remove or add labels to the PR, request `write access` per [aka.ms/azsdk/access#request-access-to-rest-api-or-sdk-repositories](https://aka.ms/azsdk/access#request-access-to-rest-api-or-sdk-repositories")
 - To understand what you must do next to merge this PR, see the `Next Steps to Merge` comment. It will appear within few minutes of submitting this PR and will continue to be up-to-date with current PR state.
 - For guidance on fixing this PR CI check failures, see the hyperlinks provided in given failure 
   and https://aka.ms/ci-fix.
-- For help with PR workflow diagram Step 2 (ARM review), see https://aka.ms/azsdk/pr-arm-review.
+- For help with ARM review (PR workflow diagram Step 2), see https://aka.ms/azsdk/pr-arm-review.
 - If the PR CI checks appear to be stuck in `queued` state, please add a comment with contents `/azp run`.
   This should result in a new comment denoting a `PR validation pipeline` has started and the checks should be updated after few minutes.
 - If the help provided by the previous points is not enough, post to https://aka.ms/azsdk/support/specreview-channel and link to this PR.
-
-[ARM review queue]: https://aka.ms/azsdk/pr-arm-review#about-the-arm-review-queue
-[public repo merge queue]: https://github.com/Azure/azure-rest-api-specs/pulls?q=is%3Aopen+is%3Apr+label%3AMergeRequested+draft%3Afalse+sort%3Acreated-asc
-[private repo merge queue]: https://github.com/Azure/azure-rest-api-specs-pr/pulls?q=is%3Aopen+is%3Apr+label%3AMergeRequested+-label%3AApproved-OkToMerge+draft%3Afalse+sort%3Acreated-asc
-[Breaking Changes review process]: https://eng.ms/docs/cloud-ai-platform/azure-core/azure-core-pm-and-design/trusted-platform-pm-karimb/service-lifecycle-and-actions-team/service-lifecycle-actions-team/apex/media/launchingproductbreakingchanges#breaking-change-process-1

.github/PULL_REQUEST_TEMPLATE/ARM_spec_pr_review_workflow_diagram.png

@@ -1,7 +1,19 @@
-# Data Plane API - Pull Request
+# Data Plane API Specification Update Pull Request
+
+> [!TIP]
+> Overwhelmed by all this guidance? See the `Getting help` section at the bottom of this PR description.
+
+
 <!-- 🚨🚨🚨 Replace this line with a summary and reason for these changes to your data plane API 🚨🚨🚨 -->
 
+## PR review workflow diagram
+
+Please understand this diagram before proceeding. It explains how to get your PR approved & merged.
+
+![spec_pr_review_workflow_diagram](https://github.com/Azure/azure-rest-api-specs/assets/4429827/5bb5e7ce-8aff-4dbb-a3f8-0d9b68fef5b1)
+
 ## API Info: The Basics
+
 Most of the information about your service should be captured in the issue that serves as your [*API Spec engagement record*](https://aka.ms/azsdk/onboarding/restapischedule).
 
 * Link to API Spec engagement record issue:
@@ -48,7 +60,6 @@ The [Azure API Review Board](https://aka.ms/azsdk/onboarding/restapischedule) is
 
  * [Open API validation tools](https://aka.ms/swaggertools) were run on this PR. Go here to see [how to fix errors](https://aka.ms/ci-fix)
  * [Spectral Linting](https://github.com/Azure/azure-api-style-guide/blob/main/README.md)
- * [Open API Hub](https://aka.ms/openapiportal)
 
 ### Guidelines & Specifications
 
@@ -58,12 +69,17 @@ The [Azure API Review Board](https://aka.ms/azsdk/onboarding/restapischedule) is
 
 ### Helpful Links
 
- * [Azure DevTools Wiki](https://aka.ms/azapi)
+ * [Schedule a data plane REST API spec review](https://aka.ms/azsdk/onboarding/restapischedule)
 
 </details>
 
-<details>
-  <summary>Checks stuck in `queued` state?</summary>
-If the PR CI checks appear to be stuck in `queued` state, please add a comment with contents `/azp run`.
-This should result in a new comment denoting a `PR validation pipeline` has started and the checks should be updated after few minutes.  
-</details>
+## Getting help
+
+- First, please carefully read through this PR description, from top to bottom.
+- If you don't have permissions to remove or add labels to the PR, request `write access` per [aka.ms/azsdk/access#request-access-to-rest-api-or-sdk-repositories](https://aka.ms/azsdk/access#request-access-to-rest-api-or-sdk-repositories") 
+- To understand what you must do next to merge this PR, see the `Next Steps to Merge` comment. It will appear within few minutes of submitting this PR and will continue to be up-to-date with current PR state.
+- For guidance on fixing this PR CI check failures, see the hyperlinks provided in given failure 
+  and https://aka.ms/ci-fix.
+- If the PR CI checks appear to be stuck in `queued` state, please add a comment with contents `/azp run`.
+  This should result in a new comment denoting a `PR validation pipeline` has started and the checks should be updated after few minutes.
+- If the help provided by the previous points is not enough, post to https://aka.ms/azsdk/support/specreview-channel and link to this PR.