Skip to content

Commit ca571e3

Browse files
finiteattractormarstr
authored andcommitted
Swagger updates to address docs and sdk issues (#2139)
* added extension properties to Get & GetNode * fix indentation * fix indentation * changed description text * Adding new API version (2017-05-15-preview). No other changes made (#2) Adding new API version (2017-05-15-preview). Only three new resources added and all others reference the previous version. - Added resources: - SoftwareUpdateConfiguration - SoftwareUpdateConfigurationRun - SoftwareUpdateConfigurationMachineRun - Validations: - Autorest azure validations passed - x-ms-examples validated with no errors * Updated tag in global configuration Updated tag in global configuration to use the latest api version as per azure PR review comment * - Fixed 2 typos in URLs (#4) - Moved parameters inside operations as it was not showing properly in documentation. * Fixing merge error Fixing merge error * Fixing merge error Fixing merge error * swagger updates to address docs and sdk issues (#5) * Changed property type to integer * includedUpdateClassifications to scalar integer * model as string * type to string * Created adhoc property to allow code generation of enum with bitfield values since it seems that autorest doesn't support birfields and generate the enum only for string type property * test * Removed readonly attribute from name to allow setting outside constructor * Fixed parameter type and replaced reference to parameter with actual definition * removed descriminator property * trying modelAsString with false * modeled includedUpdateClassifications as string as deserialization was failing * - First letter capital for better looking doc - Replaces referece to paramaters with actual definitions on all resources - Cleaned common definition file * fixed x-ms-enum without enum on same level error in code generation * removed subid/rg/aa parameters to simplify sdk * added paemeters tat path level to avoid passing as arguments in sdk * more fixes * more fixes * fixing more parameters * Added missing automationAccountName parameter * made resourceGroupName passed in function for account resource * made schedule info requred property * moved filter parameter for better sdk parameter ordering * ran auto indent on files * Reformatted the file to use two-spaced indentation as per recommendation. * Fixing API version in definitions.json
1 parent 1f90a24 commit ca571e3

6 files changed

Lines changed: 959 additions & 937 deletions

File tree

specification/automation/resource-manager/Microsoft.Automation/2015-10-31/account.json

Lines changed: 42 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -32,7 +32,12 @@
3232
},
3333
"parameters": [
3434
{
35-
"$ref": "./definitions.json#/parameters/ResourceGroupNameParameter"
35+
"name": "resourceGroupName",
36+
"in": "path",
37+
"required": true,
38+
"type": "string",
39+
"pattern": "^[-\\w\\._]+$",
40+
"description": "The resource group name."
3641
},
3742
{
3843
"name": "automationAccountName",
@@ -88,7 +93,12 @@
8893
},
8994
"parameters": [
9095
{
91-
"$ref": "./definitions.json#/parameters/ResourceGroupNameParameter"
96+
"name": "resourceGroupName",
97+
"in": "path",
98+
"required": true,
99+
"type": "string",
100+
"pattern": "^[-\\w\\._]+$",
101+
"description": "The resource group name."
92102
},
93103
{
94104
"name": "automationAccountName",
@@ -150,7 +160,12 @@
150160
},
151161
"parameters": [
152162
{
153-
"$ref": "./definitions.json#/parameters/ResourceGroupNameParameter"
163+
"name": "resourceGroupName",
164+
"in": "path",
165+
"required": true,
166+
"type": "string",
167+
"pattern": "^[-\\w\\._]+$",
168+
"description": "The resource group name."
154169
},
155170
{
156171
"name": "automationAccountName",
@@ -197,7 +212,12 @@
197212
},
198213
"parameters": [
199214
{
200-
"$ref": "./definitions.json#/parameters/ResourceGroupNameParameter"
215+
"name": "resourceGroupName",
216+
"in": "path",
217+
"required": true,
218+
"type": "string",
219+
"pattern": "^[-\\w\\._]+$",
220+
"description": "The resource group name."
201221
},
202222
{
203223
"name": "automationAccountName",
@@ -246,7 +266,12 @@
246266
},
247267
"parameters": [
248268
{
249-
"$ref": "./definitions.json#/parameters/ResourceGroupNameParameter"
269+
"name": "resourceGroupName",
270+
"in": "path",
271+
"required": true,
272+
"type": "string",
273+
"pattern": "^[-\\w\\._]+$",
274+
"description": "The resource group name."
250275
},
251276
{
252277
"$ref": "./definitions.json#/parameters/SubscriptionIdParameter"
@@ -362,7 +387,12 @@
362387
},
363388
"parameters": [
364389
{
365-
"$ref": "./definitions.json#/parameters/ResourceGroupNameParameter"
390+
"name": "resourceGroupName",
391+
"in": "path",
392+
"required": true,
393+
"type": "string",
394+
"pattern": "^[-\\w\\._]+$",
395+
"description": "The resource group name."
366396
},
367397
{
368398
"name": "automationAccountName",
@@ -421,7 +451,12 @@
421451
},
422452
"parameters": [
423453
{
424-
"$ref": "./definitions.json#/parameters/ResourceGroupNameParameter"
454+
"name": "resourceGroupName",
455+
"in": "path",
456+
"required": true,
457+
"type": "string",
458+
"pattern": "^[-\\w\\._]+$",
459+
"description": "The resource group name."
425460
},
426461
{
427462
"name": "automationAccountName",

specification/automation/resource-manager/Microsoft.Automation/2015-10-31/definitions.json

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -3755,8 +3755,7 @@
37553755
"required": true,
37563756
"type": "string",
37573757
"pattern": "^[-\\w\\._]+$",
3758-
"description": "The resource group name.",
3759-
"x-ms-parameter-location": "method"
3758+
"description": "The resource group name."
37603759
}
37613760
}
37623761
}

0 commit comments

Comments
 (0)