Update changelog and remove client field formatting for client ID.

Author: Richard Park

sdk/messaging/azeventhubs/CHANGELOG.md

@@ -8,6 +8,8 @@
 
 ### Bugs Fixed
 
+- Processor wasn't distributing partitions optimally. (PR#22153)
+
 ### Other Changes
 
 ## 1.0.2 (2023-11-07)

sdk/messaging/azeventhubs/processor_load_balancer.go

@@ -76,7 +76,7 @@ func (lb *processorLoadBalancer) LoadBalance(ctx context.Context, partitionIDs [
 		// - I have too many. We expect to have some stolen from us, but we'll maintain
 		//    ownership for now.
 		claimMorePartitions = false
-		log.Writef(EventConsumer, "[%0.5s] Owns %d/%d, no more needed", lb.details.ClientID, len(lbinfo.current), lbinfo.maxAllowed)
+		log.Writef(EventConsumer, "[%s] Owns %d/%d, no more needed", lb.details.ClientID, len(lbinfo.current), lbinfo.maxAllowed)
 	} else if lbinfo.extraPartitionPossible && len(lbinfo.current) == lbinfo.maxAllowed-1 {
 		// In the 'extraPartitionPossible' scenario, some consumers will have an extra partition
 		// since things don't divide up evenly. We're one under the max, which means we _might_
@@ -85,7 +85,7 @@ func (lb *processorLoadBalancer) LoadBalance(ctx context.Context, partitionIDs [
 		// We will attempt to grab _one_ more but only if there are free partitions available
 		// or if one of the consumers has more than the max allowed.
 		claimMorePartitions = len(lbinfo.unownedOrExpired) > 0 || len(lbinfo.aboveMax) > 0
-		log.Writef(EventConsumer, "[%0.5s] Unowned/expired: %d, above max: %d, need to claim: %t",
+		log.Writef(EventConsumer, "[%s] Unowned/expired: %d, above max: %d, need to claim: %t",
 			lb.details.ClientID,
 			len(lbinfo.unownedOrExpired),
 			len(lbinfo.aboveMax),
@@ -97,17 +97,17 @@ func (lb *processorLoadBalancer) LoadBalance(ctx context.Context, partitionIDs [
 	if claimMorePartitions {
 		switch lb.strategy {
 		case ProcessorStrategyGreedy:
-			log.Writef(EventConsumer, "[%0.5s] Using greedy strategy to claim partitions", lb.details.ClientID)
+			log.Writef(EventConsumer, "[%s] Using greedy strategy to claim partitions", lb.details.ClientID)
 			ownerships = lb.greedyLoadBalancer(ctx, lbinfo)
 		case ProcessorStrategyBalanced:
-			log.Writef(EventConsumer, "[%0.5s] Using balanced strategy to claim partitions", lb.details.ClientID)
+			log.Writef(EventConsumer, "[%s] Using balanced strategy to claim partitions", lb.details.ClientID)
 			o := lb.balancedLoadBalancer(ctx, lbinfo)
 
 			if o != nil {
 				ownerships = append(lbinfo.current, *o)
 			}
 		default:
-			return nil, fmt.Errorf("[%0.5s] invalid load balancing strategy '%s'", lb.details.ClientID, lb.strategy)
+			return nil, fmt.Errorf("[%s] invalid load balancing strategy '%s'", lb.details.ClientID, lb.strategy)
 		}
 	}
 
@@ -118,7 +118,7 @@ func (lb *processorLoadBalancer) LoadBalance(ctx context.Context, partitionIDs [
 	}
 
 	if log.Should(EventConsumer) {
-		log.Writef(EventConsumer, "[%0.5s] Asked for %s, got %s", lb.details.ClientID, partitionsForOwnerships(ownerships), partitionsForOwnerships(actual))
+		log.Writef(EventConsumer, "[%s] Asked for %s, got %s", lb.details.ClientID, partitionsForOwnerships(ownerships), partitionsForOwnerships(actual))
 	}
 
 	return actual, nil

sdk/messaging/azeventhubs/processor_load_balancers_test.go

@@ -285,15 +285,15 @@ func TestProcessorLoadBalancers_AnyStrategy_StealsToBalance(t *testing.T) {
 func TestProcessorLoadBalancers_InvalidStrategy(t *testing.T) {
 	cps := newCheckpointStoreForTest()
 
-	lb := newProcessorLoadBalancer(cps, newTestConsumerDetails("does not matter"), "", time.Hour)
+	lb := newProcessorLoadBalancer(cps, newTestConsumerDetails("clientid"), "", time.Hour)
 	ownerships, err := lb.LoadBalance(context.Background(), []string{"0"})
 	require.Nil(t, ownerships)
-	require.EqualError(t, err, "invalid load balancing strategy ''")
+	require.EqualError(t, err, "[clientid] invalid load balancing strategy ''")
 
-	lb = newProcessorLoadBalancer(cps, newTestConsumerDetails("does not matter"), "super-greedy", time.Hour)
+	lb = newProcessorLoadBalancer(cps, newTestConsumerDetails("clientid"), "super-greedy", time.Hour)
 	ownerships, err = lb.LoadBalance(context.Background(), []string{"0"})
 	require.Nil(t, ownerships)
-	require.EqualError(t, err, "invalid load balancing strategy 'super-greedy'")
+	require.EqualError(t, err, "[clientid] invalid load balancing strategy 'super-greedy'")
 }
 
 func TestProcessorLoadBalancers_AnyStrategy_GrabRelinquishedPartition(t *testing.T) {