Fix skill review comments from Java PR #48875

- Fix wrong MCP tool name: azsdk_typespec_customized_code_update
  -> azsdk_customized_code_update (apiview-feedback-resolution SKILL.md)
- Add azure-sdk-mcp: prefix to tool table in generate-sdk-locally
  SKILL.md for consistency with step references
- Narrow overly broad regex_not_match patterns in
  generate-sdk-locally eval.yaml (remove 'failed'/'error occurred'
  which cause false failures for build troubleshooting tasks)
- Fix YAML indentation in 4 evals/eval.yaml files (graders section
  not properly nested under graders: key)

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

Author: 2 people

.github/skills/azsdk-common-apiview-feedback-resolution/SKILL.md

@@ -4,7 +4,7 @@ license: MIT
 metadata:
   version: "1.0.0"
   distribution: shared
-description: "Analyze and resolve APIView review feedback on Azure SDK PRs. **UTILITY SKILL**. USE FOR: APIView comments, API review feedback, SDK API surface changes. DO NOT USE FOR: general code review, non-APIView feedback. INVOKES: azure-sdk-mcp:azsdk_apiview_get_comments, azure-sdk-mcp:azsdk_typespec_customized_code_update."
+description: "Analyze and resolve APIView review feedback on Azure SDK PRs. **UTILITY SKILL**. USE FOR: APIView comments, API review feedback, SDK API surface changes. DO NOT USE FOR: general code review, non-APIView feedback. INVOKES: azure-sdk-mcp:azsdk_apiview_get_comments, azure-sdk-mcp:azsdk_customized_code_update."
 compatibility:
   requires: "azure-sdk-mcp server, SDK pull request with APIView review link"
 ---
@@ -18,7 +18,7 @@ compatibility:
 | Tool | Purpose |
 |------|---------|
 | `azure-sdk-mcp:azsdk_apiview_get_comments` | Get APIView comments |
-| `azure-sdk-mcp:azsdk_typespec_customized_code_update` | Apply TypeSpec changes locally |
+| `azure-sdk-mcp:azsdk_customized_code_update` | Apply TypeSpec & code customization changes locally |
 | `azure-sdk-mcp:azsdk_typespec_delegate_apiview_feedback` | Delegate to CCA pipeline |
 | `azure-sdk-mcp:azsdk_run_typespec_validation` | Validate TypeSpec |
 | `azure-sdk-mcp:azsdk_package_generate_code` | Regenerate SDK |
@@ -27,7 +27,7 @@ compatibility:
 
 1. **Retrieve** — Get APIView URL from SDK PR, run `azsdk_apiview_get_comments`.
 2. **Categorize** — Group as Critical/Suggestions/Informational per [feedback steps](references/feedback-resolution-steps.md).
-3. **Resolve** — Use `azsdk_typespec_customized_code_update` for TypeSpec changes; delegate via `azsdk_typespec_delegate_apiview_feedback` for complex cases.
+3. **Resolve** — Use `azsdk_customized_code_update` for TypeSpec changes; delegate via `azsdk_typespec_delegate_apiview_feedback` for complex cases.
 4. **Validate** — Run validation, regenerate SDK, build and test.
 5. **Confirm** — Verify all items addressed. If delegated, follow [post-delegation follow-up](references/feedback-resolution-steps.md#post-delegation-follow-up). Request re-review.
 

.github/skills/azsdk-common-apiview-feedback-resolution/evals/eval.yaml

@@ -18,12 +18,12 @@ metrics:
     threshold: 0.7
     description: Did the skill stay within behavior limits?
 graders:
-- type: text
-  name: no_fatal_errors
-  config:
-    regex_not_match:
-    - (?i)fatal error
-    - (?i)unhandled exception
-    - '(?i)panic:'
+  - type: text
+    name: no_fatal_errors
+    config:
+      regex_not_match:
+        - (?i)fatal error
+        - (?i)unhandled exception
+        - '(?i)panic:'
 tasks:
   - "tasks/*.yaml"

.github/skills/azsdk-common-generate-sdk-locally/SKILL.md

@@ -15,15 +15,15 @@ compatibility:
 
 | Tool | Purpose |
 |------|---------|
-| `azsdk_verify_setup` | Verify environment |
-| `azsdk_package_generate_code` | Generate SDK |
-| `azsdk_package_build_code` | Build package |
-| `azsdk_package_run_check` | Validate package |
-| `azsdk_package_run_tests` | Run tests |
-| `azsdk_customized_code_update` | Apply customizations (includes regeneration and build) |
-| `azsdk_package_update_changelog_content` | Update changelog |
-| `azsdk_package_update_metadata` | Update metadata including ci.yml |
-| `azsdk_package_update_version` | Update version |
+| `azure-sdk-mcp:azsdk_verify_setup` | Verify environment |
+| `azure-sdk-mcp:azsdk_package_generate_code` | Generate SDK |
+| `azure-sdk-mcp:azsdk_package_build_code` | Build package |
+| `azure-sdk-mcp:azsdk_package_run_check` | Validate package |
+| `azure-sdk-mcp:azsdk_package_run_tests` | Run tests |
+| `azure-sdk-mcp:azsdk_customized_code_update` | Apply customizations (includes regeneration and build) |
+| `azure-sdk-mcp:azsdk_package_update_changelog_content` | Update changelog |
+| `azure-sdk-mcp:azsdk_package_update_metadata` | Update metadata including ci.yml |
+| `azure-sdk-mcp:azsdk_package_update_version` | Update version |
 
 Prerequisites: azure-sdk-mcp server must be running. Without MCP, use `npx tsp-client` CLI.
 

.github/skills/azsdk-common-generate-sdk-locally/eval.yaml

@@ -22,8 +22,7 @@ graders:
     name: no_fatal_errors
     config:
       regex_not_match:
-        - (?i)error occurred
-        - (?i)failed
-        - (?i)re-run the tool
+        - (?i)fatal error
+        - (?i)unhandled exception
 tasks:
   - "tasks/*.yaml"

.github/skills/azsdk-common-pipeline-troubleshooting/evals/eval.yaml

@@ -18,12 +18,12 @@ metrics:
     threshold: 0.7
     description: Did the skill stay within behavior limits?
 graders:
-- type: text
-  name: no_fatal_errors
-  config:
-    regex_not_match:
-    - (?i)fatal error
-    - (?i)unhandled exception
-    - '(?i)panic:'
+  - type: text
+    name: no_fatal_errors
+    config:
+      regex_not_match:
+        - (?i)fatal error
+        - (?i)unhandled exception
+        - '(?i)panic:'
 tasks:
   - "tasks/*.yaml"

.github/skills/azsdk-common-prepare-release-plan/evals/eval.yaml

@@ -18,12 +18,12 @@ metrics:
     threshold: 0.7
     description: Did the skill stay within behavior limits?
 graders:
-- type: text
-  name: no_fatal_errors
-  config:
-    regex_not_match:
-    - (?i)fatal error
-    - (?i)unhandled exception
-    - '(?i)panic:'
+  - type: text
+    name: no_fatal_errors
+    config:
+      regex_not_match:
+        - (?i)fatal error
+        - (?i)unhandled exception
+        - '(?i)panic:'
 tasks:
   - "tasks/*.yaml"

.github/skills/azsdk-common-sdk-release/evals/eval.yaml

@@ -18,12 +18,12 @@ metrics:
     threshold: 0.7
     description: Did the skill stay within behavior limits?
 graders:
-- type: text
-  name: no_fatal_errors
-  config:
-    regex_not_match:
-    - (?i)fatal error
-    - (?i)unhandled exception
-    - '(?i)panic:'
+  - type: text
+    name: no_fatal_errors
+    config:
+      regex_not_match:
+        - (?i)fatal error
+        - (?i)unhandled exception
+        - '(?i)panic:'
 tasks:
   - "tasks/*.yaml"