[identity] Refactor plugin definitions (#28781)

### Packages impacted by this PR

@azure/identity

### Issues associated with this PR

Resolves #28679

### Describe the problem that is addressed by this PR

When migrating plugin support to MSALClient I noticed that
msalNodeCommon defines all the plugin declarations. To avoid 
duplication, provide an easy path to migrate (by avoiding imports 
on msalNodeCommon) and provide a single source of truth for plugin 
settings it made sense to migrate all the definitions to a single file.

This is purely mechanical, just moving things around and updating
imports

### Provide a list of related PRs _(if any)_

#28493

Author: maorleger

sdk/identity/identity/src/msal/nodeFlows/msalNodeCommon.ts

@@ -19,6 +19,7 @@ import {
   publicToMsal,
   randomUUID,
 } from "../utils";
+import { hasNativeBroker, nativeBrokerInfo, persistenceProvider } from "./msalPlugins";
 import {
   processMultiTenantRequest,
   resolveAdditionallyAllowedTenantIds,
@@ -32,7 +33,6 @@ import { CredentialFlowGetTokenOptions } from "../credentials";
 import { IdentityClient } from "../../client/identityClient";
 import { LogPolicyOptions } from "@azure/core-rest-pipeline";
 import { MultiTenantTokenCredentialOptions } from "../../credentials/multiTenantTokenCredentialOptions";
-import { NativeBrokerPluginControl } from "../../plugins/provider";
 import { RegionalAuthority } from "../../regionalAuthority";
 import { TokenCachePersistenceOptions } from "./tokenCachePersistenceOptions";
 import { getLogLevel } from "@azure/logger";
@@ -66,50 +66,6 @@ export interface MsalNodeOptions extends MsalFlowOptions {
   };
 }
 
-/**
- * The current persistence provider, undefined by default.
- * @internal
- */
-export let persistenceProvider:
-  | ((options?: TokenCachePersistenceOptions) => Promise<msalNode.ICachePlugin>)
-  | undefined = undefined;
-
-/**
- * An object that allows setting the persistence provider.
- * @internal
- */
-export const msalNodeFlowCacheControl = {
-  setPersistence(pluginProvider: Exclude<typeof persistenceProvider, undefined>): void {
-    persistenceProvider = pluginProvider;
-  },
-};
-
-/**
- * The current native broker provider, undefined by default.
- * @internal
- */
-export let nativeBrokerInfo:
-  | {
-      broker: msalNode.INativeBrokerPlugin;
-    }
-  | undefined = undefined;
-
-export function hasNativeBroker(): boolean {
-  return nativeBrokerInfo !== undefined;
-}
-
-/**
- * An object that allows setting the native broker provider.
- * @internal
- */
-export const msalNodeFlowNativeBrokerControl: NativeBrokerPluginControl = {
-  setNativeBroker(broker): void {
-    nativeBrokerInfo = {
-      broker,
-    };
-  },
-};
-
 /**
  * MSAL partial base client for Node.js.
  *

sdk/identity/identity/src/msal/nodeFlows/msalOpenBrowser.ts

@@ -3,12 +3,13 @@
 
 import * as msalNode from "@azure/msal-node";
 
-import { MsalNode, MsalNodeOptions, hasNativeBroker } from "./msalNodeCommon";
+import { MsalNode, MsalNodeOptions } from "./msalNodeCommon";
 
 import { AccessToken } from "@azure/core-auth";
 import { CredentialFlowGetTokenOptions } from "../credentials";
 import { credentialLogger } from "../../util/logging";
 import { handleMsalError } from "../utils";
+import { hasNativeBroker } from "./msalPlugins";
 import open from "open";
 
 /**

sdk/identity/identity/src/msal/nodeFlows/msalPlugins.ts

@@ -3,12 +3,9 @@
 
 import * as msalNode from "@azure/msal-node";
 
-import { nativeBrokerInfo, persistenceProvider } from "./msalNodeCommon";
-
 import { MsalClientOptions } from "./msalClient";
-
-// TODO: invert this relationship, instead of importing from msalNodeCommon and calling into it, we should _export_ the right things from here and import them in msalNodeCommon
-// Then, there's a single source for plugins across both msalClient and msalNodeCommon
+import { NativeBrokerPluginControl } from "../../plugins/provider";
+import { TokenCachePersistenceOptions } from "./tokenCachePersistenceOptions";
 
 /**
  * Configuration for the plugins used by the MSAL node client.
@@ -30,6 +27,50 @@ export interface PluginConfiguration {
   };
 }
 
+/**
+ * The current persistence provider, undefined by default.
+ * @internal
+ */
+export let persistenceProvider:
+  | ((options?: TokenCachePersistenceOptions) => Promise<msalNode.ICachePlugin>)
+  | undefined = undefined;
+
+/**
+ * An object that allows setting the persistence provider.
+ * @internal
+ */
+export const msalNodeFlowCacheControl = {
+  setPersistence(pluginProvider: Exclude<typeof persistenceProvider, undefined>): void {
+    persistenceProvider = pluginProvider;
+  },
+};
+
+/**
+ * The current native broker provider, undefined by default.
+ * @internal
+ */
+export let nativeBrokerInfo:
+  | {
+      broker: msalNode.INativeBrokerPlugin;
+    }
+  | undefined = undefined;
+
+export function hasNativeBroker(): boolean {
+  return nativeBrokerInfo !== undefined;
+}
+
+/**
+ * An object that allows setting the native broker provider.
+ * @internal
+ */
+export const msalNodeFlowNativeBrokerControl: NativeBrokerPluginControl = {
+  setNativeBroker(broker): void {
+    nativeBrokerInfo = {
+      broker,
+    };
+  },
+};
+
 /**
  * Configures plugins, validating that required plugins are available and enabled.
  *

sdk/identity/identity/src/plugins/consumer.ts

@@ -5,7 +5,8 @@ import { AzurePluginContext, IdentityPlugin } from "./provider";
 import {
   msalNodeFlowCacheControl,
   msalNodeFlowNativeBrokerControl,
-} from "../msal/nodeFlows/msalNodeCommon";
+} from "../msal/nodeFlows/msalPlugins";
+
 import { vsCodeCredentialControl } from "../credentials/visualStudioCodeCredential";
 
 /**

sdk/identity/identity/test/internal/node/msalPlugins.spec.ts

@@ -5,11 +5,9 @@ import { ICachePlugin, INativeBrokerPlugin } from "@azure/msal-node";
 import {
   PluginConfiguration,
   generatePluginConfiguration,
-} from "../../../src/msal/nodeFlows/msalPlugins";
-import {
   msalNodeFlowCacheControl,
   msalNodeFlowNativeBrokerControl,
-} from "../../../src/msal/nodeFlows/msalNodeCommon";
+} from "../../../src/msal/nodeFlows/msalPlugins";
 
 import { MsalClientOptions } from "../../../src/msal/nodeFlows/msalClient";
 import { assert } from "@azure/test-utils";