[eslint-plugin] skip some package json linting for packages using tshy (#29912)

as packages using tshy has been migrated to ESM and these rules no
longer apply to them.
This PR skip these rules to avoid having to turn them off for individual
packages.

### What are the possible designs available to address the problem? If
there are more than one possible design, why was the one in this PR
chosen?
We could remove these rules too. Although it's still nice to have them
before we migrage all packages to ESM with tshy.

Author: jeremymeng

common/tools/dev-tool/src/commands/admin/list/esm-migrations.ts

@@ -88,6 +88,7 @@ function createMigrationResult(): MigrationResult {
 }
 
 function setMigrationResult(
+  // eslint-disable-next-line @typescript-eslint/no-explicit-any
   packageJson: any,
   project: RushJsonProject,
   results: MigrationResult,

common/tools/eslint-plugin-azure-sdk/src/rules/ts-apiextractor-json-types.ts

@@ -5,7 +5,7 @@
  * @file Rule to force the inclusion of type declarations in the package.
  */
 
-import { createRule, getVerifiers, stripPath } from "../utils";
+import { createRule, getVerifiers, stripPath, usesTshy } from "../utils";
 import { TSESTree } from "@typescript-eslint/utils";
 import { VerifierMessages, stripFileName } from "../utils/verifiers";
 
@@ -42,6 +42,9 @@ export default createRule({
     if (stripPath(fileName) !== "api-extractor.json") {
       return {};
     }
+    if (usesTshy(context.filename)) {
+      return {};
+    }
     return {
       // callback functions
       "ExpressionStatement > ObjectExpression": verifiers.existsInFile,

common/tools/eslint-plugin-azure-sdk/src/rules/ts-package-json-files-required.ts

@@ -6,7 +6,14 @@
  *
  */
 import { TSESTree } from "@typescript-eslint/utils";
-import { VerifierMessages, arrayToString, createRule, getVerifiers, stripPath } from "../utils";
+import {
+  VerifierMessages,
+  arrayToString,
+  createRule,
+  getVerifiers,
+  stripPath,
+  usesTshy,
+} from "../utils";
 
 //------------------------------------------------------------------------------
 // Rule Definition
@@ -75,6 +82,9 @@ export default createRule({
     if (stripPath(context.filename) !== "package.json") {
       return {};
     }
+    if (usesTshy(context.filename)) {
+      return {};
+    }
     return {
       // check to see if files exists at the outermost level
       "ExpressionStatement > ObjectExpression": verifiers.existsInFile,

common/tools/eslint-plugin-azure-sdk/src/rules/ts-package-json-main-is-cjs.ts

@@ -7,7 +7,7 @@
  */
 
 import { TSESTree } from "@typescript-eslint/utils";
-import { VerifierMessages, createRule, getVerifiers, stripPath } from "../utils";
+import { VerifierMessages, createRule, getVerifiers, stripPath, usesTshy } from "../utils";
 
 //------------------------------------------------------------------------------
 // Rule Definition
@@ -38,6 +38,9 @@ export default createRule({
     if (stripPath(context.filename) !== "package.json") {
       return {};
     }
+    if (usesTshy(context.filename)) {
+      return {};
+    }
     return {
       // check to see if main exists at the outermost level
       "ExpressionStatement > ObjectExpression": verifiers.existsInFile,

common/tools/eslint-plugin-azure-sdk/src/rules/ts-package-json-module.ts

@@ -7,7 +7,7 @@
  */
 
 import { TSESTree } from "@typescript-eslint/utils";
-import { VerifierMessages, createRule, getVerifiers, stripPath } from "../utils";
+import { VerifierMessages, createRule, getVerifiers, stripPath, usesTshy } from "../utils";
 
 //------------------------------------------------------------------------------
 // Rule Definition
@@ -38,6 +38,9 @@ export default createRule({
     if (stripPath(context.filename) !== "package.json") {
       return {};
     }
+    if (usesTshy(context.filename)) {
+      return {};
+    }
     return {
       // check to see if module exists at the outermost level
       "ExpressionStatement > ObjectExpression": verifiers.existsInFile,

common/tools/eslint-plugin-azure-sdk/src/rules/ts-package-json-types.ts

@@ -7,7 +7,7 @@
  */
 
 import { TSESTree } from "@typescript-eslint/utils";
-import { createRule, getVerifiers, stripPath } from "../utils";
+import { createRule, getVerifiers, stripPath, usesTshy } from "../utils";
 import { VerifierMessages, stripFileName } from "../utils/verifiers";
 
 //------------------------------------------------------------------------------
@@ -42,6 +42,9 @@ export default createRule({
     if (stripPath(context.filename) !== "package.json") {
       return {};
     }
+    if (usesTshy(context.filename)) {
+      return {};
+    }
     return {
       // check to see if types exists at the outermost level
       "ExpressionStatement > ObjectExpression": verifiers.existsInFile,

common/tools/eslint-plugin-azure-sdk/src/utils/index.ts

@@ -11,6 +11,7 @@ export {
   arrayToString,
   getVerifiers,
   stripPath,
+  usesTshy,
   VerifierMessages,
   type VerifierMessageIds,
 } from "./verifiers";

common/tools/eslint-plugin-azure-sdk/src/utils/verifiers.ts

@@ -6,6 +6,8 @@
  */
 
 import { TSESTree, TSESLint } from "@typescript-eslint/utils";
+import { statSync } from "node:fs";
+import * as path from "node:path";
 
 interface StructureData {
   outer: string;
@@ -42,6 +44,15 @@ export type VerifierMessageIds = keyof typeof VerifierMessages;
 export const stripPath = (pathOrFileName: string): string =>
   pathOrFileName.replace(/^.*[\\\/]/, "");
 
+export function usesTshy(packageJsonPath: string): boolean {
+  const dotTshy = path.join(path.dirname(packageJsonPath), ".tshy");
+  try {
+    statSync(dotTshy);
+    return true;
+  } catch {
+    return false;
+  }
+}
 /**
  * Get the directory of a filename
  * @param pathOrFileName the input path or file name

sdk/.eslintrc.json

@@ -1,10 +1,5 @@
 {
   "plugins": ["@azure/azure-sdk"],
   "extends": ["plugin:@azure/azure-sdk/azure-sdk-base"],
-  "ignorePatterns": ["**/test/perf/track-1"],
-  "rules": {
-    "@azure/azure-sdk/ts-package-json-module": "off",
-    "@azure/azure-sdk/ts-package-json-files-required": "off",
-    "@azure/azure-sdk/ts-package-json-main-is-cjs": "off",
-    "@azure/azure-sdk/ts-package-json-types": "off"}
+  "ignorePatterns": ["**/test/perf/track-1"]
 }

sdk/apimanagement/api-management-custom-widgets-scaffolder/.eslintrc.json

@@ -1,11 +1,6 @@
 {
   "plugins": ["@azure/azure-sdk"],
   "extends": ["plugin:@azure/azure-sdk/azure-sdk-base"],
-  "rules": {
-    "@azure/azure-sdk/ts-package-json-types": "off",
-    "@azure/azure-sdk/ts-package-json-main-is-cjs": "off",
-    "@azure/azure-sdk/ts-package-json-module": "off"
-  },
   "ignorePatterns": [],
   "overrides": [
     {