Default to sub config file paths/svc connection for public + sovereign live tests#45161
Merged
benbp merged 1 commit intoAzure:mainfrom Oct 2, 2024
Merged
Default to sub config file paths/svc connection for public + sovereign live tests#45161benbp merged 1 commit intoAzure:mainfrom
benbp merged 1 commit intoAzure:mainfrom
Conversation
benbp
added
the
Central-EngSys
benbp
requested review from
a team,
ShivangiReja,
amnguye,
jalauzon-msft,
jaschrep-msft,
kinelski,
nisha-bhatia,
schaabs,
seanmcc-msft and
tg-msft
as code owners
benbp
requested review from
a team,
Aashish93-stack,
JonathanCrd,
JoshLove-msft,
abhinav-ghai,
christothes,
heaths,
johngallardo,
joseharriaga,
jsquire,
mconnew,
minwoolee-msft,
quentinRobinson,
sjiherzig and
subhra231
as code owners
benbp
requested review from
Haiying-MSFT,
KarishmaGhiya,
gracewilcox,
pvaneck and
scottaddie
benbp
force-pushed
the
benbp/sub-config-sovereign
branch
from
c578b5d to
aea4b42
Compare
Collaborator
|
API change check API changes are not detected in this pull request. |
weshaggard
reviewed
Jul 24, 2024
|
Hi @benbp. Thank you for your interest in helping to improve the Azure SDK experience and for your contribution. We've noticed that there hasn't been recent engagement on this pull request. If this is still an active work stream, please let us know by pushing some changes or leaving a comment. Otherwise, we'll close this out in 7 days. |
github-actions
Bot
added
the
no-recent-activity
benbp
removed
the
no-recent-activity
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This doesn't cover the many files still using secret sub configs with custom principals, those will be migrated separately. This changes the defaults to use file-based sub configs and service connections everywhere else. It is intended to be merged after/alongside federated auth mode becoming the default.
Relies on Azure/azure-sdk-tools#8680