Skip to content

Commit 5b48838

Browse files
authored
fix lingering files to use new Connections (#32742)
* fix configs.py file to use new connection * fix connections.py
1 parent 285d175 commit 5b48838

2 files changed

Lines changed: 16 additions & 16 deletions

File tree

sdk/ai/azure-ai-generative/azure/ai/generative/entities/configs.py

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -3,7 +3,7 @@
33
# ---------------------------------------------------------
44
from dataclasses import dataclass
55
from typing import Any, Dict
6-
from azure.ai.generative.entities.connection import Connection
6+
from azure.ai.generative.entities import AzureOpenAIConnection
77
from azure.ai.ml._utils.utils import camel_to_snake
88

99

@@ -19,9 +19,9 @@ class AzureOpenAIModelConfiguration:
1919

2020
@staticmethod
2121
def from_connection(
22-
connection: Connection, model_name: str, deployment_name: str, **model_kwargs
22+
connection: AzureOpenAIConnection, model_name: str, deployment_name: str, **model_kwargs
2323
) -> 'AzureOpenAIModelConfiguration':
24-
if not isinstance(connection, Connection) or camel_to_snake(connection.type) != "azure_open_ai":
24+
if not isinstance(connection, AzureOpenAIConnection) or camel_to_snake(connection.type) != "azure_open_ai":
2525
raise TypeError(
2626
"Only AzureOpenAI connection objects are supported."
2727
)
@@ -31,8 +31,8 @@ def from_connection(
3131

3232
return AzureOpenAIModelConfiguration(
3333
api_base=connection.target,
34-
api_key=connection.credentials.get("key"),
35-
api_version=connection.metadata.get("ApiVersion"),
34+
api_key=connection.credentials.key,
35+
api_version=connection.api_version,
3636
model_name=model_name,
3737
deployment_name=deployment_name,
3838
model_kwargs=model_kwargs,

sdk/ai/azure-ai-generative/azure/ai/generative/index/_utils/connections.py

Lines changed: 11 additions & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -12,10 +12,10 @@
1212

1313
try:
1414
from azure.ai.generative import AIClient
15-
from azure.ai.generative.entities import Connection
15+
from azure.ai.generative.entities import BaseConnection
1616
except Exception:
1717
AIClient = None
18-
Connection = None
18+
BaseConnection = None
1919
try:
2020
from azure.ai.ml import MLClient
2121
from azure.ai.ml.entities import WorkspaceConnection
@@ -84,12 +84,12 @@ def get_connection_credential(config, credential: Optional[TokenCredential] = No
8484
return connection_credential
8585

8686

87-
def workspace_connection_to_credential(connection: Union[dict, Connection, WorkspaceConnection]):
87+
def workspace_connection_to_credential(connection: Union[dict, BaseConnection, WorkspaceConnection]):
8888
"""Get a credential for a workspace connection."""
8989
return connection_to_credential(connection)
9090

9191

92-
def connection_to_credential(connection: Union[dict, Connection, WorkspaceConnection]):
92+
def connection_to_credential(connection: Union[dict, BaseConnection, WorkspaceConnection]):
9393
"""Get a credential for a workspace connection."""
9494
if isinstance(connection, dict):
9595
props = connection["properties"]
@@ -145,7 +145,7 @@ def connection_to_credential(connection: Union[dict, Connection, WorkspaceConnec
145145
raise ValueError(f"Unknown auth type '{connection.credentials.type}' for connection '{connection.name}'")
146146

147147

148-
def get_connection_by_id_v2(connection_id: str, credential: TokenCredential = None, client: str = "sdk") -> Union[dict, WorkspaceConnection, Connection]:
148+
def get_connection_by_id_v2(connection_id: str, credential: TokenCredential = None, client: str = "sdk") -> Union[dict, WorkspaceConnection, BaseConnection]:
149149
"""
150150
Get a connection by id using azure.ai.ml or azure.ai.generative.
151151
@@ -204,37 +204,37 @@ def get_connection_by_id_v2(connection_id: str, credential: TokenCredential = No
204204
return connection
205205

206206

207-
def get_id_from_connection(connection: Union[dict, WorkspaceConnection, Connection]) -> str:
207+
def get_id_from_connection(connection: Union[dict, WorkspaceConnection, BaseConnection]) -> str:
208208
"""Get a connection id from a connection."""
209209
if isinstance(connection, dict):
210210
return connection["id"]
211211
elif isinstance(connection, WorkspaceConnection):
212212
return connection.id
213-
elif isinstance(connection, Connection):
213+
elif isinstance(connection, BaseConnection):
214214
return connection.id
215215
else:
216216
raise ValueError(f"Unknown connection type: {type(connection)}")
217217

218218

219-
def get_target_from_connection(connection: Union[dict, WorkspaceConnection, Connection]) -> str:
219+
def get_target_from_connection(connection: Union[dict, WorkspaceConnection, BaseConnection]) -> str:
220220
"""Get a connection target from a connection."""
221221
if isinstance(connection, dict):
222222
return connection["properties"]["target"]
223223
elif isinstance(connection, WorkspaceConnection):
224224
return connection.target
225-
elif isinstance(connection, Connection):
225+
elif isinstance(connection, BaseConnection):
226226
return connection.target
227227
else:
228228
raise ValueError(f"Unknown connection type: {type(connection)}")
229229

230230

231-
def get_metadata_from_connection(connection: Union[dict, WorkspaceConnection, Connection]) -> dict:
231+
def get_metadata_from_connection(connection: Union[dict, WorkspaceConnection, BaseConnection]) -> dict:
232232
"""Get a connection metadata from a connection."""
233233
if isinstance(connection, dict):
234234
return connection["properties"]["metadata"]
235235
elif isinstance(connection, WorkspaceConnection):
236236
return connection.metadata
237-
elif isinstance(connection, Connection):
237+
elif isinstance(connection, BaseConnection):
238238
return connection.metadata
239239
else:
240240
raise ValueError(f"Unknown connection type: {type(connection)}")

0 commit comments

Comments
 (0)