Skip to content

Commit 995e57f

Browse files
committed
update changelog, fix some docstring and sample error
1 parent 4280381 commit 995e57f

7 files changed

Lines changed: 16 additions & 13 deletions

File tree

sdk/servicebus/azure-servicebus/CHANGELOG.md

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -15,6 +15,7 @@
1515

1616
* Session receivers are now created via their own top level functions, e.g. `get_queue_sesison_receiver` and `get_subscription_session_receiver`. Non session receivers no longer take session_id as a paramter.
1717
* `ServiceBusSender.send()` no longer takes a timeout parameter, as it should be redundant with retry options provided when creating the client.
18+
* Exception imports have been removed from module `azure.servicebus`. Import from `azure.servicebus.exceptions` instead.
1819

1920
## 7.0.0b1 (2020-04-06)
2021

sdk/servicebus/azure-servicebus/azure/servicebus/_servicebus_sender.py

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -291,11 +291,11 @@ def from_connection_string(
291291
return cls(**constructor_args)
292292

293293
def send(self, message):
294-
# type: (Union[Message, BatchMessage], float) -> None
294+
# type: (Union[Message, BatchMessage]) -> None
295295
"""Sends message and blocks until acknowledgement is received or operation times out.
296296
297297
:param message: The ServiceBus message to be sent.
298-
:type message: ~azure.servicebus.Message
298+
:type message: ~azure.servicebus.Message or ~azure.servicebus.BatchMessage
299299
:rtype: None
300300
:raises: ~azure.servicebus.common.errors.MessageSendFailed if the message fails to
301301
send or ~azure.servicebus.common.errors.OperationTimeoutError if sending times out.

sdk/servicebus/azure-servicebus/azure/servicebus/aio/_servicebus_sender_async.py

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -239,11 +239,11 @@ def from_connection_string(
239239
return cls(**constructor_args)
240240

241241
async def send(self, message):
242-
# type: (Message, float) -> None
242+
# type: (Union[Message, BatchMessage]) -> None
243243
"""Sends message and blocks until acknowledgement is received or operation times out.
244244
245245
:param message: The ServiceBus message to be sent.
246-
:type message: ~azure.servicebus.Message
246+
:type message: ~azure.servicebus.Message or ~azure.servicebus.BatchMessage
247247
:rtype: None
248248
:raises: ~azure.servicebus.common.errors.MessageSendFailed if the message fails to
249249
send or ~azure.servicebus.common.errors.OperationTimeoutError if sending times out.

sdk/servicebus/azure-servicebus/samples/async_samples/receive_deferred_message_queue_async.py

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -14,7 +14,6 @@
1414
import os
1515
import asyncio
1616
from azure.servicebus.aio import ServiceBusClient
17-
from azure.servicebus import ReceiveSettleMode
1817

1918
CONNECTION_STR = os.environ['SERVICE_BUS_CONNECTION_STR']
2019
QUEUE_NAME = os.environ["SERVICE_BUS_QUEUE_NAME"]

sdk/servicebus/azure-servicebus/samples/async_samples/session_pool_receive_async.py

Lines changed: 6 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -4,24 +4,26 @@
44
# Copyright (c) Microsoft Corporation. All rights reserved.
55
# Licensed under the MIT License. See License.txt in the project root for license information.
66
# --------------------------------------------------------------------------------------------
7-
7+
import os
88
import asyncio
99
import uuid
1010

1111
from azure.servicebus.aio import ServiceBusClient, AutoLockRenew
12-
from azure.servicebus import NoActiveSession, Message
12+
from azure.servicebus import Message
13+
from azure.servicebus.exceptions import NoActiveSession
1314

1415

1516
CONNECTION_STR = os.environ['SERVICE_BUS_CONNECTION_STR']
1617
# Note: This must be a session-enabled queue.
1718
QUEUE_NAME = os.environ["SERVICE_BUS_QUEUE_NAME"]
1819

20+
1921
async def message_processing(servicebus_client, queue_name):
2022
while True:
2123
try:
2224
async with servicebus_client.get_queue_session_receiver(queue_name, idle_timeout=1) as receiver:
2325
renewer = AutoLockRenew()
24-
renewer.register(receiver.session, timeout=None)
26+
renewer.register(receiver.session)
2527
await receiver.session.set_session_state("OPEN")
2628
async for message in receiver:
2729
print("Message: {}".format(message))
@@ -37,7 +39,7 @@ async def message_processing(servicebus_client, queue_name):
3739
if str(message) == 'shutdown':
3840
await receiver.session.set_session_state("CLOSED")
3941
break
40-
renewer.shutdown()
42+
await renewer.shutdown()
4143
except NoActiveSession:
4244
print("There are no non-empty sessions remaining; exiting. This may present as a UserError in the azure portal.")
4345
return

sdk/servicebus/azure-servicebus/samples/async_samples/session_send_receive_async.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -6,7 +6,7 @@
66
# --------------------------------------------------------------------------------------------
77

88
"""
9-
Example to show sending message(s) to and receiving messages from a Service Bus Queue with session enabled. asynchronously.
9+
Example to show sending message(s) to and receiving messages from a Service Bus Queue with session enabled asynchronously.
1010
"""
1111

1212
# pylint: disable=C0111

sdk/servicebus/azure-servicebus/samples/sync_samples/session_pool_receive.py

Lines changed: 4 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -4,23 +4,24 @@
44
# Copyright (c) Microsoft Corporation. All rights reserved.
55
# Licensed under the MIT License. See License.txt in the project root for license information.
66
# --------------------------------------------------------------------------------------------
7-
7+
import os
88
import uuid
99
import concurrent
1010

1111
from azure.servicebus import ServiceBusClient, Message, AutoLockRenew
12-
from azure.servicebus import NoActiveSession
12+
from azure.servicebus.exceptions import NoActiveSession
1313

1414
CONNECTION_STR = os.environ['SERVICE_BUS_CONNECTION_STR']
1515
# Note: This must be a session-enabled queue.
1616
QUEUE_NAME = os.environ["SERVICE_BUS_QUEUE_NAME"]
1717

18+
1819
def message_processing(sb_client, queue_name, messages):
1920
while True:
2021
try:
2122
with sb_client.get_queue_session_receiver(queue_name, idle_timeout=1) as receiver:
2223
renewer = AutoLockRenew()
23-
renewer.register(receiver.session, timeout=None)
24+
renewer.register(receiver.session)
2425
receiver.session.set_session_state("OPEN")
2526
for message in receiver:
2627
messages.append(message)

0 commit comments

Comments
 (0)