Fix tests and url

Signed-off-by: Paul Van Eck <paulvaneck@microsoft.com>

Author: pvaneck

sdk/identity/azure-identity/azure/identity/_credentials/azure_pipelines.py

@@ -24,7 +24,7 @@ def build_oidc_request(service_connection_id: str) -> HttpRequest:
     base_uri = os.environ[ev.SYSTEM_TEAMFOUNDATIONCOLLECTIONURI].rstrip("/")
     url = (
         f"{base_uri}/{os.environ[ev.SYSTEM_TEAMPROJECTID]}/_apis/distributedtask/hubs/build/plans/"
-        f"{os.environ[ev.SYSTEM_PLANID]}/jobs/{os.environ[ev.SYSTEM_JOBID]}/oidctoken"
+        f"{os.environ[ev.SYSTEM_PLANID]}/jobs/{os.environ[ev.SYSTEM_JOBID]}/oidctoken?"
         f"api-version={OIDC_API_VERSION}&serviceConnectionId={service_connection_id}"
     )
     access_token = os.environ[ev.SYSTEM_ACCESSTOKEN]

sdk/identity/azure-identity/tests/test_azure_pipelines_credential.py

@@ -91,13 +91,15 @@ def test_azure_pipelines_credential_missing_env_var():
 def test_azure_pipelines_credential_in_chain():
     mock_credential = MagicMock()
 
-    chain_credential = ChainedTokenCredential(
-        AzurePipelinesCredential(tenant_id="tenant-id", client_id="client-id", service_connection_id="connection-id"),
-        mock_credential,
-    )
-
-    chain_credential.get_token("scope")
-    assert mock_credential.get_token.called
+    with patch.dict("os.environ", {}, clear=True):
+        chain_credential = ChainedTokenCredential(
+            AzurePipelinesCredential(
+                tenant_id="tenant-id", client_id="client-id", service_connection_id="connection-id"
+            ),
+            mock_credential,
+        )
+        chain_credential.get_token("scope")
+        assert mock_credential.get_token.called
 
 
 @pytest.mark.live_test_only("Requires Azure Pipelines environment with configured service connection")

sdk/identity/azure-identity/tests/test_azure_pipelines_credential_async.py

@@ -65,13 +65,15 @@ async def test_azure_pipelines_credential_missing_env_var():
 async def test_azure_pipelines_credential_in_chain():
     mock_credential = AsyncMock()
 
-    chain_credential = ChainedTokenCredential(
-        AzurePipelinesCredential(tenant_id="tenant-id", client_id="client-id", service_connection_id="connection-id"),
-        mock_credential,
-    )
-
-    await chain_credential.get_token("scope")
-    assert mock_credential.get_token.called
+    with patch.dict("os.environ", {}, clear=True):
+        chain_credential = ChainedTokenCredential(
+            AzurePipelinesCredential(
+                tenant_id="tenant-id", client_id="client-id", service_connection_id="connection-id"
+            ),
+            mock_credential,
+        )
+        await chain_credential.get_token("scope")
+        assert mock_credential.get_token.called
 
 
 @pytest.mark.asyncio