[Identity] Adjust log level for EnvCred warning (#31814)

If within a DAC, use log level WARNING instead of INFO when
paritial envionment variables are set. The warning can sometimes be
interpreted as an error by the user.

Signed-off-by: Paul Van Eck <paulvaneck@microsoft.com>

Author: pvaneck

sdk/identity/azure-identity/CHANGELOG.md

@@ -17,6 +17,7 @@
 ### Other Changes
 
 - Update typing of async credentials to match the `AsyncTokenCredential` protocol.
+- If within `DefaultAzureCredential`, `EnvironmentCredential` will now use log level INFO instead of WARNING to inform users of an incomplete environment configuration.  ([#31814](https://github.com/Azure/azure-sdk-for-python/pull/31814))
 
 ## 1.14.0 (2023-08-08)
 

sdk/identity/azure-identity/azure/identity/_credentials/default.py

@@ -146,7 +146,7 @@ def __init__(self, **kwargs: Any) -> None:  # pylint: disable=too-many-statement
 
         credentials: List["TokenCredential"] = []
         if not exclude_environment_credential:
-            credentials.append(EnvironmentCredential(authority=authority, **kwargs))
+            credentials.append(EnvironmentCredential(authority=authority, _within_dac=True, **kwargs))
         if not exclude_workload_identity_credential:
             if all(os.environ.get(var) for var in EnvironmentVariables.WORKLOAD_IDENTITY_VARS):
                 client_id = workload_identity_client_id

sdk/identity/azure-identity/azure/identity/_credentials/environment.py

@@ -100,8 +100,10 @@ def __init__(self, **kwargs: Any) -> None:
             )
             set_variables = [v for v in expected_variables if v in os.environ]
             if set_variables:
-                _LOGGER.warning(
-                    "Incomplete environment configuration. These variables are set: %s", ", ".join(set_variables)
+                _LOGGER.log(
+                    logging.INFO if kwargs.get("_within_dac") else logging.WARNING,
+                    "Incomplete environment configuration for EnvironmentCredential. These variables are set: %s",
+                    ", ".join(set_variables),
                 )
             else:
                 _LOGGER.info("No environment configuration found.")

sdk/identity/azure-identity/azure/identity/aio/_credentials/default.py

@@ -136,7 +136,7 @@ def __init__(self, **kwargs: Any) -> None:
 
         credentials = []  # type: List[AsyncTokenCredential]
         if not exclude_environment_credential:
-            credentials.append(EnvironmentCredential(authority=authority, **kwargs))
+            credentials.append(EnvironmentCredential(authority=authority, _within_dac=True, **kwargs))
         if not exclude_workload_identity_credential:
             if all(os.environ.get(var) for var in EnvironmentVariables.WORKLOAD_IDENTITY_VARS):
                 client_id = workload_identity_client_id

sdk/identity/azure-identity/azure/identity/aio/_credentials/environment.py

@@ -75,8 +75,10 @@ def __init__(self, **kwargs: Any) -> None:
             expected_variables = set(EnvironmentVariables.CERT_VARS + EnvironmentVariables.CLIENT_SECRET_VARS)
             set_variables = [v for v in expected_variables if v in os.environ]
             if set_variables:
-                _LOGGER.warning(
-                    "Incomplete environment configuration. These variables are set: %s", ", ".join(set_variables)
+                _LOGGER.log(
+                    logging.INFO if kwargs.get("_within_dac") else logging.WARNING,
+                    "Incomplete environment configuration for EnvironmentCredential. These variables are set: %s",
+                    ", ".join(set_variables),
                 )
             else:
                 _LOGGER.info("No environment configuration found.")