Skip to content

Commit daa7573

Browse files
authored
optimize change_log (#24252)
* optimize change_log * Update change_log.py * Update code_report.py * Update code_report.py * Update code_report.py * Update code_report.py * Update code_report.py
1 parent d4d93d7 commit daa7573

2 files changed

Lines changed: 13 additions & 1 deletion

File tree

tools/azure-sdk-tools/packaging_tools/change_log.py

Lines changed: 6 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -144,6 +144,9 @@ def models(self, diff_entry):
144144
self.breaking_changes.append(_MODEL_PARAM_CHANGE_REQUIRED.format(parameter_name, model_name))
145145
return
146146

147+
def client(self):
148+
self.breaking_changes.append(_CLIENT_SIGNATURE_CHANGE)
149+
return
147150

148151
## Features
149152
_ADD_OPERATION_GROUP = "Added operation group {}"
@@ -156,6 +159,7 @@ def models(self, diff_entry):
156159
_REMOVE_OPERATION_GROUP = "Removed operation group {}"
157160
_REMOVE_OPERATION = "Removed operation {}.{}"
158161
_REMOVE_OPERATION_PARAM = "Operation {}.{} no longer has parameter {}"
162+
_CLIENT_SIGNATURE_CHANGE = "Client name is changed"
159163
_MODEL_SIGNATURE_CHANGE = "Model {} has a new signature"
160164
_MODEL_PARAM_DELETE = "Model {} no longer has parameter {}"
161165
_MODEL_PARAM_ADD_REQUIRED = "Model {} has a new required parameter {}"
@@ -174,6 +178,8 @@ def build_change_log(old_report, new_report):
174178
change_log.operation(diff_line)
175179
else:
176180
change_log.models(diff_line)
181+
if diff_line[0][0] == 'client':
182+
change_log.client()
177183

178184
return change_log
179185

tools/azure-sdk-tools/packaging_tools/code_report.py

Lines changed: 7 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -37,14 +37,20 @@ def parse_input(input_parameter):
3737

3838

3939
def create_empty_report():
40-
return {"models": {"enums": {}, "exceptions": {}, "models": {}}, "operations": {}}
40+
return {"client": {}, "models": {"enums": {}, "exceptions": {}, "models": {}}, "operations": {}}
4141

4242

4343
def create_report(module_name: str) -> Dict[str, Any]:
4444
module_to_generate = importlib.import_module(module_name)
45+
client_name = getattr(module_to_generate, '__all__')
4546

4647
report = create_empty_report()
4748

49+
try:
50+
report["client"] = client_name
51+
except:
52+
report["client"] = []
53+
4854
# Look for models first
4955
model_names = [model_name for model_name in dir(module_to_generate.models) if model_name[0].isupper()]
5056
for model_name in model_names:

0 commit comments

Comments
 (0)