Skip to content

Commit 13fc5bd

Browse files
Don't use Caching (#8799)
1 parent ab1eacb commit 13fc5bd

3 files changed

Lines changed: 6 additions & 19 deletions

File tree

src/dotnet/APIView/APIViewWeb/LeanControllers/ReviewsController.cs

Lines changed: 3 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -11,8 +11,6 @@
1111
using Microsoft.Extensions.Configuration;
1212
using APIViewWeb.Hubs;
1313
using Microsoft.AspNetCore.SignalR;
14-
using System.Diagnostics;
15-
using System;
1614
using Microsoft.AspNetCore.Hosting;
1715
using Microsoft.Extensions.Hosting;
1816
using System.Collections.Generic;
@@ -139,7 +137,7 @@ public async Task<ActionResult<CodePanelData>> GetReviewContentAsync(string revi
139137
{
140138
var comments = await _commentsManager.GetCommentsAsync(reviewId);
141139

142-
var activeRevisionReviewCodeFile = await _codeFileRepository.GetCodeFileWithCompressionAsync(activeAPIRevision.Id, activeAPIRevision.Files[0].FileId, _env.IsProduction());
140+
var activeRevisionReviewCodeFile = await _codeFileRepository.GetCodeFileWithCompressionAsync(revisionId: activeAPIRevision.Id, codeFileId: activeAPIRevision.Files[0].FileId);
143141

144142
var result = new CodePanelData();
145143

@@ -154,7 +152,8 @@ public async Task<ActionResult<CodePanelData>> GetReviewContentAsync(string revi
154152
if (!string.IsNullOrEmpty(diffApiRevisionId))
155153
{
156154
var diffAPIRevision = await _apiRevisionsManager.GetAPIRevisionAsync(User, diffApiRevisionId);
157-
var diffRevisionReviewCodeFile = await _codeFileRepository.GetCodeFileWithCompressionAsync(diffAPIRevision.Id, diffAPIRevision.Files[0].FileId, _env.IsProduction());
155+
156+
var diffRevisionReviewCodeFile = await _codeFileRepository.GetCodeFileWithCompressionAsync(revisionId: diffAPIRevision.Id, codeFileId: diffAPIRevision.Files[0].FileId);
158157
codePanelRawData.APIForest = CodeFileHelpers.ComputeAPIForestDiff(diffRevisionReviewCodeFile.APIForest, activeRevisionReviewCodeFile.APIForest);
159158
}
160159

src/dotnet/APIView/APIViewWeb/Repositories/BlobCodeFileRepository.cs

Lines changed: 2 additions & 14 deletions
Original file line numberDiff line numberDiff line change
@@ -57,23 +57,11 @@ public async Task<RenderedCodeFile> GetCodeFileAsync(string revisionId, APICodeF
5757
return codeFile;
5858
}
5959

60-
public async Task<CodeFile> GetCodeFileWithCompressionAsync(string revisionId, string codeFileId, bool updateCache = true)
60+
public async Task<CodeFile> GetCodeFileWithCompressionAsync(string revisionId, string codeFileId)
6161
{
6262
var client = GetBlobClient(revisionId, codeFileId, out var key);
63-
64-
if (_cache.TryGetValue<CodeFile>(key, out var codeFile))
65-
{
66-
return codeFile;
67-
}
6863
var info = await client.DownloadAsync();
69-
codeFile = await CodeFile.DeserializeAsync(info.Value.Content, doTreeStyleParserDeserialization: true);
70-
if (updateCache)
71-
{
72-
using var _ = _cache.CreateEntry(key)
73-
.SetSlidingExpiration(TimeSpan.FromMinutes(10))
74-
.SetValue(codeFile);
75-
}
76-
return codeFile;
64+
return await CodeFile.DeserializeAsync(info.Value.Content, doTreeStyleParserDeserialization: true);
7765
}
7866

7967
public async Task UpsertCodeFileAsync(string revisionId, string codeFileId, CodeFile codeFile)

src/dotnet/APIView/APIViewWeb/Repositories/Interfaces/IBlobCodeFileRepository.cs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -10,7 +10,7 @@ public interface IBlobCodeFileRepository
1010
{
1111
public Task<RenderedCodeFile> GetCodeFileAsync(APIRevisionListItemModel revision, bool updateCache = true);
1212
public Task<RenderedCodeFile> GetCodeFileAsync(string revisionId, APICodeFileModel apiCodeFile, string language, bool updateCache = true);
13-
public Task<CodeFile> GetCodeFileWithCompressionAsync(string revisionId, string codeFileId, bool updateCache = true);
13+
public Task<CodeFile> GetCodeFileWithCompressionAsync(string revisionId, string codeFileId);
1414
public Task UpsertCodeFileAsync(string revisionId, string codeFileId, CodeFile codeFile);
1515
public Task DeleteCodeFileAsync(string revisionId, string codeFileId);
1616
}

0 commit comments

Comments
 (0)