Remove Docker Support (#7896)

* remove docker cli integration as we will not be maintaining the docker configurations for test-proxy
* remove all references to docker in readme

Author: scbedd

eng/common/testproxy/onboarding/common-asset-functions.ps1

@@ -207,41 +207,6 @@ Function Invoke-ProxyCommand {
   )
   $updatedDirectory = $TargetDirectory.Replace("`\", "/")
 
-  # CommandString just a string indicating the proxy arguments. In the default case of running against the proxy tool, can just be used directly.
-  # However, in the case of docker, we need to append a bunch more arguments to the string.
-  if ($TestProxyExe -eq "docker" -or $TestProxyExe -eq "podman"){
-    $token = $env:GIT_TOKEN
-    $committer = $env:GIT_COMMIT_OWNER
-    $email = $env:GIT_COMMIT_EMAIL
-
-    if (-not $committer) {
-      $committer = & git config --global user.name
-    }
-
-    if (-not $email) {
-      $email = & git config --global user.email
-    }
-
-    if(-not $token -or -not $committer -or -not $email){
-      Write-Error ("When running this transition script in `"docker`" or `"podman`" mode, " `
-        + "the environment variables GIT_TOKEN, GIT_COMMIT_OWNER, and GIT_COMMIT_EMAIL must be set to reflect the appropriate user. ")
-        exit 1
-    }
-
-    $targetImage = if ($env:TRANSITION_SCRIPT_DOCKER_TAG) { $env:TRANSITION_SCRIPT_DOCKER_TAG } else { "azsdkengsys.azurecr.io/engsys/test-proxy:latest" }
-
-    $CommandString = @(
-      "run --rm --name transition.test.proxy",
-      "-v `"${updatedDirectory}:/srv/testproxy`"",
-      "-e `"GIT_TOKEN=${token}`"",
-      "-e `"GIT_COMMIT_OWNER=${committer}`"",
-      "-e `"GIT_COMMIT_EMAIL=${email}`"",
-      $targetImage,
-      "test-proxy",
-      $CommandString
-    ) -join " "
-  }
-
   Write-Host "$TestProxyExe $CommandString"
   [array] $output = & "$TestProxyExe" $CommandString.Split(" ") --storage-location="$updatedDirectory"
   # echo the command output

eng/common/testproxy/onboarding/generate-assets-json.ps1

@@ -22,9 +22,9 @@ Generated assets.json file contents
 If flag InitialPush is set, recordings will be automatically pushed to the assets repo and the Tag property updated.
 
 .PARAMETER TestProxyExe
-The executable used during the "InitialPush" action. Defaults to the dotnet tool test-proxy, but also supports "docker" or "podman".
+The executable used during the "InitialPush" action. Defaults to the dotnet tool test-proxy, but also supports custom executables as well.
 
-If the user provides their own value that doesn't match options "test-proxy", "docker", or "podman", the script will use this input as the test-proxy exe
+If the user provides their own value that doesn't match options "test-proxy" the script will use this input as the test-proxy exe
 when invoking commands. EG "$TestProxyExe push -a sdk/keyvault/azure-keyvault-keys/assets.json."
 
 .PARAMETER InitialPush

tools/test-proxy/Azure.Sdk.Tools.TestProxy/README.md

@@ -16,11 +16,8 @@ to documentation in your specific language repository in order to configure reco
 
 - [Azure SDK Tools Test Proxy](#azure-sdk-tools-test-proxy)
       - [Test documentation by language:](#test-documentation-by-language)
-  - [Table of contents](#table-of-contents)
   - [Installation](#installation)
     - [Via Local Compile or .NET](#via-local-compile-or-net)
-    - [Via Docker Image](#via-docker-image)
-      - [A note about docker caching](#a-note-about-docker-caching)
     - [Via Standalone Executable](#via-standalone-executable)
       - [Which should I install?](#which-should-i-install)
   - [Command line arguments](#command-line-arguments)
@@ -62,10 +59,6 @@ to documentation in your specific language repository in order to configure reco
       - [Providing your own `Host` header](#providing-your-own-host-header)
   - [Testing](#testing)
   - [SSL Support](#ssl-support)
-    - [On Mac and Windows, .NET can be used to generate a local certificate](#on-mac-and-windows-net-can-be-used-to-generate-a-local-certificate)
-      - [Option 1](#option-1)
-      - [Option 2](#option-2)
-    - [Docker Image + SSL](#docker-image--ssl)
   - [Troubleshooting](#troubleshooting)
     - [Visual studio](#visual-studio)
       - [ASP.NET and web development](#aspnet-and-web-development)
@@ -101,7 +94,7 @@ dotnet tool update azure.sdk.tools.testproxy --global --add-source https://pkgs.
 
 The test-proxy is also available from the [azure-sdk-for-net public feed](https://dev.azure.com/azure-sdk/public/_artifacts/feed/azure-sdk-for-net)
 
-_Note: if you're not authorized to access these feeds, make sure you have [Azure Artifacts Credential Provider](https://github.com/microsoft/artifacts-credprovider) installed. You can also [download executable](#via-standalone-executable) or use a prebuilt [docker image](#via-docker-image)._
+_Note: if you're not authorized to access these feeds, make sure you have [Azure Artifacts Credential Provider](https://github.com/microsoft/artifacts-credprovider) installed. You can also [download executable](#via-standalone-executable)._
 
 To uninstall an existing test-proxy
 
@@ -121,40 +114,6 @@ If you've already installed the tool, you can always check the installed version
 test-proxy --version
 ```
 
-### Via Docker Image
-
-The Azure SDK Team maintains a public Azure Container Registry.
-
-```powershell
-docker run -v <your-volume-name-or-location>:/srv/testproxy/ -p 5001:5001 -p 5000:5000 azsdkengsys.azurecr.io/engsys/test-proxy:latest
-```
-
-For example, to save test recordings to disk in your repo's `/sdk/<service>/tests/recordings` directory, provide the path to the root of the repo:
-
-```powershell
-docker run -v C:\\repo\\azure-sdk-for-<language>:/srv/testproxy/ -p 5001:5001 -p 5000:5000 azsdkengsys.azurecr.io/engsys/test-proxy:latest
-```
-
-Note the **port and volume mapping** as arguments! Any files that exist in this volume locally will only be appended to/updated in place. It is a non-destructive initialize.
-
-Within the container, recording outputs are written within the directory `/srv/testproxy/`.
-
-NOTE: if you are authenticated to github via SSH keys instead of a credential manager with https, you must mount your ssh credentials into docker. The following command shows an example mounting the default ssh key ~/.ssh/id_rsa on linux:
-
-```bash
-docker run -v /home/ben/.ssh:/root/.ssh -v /home/ben/sdk/azure-sdk-for-go:/srv/testproxy --add-host=host.docker.internal:host-gateway -p 5001:5001 -p 5000:5000 testproxy bash -c 'eval `ssh-agent` && ssh-add /root/.ssh/id_rsa && test-proxy start --dump'
-```
-
-#### A note about docker caching
-
-The azure-sdk team regularly update the image associated with the `latest` tag. Combined with the fact that docker will aggressively cache if possible, it is very possible that developers' local machines may be running outdated versions of the test-proxy.
-
-To ensure that your local copy is up to date, run:
-
-```powershell
-docker pull azsdkengsys.azurecr.io/engsys/test-proxy:latest
-```
-
 ### Via Standalone Executable
 
 Standalone executable versions of the test-proxy are published to [github releases on this repository.](https://github.com/Azure/azure-sdk-tools/releases?q=Azure.Sdk.Tools.TestProxy&expanded=true)
@@ -286,7 +245,6 @@ The test-proxy is integrated with the following environment variables.
 | `Logging__LogLevel__Default` | Defaults to `Information`. Possible valid values are <br/><br/>`Debug`, `Information`, `Warning`, `Error`, `Critical`.<br><br>Do not set for .NET test runs as it would cause the tests *themselves* to start emitting logs.|
 | `Logging__LogLevel__Azure.Sdk.Tools.TestProxy`| Set to `Debug` to see request level logs emitted by the Test Proxy.|
 
-Both of the above variables can be set in the `docker` runtime by providing additional arguments EG: `docker run -e Logging__LogLevel__Default=Warning azsdkengsys.azurecr.io/engsys/test-proxy:latest`. For multiple environment variables, just use multiple `-e` provisions.
 
 ## How do I use the test-proxy to get a recording?
 
@@ -312,7 +270,6 @@ A couple notes before running the test-proxy:
 
 - Reference [command line arguments](#command-line-arguments) and understand the options.
 - The test-proxy runs in a "context" which is just a directory on your disk. When initializing a recording, all paths should be relative to this context directory.
-- If running the proxy as a docker image, ensure you **map** `etc/testproxy/` to a target context directory on your drive. In the example `docker run` invocations above, look for the `-v` argument.
 
 ### Where will my recordings end up?
 
@@ -789,36 +746,6 @@ Within this repository there is a single certificate.
 
 - `eng/common/testproxy/dotnet-devcert.pfx`: generated on a `Ubuntu` distribution using `openssl`.
 
-Unfortunately, the `dotnet dev-certs` generated certificates are _not_ acceptable to a standard ubuntu distro. The issue is that the `KeyUsage` field in the `.crt` [MUST contain](https://github.com/dotnet/aspnetcore/issues/7246#issuecomment-541165030) the `keyCertSign` flag. Certificates generated by `dotnet dev-certs` do NOT have this flag. This means that if you're on Windows AND running the Ubuntu docker image, you will need to trust the `dotnet-devcert.pfx` locally prior to `docker run`.
-
-For further details on importing and using the provided dev-certificates, please investigate the [additional docker readme.](../docker/README.md)
-
-### On Mac and Windows, .NET can be used to generate a local certificate
-
-There are two options here, generate your own SSL Cert, or import an existing one.
-
-#### Option 1
-
-Invoke the command:
-
-```powershell
-dotnet dev-certs https --trust
-```
-
-This will be automatically retrieved if you run the nuget installed version of the tool. You may optionally use `openssl` [like so](https://raw.githubusercontent.com/BorisWilhelms/create-dotnet-devcert/f3b5da6f9107834eb31ea5ba7c0583e14cda6b31/create-dotnet-devcert.sh) to generate a certificate. Note that this shell script creates a dev cert that is compatible with ubuntu.
-
-#### Option 2
-
-Import the appropriate already existing certificate within the `eng/common/testproxy/` folder.
-
-### Docker Image + SSL
-
-To connect to the docker on SSL, both the docker image and your local machine must trust the same SSL cert. The docker image already has `dotnet-devcert.pfx` imported and trusted, so all that is necessary is to trust that same cert prior to `docker run`.
-
-In the future, passing in a custom cert via a bound volume that contains your certificate will be a possibility as well.
-
-For additional reading on this process for trusting SSL certs locally, feel free to read up [here.](https://devblogs.microsoft.com/aspnet/configuring-https-in-asp-net-core-across-different-platforms/) The afore-mentioned [docker specific readme](../docker/README.md) also has details that are relevant.
-
 ## Troubleshooting
 
 ### Visual studio

tools/test-proxy/ci.yml

@@ -25,30 +25,6 @@ extends:
   template: /eng/pipelines/templates/stages/archetype-sdk-tool-dotnet.yml
   parameters:
     ToolDirectory: tools/test-proxy
-    DockerTagPrefix: '1.0.0-dev.'
-    DockerDeployments:
-    - name: test_proxy_linux
-      pool: azsdk-pool-mms-ubuntu-2204-general
-      vmImage: ubuntu-22.04
-      dockerRepo: 'engsys/testproxy-lin'
-      prepareScript: tools/test-proxy/docker/prepare.ps1
-      dockerFile: 'tools/test-proxy/docker/dockerfile'
-      stableTags:
-      - 'latest'
-    - name: test_proxy_linux_arm64
-      pool: azsdk-pool-mms-ubuntu-2204-general
-      vmImage: ubuntu-22.04
-      dockerRepo: 'engsys/testproxy-lin-arm64'
-      prepareScript: 'tools/test-proxy/docker/prepare.ps1 -qemu'
-      additionalDockerArgs: '--build-arg ARCH=-arm64v8 --platform linux/arm64'
-      dockerFile: 'tools/test-proxy/docker/dockerfile'
-      stableTags:
-      - 'latest'
-    ManifestDeployment:
-    - name: 'test_proxy_multiarch'
-      dockerRepo: 'engsys/test-proxy'
-      stableTags:
-      - 'latest'
     ReleaseBinaries: true
     StandaloneExeMatrix:
     - rid: osx-x64