Refactored POST method

Whitney Shake · Whitney Shake · commit 450435f06193 · 2024-07-08T20:24:02.000-04:00
diff --git a/src/dotnet/APIView/APIViewWeb/LeanControllers/APIRevisionsController.cs b/src/dotnet/APIView/APIViewWeb/LeanControllers/APIRevisionsController.cs
@@ -129,9 +129,10 @@ public async Task<ActionResult<APIRevisionListItemModel>> ToggleReviewApprovalAs
         public async Task<ActionResult<APIRevisionListItemModel>> AddReviewersAsync(string reviewId, string apiRevisionId, [FromBody] HashSet<string> reviewers)
         {
             var apiRevision = await _apiRevisionsManager.GetAPIRevisionAsync(apiRevisionId);
-            var existingReviewers = apiRevision.AssignedReviewers;
-            var newReviewers = reviewers.Where(reviewer => !existingReviewers.Any(existingReviewer => existingReviewer.AssingedTo == reviewer)).ToHashSet();
-            var removedReviewers = existingReviewers.Where(existingReviewer => !reviewers.Contains(existingReviewer.AssingedTo)).Select(r => r.AssingedTo).ToHashSet();
+            var existingReviewers = new HashSet<string>(apiRevision.AssignedReviewers.Select(r => r.AssingedTo));
+
+            var newReviewers = new HashSet<string>(reviewers.Except(existingReviewers));
+            var removedReviewers = new HashSet<string>(existingReviewers.Except(reviewers));
 
             if (newReviewers.Any())
             {

Original file line number	Diff line number	Diff line change
`@@ -129,9 +129,10 @@ public async Task<ActionResult<APIRevisionListItemModel>> ToggleReviewApprovalAs`
`129`	`129`	`public async Task<ActionResult<APIRevisionListItemModel>> AddReviewersAsync(string reviewId, string apiRevisionId, [FromBody] HashSet<string> reviewers)`
`130`	`130`	`{`
`131`	`131`	`var apiRevision = await _apiRevisionsManager.GetAPIRevisionAsync(apiRevisionId);`
`132`		`- var existingReviewers = apiRevision.AssignedReviewers;`
`133`		`- var newReviewers = reviewers.Where(reviewer => !existingReviewers.Any(existingReviewer => existingReviewer.AssingedTo == reviewer)).ToHashSet();`
`134`		`- var removedReviewers = existingReviewers.Where(existingReviewer => !reviewers.Contains(existingReviewer.AssingedTo)).Select(r => r.AssingedTo).ToHashSet();`
	`132`	`+ var existingReviewers = new HashSet<string>(apiRevision.AssignedReviewers.Select(r => r.AssingedTo));`
	`133`	`+`
	`134`	`+ var newReviewers = new HashSet<string>(reviewers.Except(existingReviewers));`
	`135`	`+ var removedReviewers = new HashSet<string>(existingReviewers.Except(reviewers));`
`135`	`136`
`136`	`137`	`if (newReviewers.Any())`
`137`	`138`	`{`