Skip to content

Commit 833269c

Browse files
Disable Review Approval Button for non-prefered approvers (#8640)
1 parent 5e2bb10 commit 833269c

1 file changed

Lines changed: 6 additions & 6 deletions

File tree

src/dotnet/APIView/ClientSPA/src/app/_components/review-page-options/review-page-options.component.html

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -27,12 +27,7 @@
2727
</ng-template>
2828
</li>
2929
<li class="list-group-item text-center">
30-
<ng-container *ngIf="reviewIsApproved; else reviewIsNotApprovedBlock">
31-
<span class="small text-muted mt-1">
32-
Approved for First Release By: <a href="{{webAppUrl}}Assemblies/Profile/{{reviewApprover}}">{{reviewApprover}}</a>
33-
</span>
34-
</ng-container>
35-
<ng-template #reviewIsNotApprovedBlock>
30+
<ng-container *ngIf="!reviewIsApproved && preferredApprovers.includes(userProfile?.userName!); else reviewApprovalHidden">
3631
<span class="small text-muted">Approves First Release of the package</span>
3732
<div class="d-grid gap-2">
3833
<button class="btn btn-success" type="button"
@@ -43,6 +38,11 @@
4338
</button>
4439
</div>
4540
<span class="small mt-2 text-muted">First Release Approval Pending</span>
41+
</ng-container>
42+
<ng-template #reviewApprovalHidden>
43+
<span class="small text-muted mt-1">
44+
Approved for First Release By: <a href="{{webAppUrl}}Assemblies/Profile/{{reviewApprover}}">{{reviewApprover}}</a>
45+
</span>
4646
</ng-template>
4747
</li>
4848
</ul>

0 commit comments

Comments
 (0)