Skip to content

Commit 00d9bd4

Browse files
[Bugfix] Update local tile aspect ratio and fix CallWithChat flashing with scrollable gallery (#2734) (#2736)
* set height for tiles to maintain aspect * add enforced width to the CallComposite container * Change files * Duplicate change files for beta release * Update packages/react-composites CallWithChatComposite browser test snapshots * Update packages/react-composites CallWithChatComposite browser test snapshots * Update packages/react-composites CallComposite browser test snapshots * Update packages/react-composites CallComposite browser test snapshots --------- Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
1 parent 5be21c4 commit 00d9bd4

64 files changed

Lines changed: 19 additions & 3 deletions

File tree

Some content is hidden

Large Commits have some content hidden by default. Use the searchbox below for content that may be hidden.
Lines changed: 7 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,7 @@
1+
{
2+
"type": "prerelease",
3+
"comment": "Updates LocalVideo tile to be 9:16 aspect ratio to show whole feed. fixes CallWithChat flashing issue with scrollable gallery.",
4+
"packageName": "@azure/communication-react",
5+
"email": "94866715+dmceachernmsft@users.noreply.github.com",
6+
"dependentChangeType": "patch"
7+
}
Lines changed: 7 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,7 @@
1+
{
2+
"type": "prerelease",
3+
"comment": "Updates LocalVideo tile to be 9:16 aspect ratio to show whole feed. fixes CallWithChat flashing issue with scrollable gallery.",
4+
"packageName": "@azure/communication-react",
5+
"email": "94866715+dmceachernmsft@users.noreply.github.com",
6+
"dependentChangeType": "patch"
7+
}

packages/react-components/src/components/VideoGallery/styles/FloatingLocalVideo.styles.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -30,7 +30,7 @@ export const videoGalleryContainerStyle: IStackStyles = {
3030
/**
3131
* Small floating modal width and height in rem for small screen
3232
*/
33-
export const SMALL_FLOATING_MODAL_SIZE_PX = { width: 64, height: 88 };
33+
export const SMALL_FLOATING_MODAL_SIZE_PX = { width: 58, height: 104 };
3434

3535
/**
3636
* Large floating modal width and height in rem for large screen

packages/react-components/src/components/VideoGallery/styles/VideoGalleryResponsiveHorizontalGallery.styles.ts

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -36,7 +36,8 @@ export const horizontalGalleryStyle = (isNarrow: boolean): HorizontalGalleryStyl
3636
* Small horizontal gallery tile size in rem
3737
* @private
3838
*/
39-
export const SMALL_HORIZONTAL_GALLERY_TILE_SIZE_REM = { height: 5.5, width: 5.5 };
39+
export const SMALL_HORIZONTAL_GALLERY_TILE_SIZE_REM = { height: 6.5, width: 6.5 };
40+
4041
/**
4142
* Large horizontal gallery tile size in rem
4243
* @private

packages/react-composites/src/composites/CallWithChatComposite/styles/CallWithChatCompositeStyles.ts

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -20,7 +20,8 @@ export const callCompositeContainerStyles: IStackStyles = {
2020
root: {
2121
// Start a new stacking context so that any `position:absolute` elements
2222
// inside the call composite do not compete with its siblings.
23-
position: 'relative'
23+
position: 'relative',
24+
width: '100%'
2425
}
2526
};
2627

0 commit comments

Comments
 (0)