Skip to content

Commit 02420bf

Browse files
authored
Fix bug where there are duplicate captions (#4534)
* fix bug * Change files
1 parent e907045 commit 02420bf

3 files changed

Lines changed: 19 additions & 1 deletion

File tree

Lines changed: 9 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,9 @@
1+
{
2+
"type": "patch",
3+
"area": "fix",
4+
"workstream": "Captions",
5+
"comment": "Fix bug when there are duplicate captions",
6+
"packageName": "@azure/communication-react",
7+
"email": "96077406+carocao-msft@users.noreply.github.com",
8+
"dependentChangeType": "patch"
9+
}
Lines changed: 9 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,9 @@
1+
{
2+
"type": "patch",
3+
"area": "fix",
4+
"workstream": "Captions",
5+
"comment": "Fix bug when there are duplicate captions",
6+
"packageName": "@azure/communication-react",
7+
"email": "96077406+carocao-msft@users.noreply.github.com",
8+
"dependentChangeType": "patch"
9+
}

packages/calling-component-bindings/src/captionsSelector.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -110,7 +110,7 @@ export const _captionsBannerSelector: _CaptionsBannerSelector = reselect.createS
110110
const captionsInfo = captions?.map((c, index) => {
111111
const userId = getCaptionsSpeakerIdentifier(c);
112112
return {
113-
id: c.speaker.displayName ?? 'Unnamed Participant' + index,
113+
id: (c.speaker.displayName ?? 'Unnamed Participant') + index,
114114
displayName: c.speaker.displayName ?? 'Unnamed Participant',
115115
captionText: c.captionText ?? '',
116116
userId

0 commit comments

Comments
 (0)