Skip to content

Commit 0cf8bb3

Browse files
dmceachernmsftcarocao-msft
authored andcommitted
[A11y bugfix] Fix video effects pane tab ordering on call screen (#3351)
* add focus zones * Change files * Duplicate change files for beta release * fix nit
1 parent b0e0d47 commit 0cf8bb3

3 files changed

Lines changed: 18 additions & 2 deletions

File tree

Lines changed: 7 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,7 @@
1+
{
2+
"type": "patch",
3+
"comment": "Fix tab ordering in the callscreen for the video effects pane",
4+
"packageName": "@azure/communication-react",
5+
"email": "94866715+dmceachernmsft@users.noreply.github.com",
6+
"dependentChangeType": "patch"
7+
}
Lines changed: 7 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,7 @@
1+
{
2+
"type": "patch",
3+
"comment": "Fix tab ordering in the callscreen for the video effects pane",
4+
"packageName": "@azure/communication-react",
5+
"email": "94866715+dmceachernmsft@users.noreply.github.com",
6+
"dependentChangeType": "patch"
7+
}

packages/react-components/src/components/VideoEffects/VideoBackgroundEffectsPicker.tsx

Lines changed: 4 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,7 @@
11
// Copyright (c) Microsoft Corporation.
22
// Licensed under the MIT license.
33

4-
import { IStyle, Label, mergeStyles, Stack } from '@fluentui/react';
4+
import { FocusZone, IStyle, Label, mergeStyles, Stack } from '@fluentui/react';
55
import { useWarnings } from '@fluentui/react-hooks';
66
import React from 'react';
77
import { chunk } from '../utils';
@@ -136,7 +136,9 @@ export const _VideoBackgroundEffectsPicker = (props: _VideoBackgroundEffectsPick
136136
data-ui-id="video-effects-picker-row"
137137
>
138138
{options.map((option) => (
139-
<_VideoEffectsItem {...option} key={option.itemKey} itemKey={option.itemKey} />
139+
<FocusZone key={option.itemKey} shouldFocusOnMount={option.itemKey === 'none'}>
140+
<_VideoEffectsItem {...option} itemKey={option.itemKey} />
141+
</FocusZone>
140142
))}
141143
{fillCount > 0 &&
142144
rowIndex === optionsByRow.length - 1 &&

0 commit comments

Comments
 (0)