Skip to content

Commit 19b769c

Browse files
Remove vertical scroll on mobile landscape (and support galaxy fold dimensions) in composites (#1769)
1 parent d9c62f0 commit 19b769c

10 files changed

Lines changed: 24 additions & 10 deletions

File tree

Lines changed: 7 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,7 @@
1+
{
2+
"type": "patch",
3+
"comment": "Reduce min-width and min-height of the composites to support a galaxy fold portrait screen",
4+
"packageName": "@internal/react-composites",
5+
"email": "2684369+JamesBurnside@users.noreply.github.com",
6+
"dependentChangeType": "patch"
7+
}
Lines changed: 7 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,7 @@
1+
{
2+
"type": "none",
3+
"comment": "Update docs to note change on new min height and min width",
4+
"packageName": "@internal/storybook",
5+
"email": "2684369+JamesBurnside@users.noreply.github.com",
6+
"dependentChangeType": "none"
7+
}

packages/react-composites/src/composites/CallComposite/CallComposite.tsx

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -151,7 +151,7 @@ const MainScreen = (props: MainScreenProps): JSX.Element => {
151151
* A customizable UI composite for calling experience.
152152
*
153153
* @remarks Call composite min width/height are as follow:
154-
* - mobile: 19.5rem x 21rem (312px x 336px, with default rem at 16px)
154+
* - mobile: 17.5rem x 21rem (280px x 336px, with default rem at 16px)
155155
* - desktop: 30rem x 22rem (480px x 352px, with default rem at 16px)
156156
*
157157
* @public

packages/react-composites/src/composites/CallComposite/styles/CallComposite.styles.ts

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -22,6 +22,6 @@ export const mainScreenContainerStyleDesktop = mergeStyles({
2222
*/
2323
export const mainScreenContainerStyleMobile = mergeStyles({
2424
...mainScreenContainerStyle,
25-
minWidth: '19.5rem', // max of min-width of composite pages (Call page)
26-
minHeight: '19rem' // max height of min-height of composite pages (Configuration page)
25+
minWidth: '17.5rem', // max of min-width of composite pages (Call page)
26+
minHeight: '13rem' // max height of min-height of composite pages (Configuration page & Call page)
2727
});

packages/react-composites/src/composites/CallComposite/styles/CallConfiguration.styles.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -38,7 +38,7 @@ export const configurationContainerStyleDesktop = mergeStyles({
3838
export const configurationContainerStyleMobile = mergeStyles({
3939
...configurationContainerStyle,
4040
minWidth: '16rem', // from LocalPreview: ControlBar width + 0.5 * 2 for spacing + padding * 2 = 14 + 0.5 * 2 + 0.5 * 2
41-
minHeight: '19rem'
41+
minHeight: '13rem'
4242
});
4343

4444
/**

packages/react-composites/src/composites/CallComposite/styles/CallPage.styles.ts

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -20,7 +20,7 @@ export const callControlsContainerStyles = mergeStyles(controlBarContainerStyles
2020
const containerStyle: IStyle = {
2121
width: '100%',
2222
position: 'relative',
23-
minHeight: '15rem' // linked to minimum space allocated to media gallery
23+
minHeight: '13rem' // linked to minimum space allocated to media gallery
2424
};
2525

2626
/**
@@ -36,7 +36,7 @@ export const containerStyleDesktop = mergeStyles({
3636
*/
3737
export const containerStyleMobile = mergeStyles({
3838
...containerStyle,
39-
minWidth: '19.5rem'
39+
minWidth: '17.5rem'
4040
});
4141

4242
/**

packages/react-composites/src/composites/ChatComposite/ChatComposite.tsx

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -83,7 +83,7 @@ export type ChatCompositeOptions = {
8383
/**
8484
* A customizable UI composite for the chat experience.
8585
*
86-
* @remarks Chat composite min width and height are respectively 19.5rem and 20rem (312px and 320px, with default rem at 16px)
86+
* @remarks Chat composite min width and height are respectively 17.5rem and 20rem (280px and 320px, with default rem at 16px)
8787
*
8888
* @public
8989
*/

packages/react-composites/src/composites/ChatComposite/styles/Chat.styles.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -12,7 +12,7 @@ const MESSAGE_THREAD_WIDTH = '41.25rem';
1212
export const chatScreenContainerStyle = mergeStyles({
1313
height: '100%',
1414
width: '100%',
15-
minHeight: '20rem',
15+
minHeight: '13rem',
1616
minWidth: '17.5rem'
1717
});
1818

packages/storybook/stories/CallComposite/CallCompositeDocs.tsx

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -31,7 +31,7 @@ export const getDocs: () => JSX.Element = () => {
3131
CallComposite brings together key components to provide a full calling experience out of the box.
3232
</Description>
3333
<Description>Note that CallComposite has the following min width and height:</Description>
34-
<Description>- mobile: 19.5rem x 21rem (312px x 336px, with default rem at 16px)</Description>
34+
<Description>- mobile: 17.5rem x 21rem (280px x 336px, with default rem at 16px)</Description>
3535
<Description>- desktop: 30rem x 22rem (480px x 352px, with default rem at 16px)</Description>
3636
<Heading>Basic usage</Heading>
3737
<Description>

packages/storybook/stories/ChatComposite/ChatCompositeDocs.tsx

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -27,7 +27,7 @@ export const getDocs: () => JSX.Element = () => {
2727
ChatComposite brings together key components to provide a full chat experience out of the box.
2828
</Description>
2929
<Description>
30-
Note that ChatComposite has a min width and height of respectively 19.5rem and 20rem (312px x 320px, with
30+
Note that ChatComposite has a min width and height of respectively 17.5rem and 20rem (280px x 320px, with
3131
default rem at 16px).
3232
</Description>
3333
<Heading>Basic usage</Heading>

0 commit comments

Comments
 (0)