Update typescript to 5.3.3 (#3900)

JamesBurnside · web-flow · commit 2c4cdd2fe19c · 2023-12-11T20:37:17.000Z
diff --git a/change-beta/@azure-communication-react-9966a669-09a4-4436-aa27-bfa60a9764f3.json b/change-beta/@azure-communication-react-9966a669-09a4-4436-aa27-bfa60a9764f3.json
@@ -0,0 +1,9 @@
+{
+  "type": "patch",
+  "area": "improvement",
+  "workstream": "",
+  "comment": "Update TypeScript used for building the package to 5.3.3",
+  "packageName": "@azure/communication-react",
+  "email": "2684369+JamesBurnside@users.noreply.github.com",
+  "dependentChangeType": "patch"
+}
diff --git a/change/@azure-communication-react-9966a669-09a4-4436-aa27-bfa60a9764f3.json b/change/@azure-communication-react-9966a669-09a4-4436-aa27-bfa60a9764f3.json
@@ -0,0 +1,9 @@
+{
+  "type": "patch",
+  "area": "improvement",
+  "workstream": "",
+  "comment": "Update TypeScript used for building the package to 5.3.3",
+  "packageName": "@azure/communication-react",
+  "email": "2684369+JamesBurnside@users.noreply.github.com",
+  "dependentChangeType": "patch"
+}
diff --git a/common/config/package.json b/common/config/package.json
@@ -26,6 +26,6 @@
     "rollup-plugin-sourcemaps": "~0.6.3",
     "rollup-plugin-svg": "~2.0.0",
     "ts-node": "^10.9.2",
-    "typescript": "4.7.4"
+    "typescript": "5.3.3"
   }
 }
diff --git a/common/config/rush/common-versions.json b/common/config/rush/common-versions.json
@@ -61,7 +61,7 @@
     "@azure/communication-signaling": ["1.0.0-beta.21"],
     "typescript": [
       // All projects should use this version by default
-      "4.7.4",
+      "5.3.3",
 
       // Typescript check project's dependency -- this is our minimum supported typescript version of our npm package.
       "4.6.3"
diff --git a/common/config/rush/pnpm-lock.yaml b/common/config/rush/pnpm-lock.yaml
diff --git a/common/config/rush/variants/stable/common-versions.json b/common/config/rush/variants/stable/common-versions.json
@@ -63,7 +63,7 @@
     "@azure/communication-signaling": ["1.0.0-beta.20"],
     "typescript": [
       // All projects should use this version by default
-      "4.7.4",
+      "5.3.3",
 
       // Typescript check project's dependency -- this is our minimum supported typescript version of our npm package.
       "4.6.3"
diff --git a/common/config/rush/variants/stable/pnpm-lock.yaml b/common/config/rush/variants/stable/pnpm-lock.yaml
diff --git a/docs/architecture/RepoPackagesAndPacklets.md b/docs/architecture/RepoPackagesAndPacklets.md
@@ -40,7 +40,7 @@ import { fn } from '@internal/component-binding';
 
 Now if an external user was to consume this transpiled output from an npm package, their build system will try to import `fn` from `'@internal/component-binding'` - but that package doesn't exist as an npm package so their build system will break.
 
-To solve this issue we make use of [ts-transform-paths](../infrastructure/ttypescript-plugins#zerollupts-transform-paths).
+To solve this issue we make use of [typescript-transform-paths](../infrastructure/ts-patch-plugins#typescript-transform-paths).
 
 ### How this tool solves the issue
 
diff --git a/docs/infrastructure/ts-patch-plugins.md b/docs/infrastructure/ts-patch-plugins.md
@@ -1,11 +1,13 @@
-# ttypescript
+# ts-patch
 
-[ttypescript](https://github.com/cevek/ttypescript) is an extension on top of typescript (`tsc`) that allows for plugins.
+_(Formerly `ttypescript`)_
+
+[ts-patch](https://github.com/nonara/ts-patch) is an extension on top of typescript (`tsc`) that allows for plugins.
 
 To run using ttypescript instead of typescript run
 
 ```bash
-ttsc #ttypescript
+tspc #ttypescript
 ```
 
 instead of
@@ -18,13 +20,13 @@ tsc #typescript
 
 ttypescript plugins currently used in this repo:
 
-### [@zerollup/ts-transform-paths](https://github.com/zerkalica/zerollup/tree/master/packages/ts-transform-paths)
+### [typescript-transform-paths](https://github.com/LeDDGroup/typescript-transform-paths)
 
-`ts-transform-paths` is used to correctly transform the import statements inside of the `@azure/communication-react` package.
+`typescript-transform-paths` is used to correctly transform the import statements inside of the `@azure/communication-react` package.
 
 #### Configuration
 
-Imports to be transformed are configured in the `tsconfig.json` file. The `ts-transform-paths` tool uses the `paths` property in the tsconfig to know the appropriate transformation.
+Imports to be transformed are configured in the `tsconfig.json` file. The `typescript-transform-paths` tool uses the `paths` property in the tsconfig to know the appropriate transformation.
 
 #### Why this is needed
 
diff --git a/packages/acs-ui-common/package.json b/packages/acs-ui-common/package.json
@@ -45,8 +45,8 @@
     "@microsoft/api-extractor": "~7.38.5",
     "@types/jest": "^29.5.11",
     "@types/react": "18.2.42",
-    "@typescript-eslint/eslint-plugin": "^4.12.0",
-    "@typescript-eslint/parser": "^4.12.0",
+    "@typescript-eslint/eslint-plugin": "^6.13.2",
+    "@typescript-eslint/parser": "^6.13.2",
     "copyfiles": "^2.4.1",
     "cpx": "^1.5.0",
     "cross-env": "^7.0.3",
@@ -64,6 +64,6 @@
     "rimraf": "^2.6.2",
     "rollup": "^4.7.0",
     "ts-jest": "^29.1.0",
-    "typescript": "4.7.4"
+    "typescript": "5.3.3"
   }
 }
diff --git a/packages/calling-component-bindings/package.json b/packages/calling-component-bindings/package.json
@@ -53,8 +53,8 @@
     "@microsoft/api-extractor": "~7.38.5",
     "@types/jest": "^29.5.11",
     "@types/react": "18.2.42",
-    "@typescript-eslint/eslint-plugin": "^4.12.0",
-    "@typescript-eslint/parser": "^4.12.0",
+    "@typescript-eslint/eslint-plugin": "^6.13.2",
+    "@typescript-eslint/parser": "^6.13.2",
     "copyfiles": "^2.4.1",
     "cpx": "^1.5.0",
     "cross-env": "^7.0.3",
@@ -72,6 +72,6 @@
     "rimraf": "^2.6.2",
     "rollup": "^4.7.0",
     "ts-jest": "^29.1.0",
-    "typescript": "4.7.4"
+    "typescript": "5.3.3"
   }
 }
diff --git a/packages/calling-stateful-client/package.json b/packages/calling-stateful-client/package.json
@@ -49,8 +49,8 @@
     "@microsoft/api-extractor": "~7.38.5",
     "@types/jest": "^29.5.11",
     "@types/react": "18.2.42",
-    "@typescript-eslint/eslint-plugin": "^4.12.0",
-    "@typescript-eslint/parser": "^4.12.0",
+    "@typescript-eslint/eslint-plugin": "^6.13.2",
+    "@typescript-eslint/parser": "^6.13.2",
     "copyfiles": "^2.4.1",
     "cpx": "^1.5.0",
     "cross-env": "^7.0.3",
@@ -67,6 +67,6 @@
     "rimraf": "^2.6.2",
     "rollup": "^4.7.0",
     "ts-jest": "^29.1.0",
-    "typescript": "4.7.4"
+    "typescript": "5.3.3"
   }
 }
diff --git a/packages/calling-stateful-client/src/CallAgentDeclarativeCommon.ts b/packages/calling-stateful-client/src/CallAgentDeclarativeCommon.ts
@@ -159,7 +159,7 @@ export abstract class ProxyCallAgentCommon {
   protected getCommon<
     AgentType extends CallAgent | /* @conditional-compile-remove(teams-identity-support) */ TeamsCallAgent,
     P extends keyof CallAgent
-  >(target: AgentType, prop: P): any {
+  >(target: AgentType, prop: P | 'incomingCalls'): any {
     switch (prop) {
       case 'startCall': {
         return this._context.withErrorTeedToState((...args: Parameters<AgentType['startCall']>): CallCommon => {
diff --git a/packages/chat-component-bindings/package.json b/packages/chat-component-bindings/package.json
@@ -68,6 +68,6 @@
     "react": "18.2.0",
     "rimraf": "^2.6.2",
     "rollup": "^4.7.0",
-    "typescript": "4.7.4"
+    "typescript": "5.3.3"
   }
 }
diff --git a/packages/chat-stateful-client/package.json b/packages/chat-stateful-client/package.json
@@ -51,8 +51,8 @@
     "@microsoft/api-extractor": "~7.38.5",
     "@types/jest": "^29.5.11",
     "@types/react": "18.2.42",
-    "@typescript-eslint/eslint-plugin": "^4.12.0",
-    "@typescript-eslint/parser": "^4.12.0",
+    "@typescript-eslint/eslint-plugin": "^6.13.2",
+    "@typescript-eslint/parser": "^6.13.2",
     "copyfiles": "^2.4.1",
     "cpx": "^1.5.0",
     "cross-env": "^7.0.3",
@@ -69,6 +69,6 @@
     "rimraf": "^2.6.2",
     "rollup": "^4.7.0",
     "ts-jest": "^29.1.0",
-    "typescript": "4.7.4"
+    "typescript": "5.3.3"
   }
 }
diff --git a/packages/communication-react/breaking-change-check/checkBreakingChanges.ts b/packages/communication-react/breaking-change-check/checkBreakingChanges.ts
@@ -79,7 +79,7 @@ type BreakingChangeCallClientStateTest = CheckBreakingChanges<
 
 // Stateful client test start
 
-type StatefulClientTestFunction<Client extends any> = (client: NestedPartial<OmitState<Partial<Client>>>) => Client;
+type StatefulClientTestFunction<Client> = (client: NestedPartial<OmitState<Partial<Client>>>) => Client;
 
 type BreakingChangeStatefulCallClientTest = CheckBreakingChanges<
   StatefulClientTestFunction<import('./snapshots/communication-react').StatefulCallClient>,
diff --git a/packages/communication-react/package.json b/packages/communication-react/package.json
@@ -65,9 +65,10 @@
     "copy-original": "cpx \"../*/src/**\" ./preprocess-dist && renamer --find src --replace preprocessed ./preprocess-dist/**/*",
     "preprocess": "babel ../*/src --out-dir ../preprocessed --extensions \".ts,.tsx\" --keep-file-extension --config-file ./.babelrc.js --relative && rimraf ../preprocessed",
     "copy-preprocess": "cpx \"../*/preprocessed/**\" ./preprocess-dist && renamer --find preprocessed --replace src ./preprocess-dist/**/*",
+    "build:test": "tspc",
     "build": "rushx check-deps && rushx _by-flavor \"rushx _build:by-flavor\"",
     "build:cjs": "rollup -c --silent",
-    "build:esm": "npm run _if-preprocess && rushx copy-original && rushx preprocess && rushx copy-preprocess  && ttsc -project tsconfig.preprocess.json || (if-env COMMUNICATION_REACT_FLAVOR=beta && ttsc)",
+    "build:esm": "npm run _if-preprocess && rushx copy-original && rushx preprocess && rushx copy-preprocess  && tspc -project tsconfig.preprocess.json || (if-env COMMUNICATION_REACT_FLAVOR=beta && tspc)",
     "build:watch": "",
     "clean": "rimraf dist && rimraf ../**/preprocessed && rimraf ../**/preprocess-dist",
     "test": "",
@@ -118,9 +119,8 @@
     "@types/react-linkify": "^1.0.4",
     "@types/react": "18.2.42",
     "@types/uuid": "^9.0.7",
-    "@typescript-eslint/eslint-plugin": "^4.12.0",
-    "@typescript-eslint/parser": "^4.12.0",
-    "@zerollup/ts-transform-paths": "^1.7.18",
+    "@typescript-eslint/eslint-plugin": "^6.13.2",
+    "@typescript-eslint/parser": "^6.13.2",
     "ajv": "^8.12.0",
     "copyfiles": "^2.4.1",
     "cpx": "^1.5.0",
@@ -151,9 +151,10 @@
     "source-map-explorer": "^2.5.0",
     "ts-jest": "^29.1.0",
     "ts-node": "^10.9.2",
-    "ttypescript": "^1.5.12",
+    "ts-patch": "^3.1.1",
     "type-fest": "^3.13.1",
-    "typescript": "4.7.4" 
+    "typescript": "5.3.3",
+    "typescript-transform-paths": "^3.4.6"
   },
   "beachball": {
     "shouldPublish": false
diff --git a/packages/communication-react/tsconfig.json b/packages/communication-react/tsconfig.json
@@ -14,9 +14,8 @@
       "@internal/react-composites": ["../../react-composites/src"]
     },
     "plugins": [
-      {
-        "transform": "@zerollup/ts-transform-paths"
-      }
+      { "transform": "typescript-transform-paths" },
+      { "transform": "typescript-transform-paths", "afterDeclarations": true }
     ]
   },
   "typeRoots": ["./node_modules/@types"],
diff --git a/packages/communication-react/tsconfig.preprocess.json b/packages/communication-react/tsconfig.preprocess.json
@@ -14,9 +14,8 @@
       "@internal/react-composites": ["react-composites/src"]
     },
     "plugins": [
-      {
-        "transform": "@zerollup/ts-transform-paths"
-      }
+      { "transform": "typescript-transform-paths" },
+      { "transform": "typescript-transform-paths", "afterDeclarations": true }
     ]
   },
   "typeRoots": ["./node_modules/@types"],
diff --git a/packages/fake-backends/package.json b/packages/fake-backends/package.json
@@ -45,8 +45,8 @@
     "@babel/preset-env": "7.23.5",
     "@microsoft/api-extractor": "~7.38.5",
     "@types/jest": "^29.5.11",
-    "@typescript-eslint/eslint-plugin": "^4.12.0",
-    "@typescript-eslint/parser": "^4.12.0",
+    "@typescript-eslint/eslint-plugin": "^6.13.2",
+    "@typescript-eslint/parser": "^6.13.2",
     "babel-jest": "^29.5.0",
     "babel-loader": "8.1.0",
     "copyfiles": "^2.4.1",
@@ -65,7 +65,7 @@
     "rimraf": "^2.6.2",
     "rollup": "^4.7.0",
     "ts-jest": "^29.1.0",
-    "typescript": "4.7.4",
+    "typescript": "5.3.3",
     "webpack": "5.89.0"
   }
 }
diff --git a/packages/react-components/package.json b/packages/react-components/package.json
@@ -78,8 +78,8 @@
     "@types/react-linkify": "^1.0.4",
     "@types/react": "18.2.42",
     "@types/uuid": "^9.0.7",
-    "@typescript-eslint/eslint-plugin": "^4.12.0",
-    "@typescript-eslint/parser": "^4.12.0",
+    "@typescript-eslint/eslint-plugin": "^6.13.2",
+    "@typescript-eslint/parser": "^6.13.2",
 
     "ajv": "^8.12.0",
     "babel-jest": "^29.5.0",
@@ -120,7 +120,7 @@
     "ts-jest": "^29.1.0",
     "ts-node": "^10.9.2",
     "type-fest": "^3.13.1",
-    "typescript": "4.7.4",
+    "typescript": "5.3.3",
     "webpack": "5.89.0",
     "jest-environment-jsdom": "^29.5.0"
   }
diff --git a/packages/react-composites/package.json b/packages/react-composites/package.json
@@ -106,8 +106,8 @@
     "@types/react": "18.2.42",
     "@types/uuid": "^9.0.7",
     "@types/yargs": "^17.0.29",
-    "@typescript-eslint/eslint-plugin": "^4.12.0",
-    "@typescript-eslint/parser": "^4.12.0",
+    "@typescript-eslint/eslint-plugin": "^6.13.2",
+    "@typescript-eslint/parser": "^6.13.2",
     "ajv": "^8.12.0",
     "babel-jest": "^29.5.0",
     "babel-loader": "8.1.0",
@@ -155,7 +155,7 @@
     "ts-loader": "^8.0.12",
     "ts-node": "^10.9.2",
     "type-fest": "^3.13.1",
-    "typescript": "4.7.4",
+    "typescript": "5.3.3",
     "webpack-cli": "^5.1.4",
     "webpack-dev-server": "4.15.1",
     "webpack": "5.89.0",
diff --git a/packages/storybook/package.json b/packages/storybook/package.json
@@ -70,8 +70,8 @@
     "@types/react-linkify": "^1.0.4",
     "@types/react": "18.2.42",
     "@types/uuid": "^9.0.7",
-    "@typescript-eslint/eslint-plugin": "^4.12.0",
-    "@typescript-eslint/parser": "^4.12.0",
+    "@typescript-eslint/eslint-plugin": "^6.13.2",
+    "@typescript-eslint/parser": "^6.13.2",
     "ajv": "^8.12.0",
     "babel-jest": "^29.5.0",
     "babel-loader": "8.1.0",
@@ -110,7 +110,7 @@
     "styled-components": "^5.2.1",
     "ts-jest": "^29.1.0",
     "ts-node": "^10.9.2",
-    "typescript": "4.7.4",
+    "typescript": "5.3.3",
     "webpack": "5.89.0"
   }
 }
diff --git a/samples/CallWithChat/package.json b/samples/CallWithChat/package.json
@@ -62,8 +62,8 @@
     "@types/react": "18.2.42",
     "@types/react-dom": "18.2.17",
     "@types/uuid": "^9.0.7",
-    "@typescript-eslint/eslint-plugin": "^4.12.0",
-    "@typescript-eslint/parser": "^4.12.0",
+    "@typescript-eslint/eslint-plugin": "^6.13.2",
+    "@typescript-eslint/parser": "^6.13.2",
     "ajv": "^8.12.0",
     "babel-jest": "^29.5.0",
     "babel-loader": "8.1.0",
@@ -93,7 +93,7 @@
     "source-map-explorer": "^2.5.0",
     "style-loader": "^2.0.0",
     "ts-loader": "^8.0.12",
-    "typescript": "4.7.4",
+    "typescript": "5.3.3",
     "url-loader": "^4.1.1",
     "webpack": "5.89.0",
     "webpack-cli": "^5.1.4",
diff --git a/samples/Calling/package.json b/samples/Calling/package.json
@@ -64,8 +64,8 @@
     "@types/react-dom": "18.2.17",
     "@types/react": "18.2.42",
     "@types/uuid": "^9.0.7",
-    "@typescript-eslint/eslint-plugin": "^4.12.0",
-    "@typescript-eslint/parser": "^4.12.0",
+    "@typescript-eslint/eslint-plugin": "^6.13.2",
+    "@typescript-eslint/parser": "^6.13.2",
     "ajv": "^8.12.0",
     "babel-jest": "^29.5.0",
     "babel-loader": "8.1.0",
@@ -94,7 +94,7 @@
     "source-map-explorer": "^2.5.0",
     "style-loader": "^2.0.0",
     "ts-loader": "^8.0.12",
-    "typescript": "4.7.4",
+    "typescript": "5.3.3",
     "url-loader": "^4.1.1",
     "webpack-cli": "^5.1.4",
     "webpack-dev-server": "4.15.1",
diff --git a/samples/Chat/package.json b/samples/Chat/package.json
@@ -57,8 +57,8 @@
     "@types/json-stringify-safe": "^5.0.3",
     "@types/react-dom": "18.2.17",
     "@types/react": "18.2.42",
-    "@typescript-eslint/eslint-plugin": "^4.12.0",
-    "@typescript-eslint/parser": "^4.12.0",
+    "@typescript-eslint/eslint-plugin": "^6.13.2",
+    "@typescript-eslint/parser": "^6.13.2",
     "babel-loader": "8.1.0",
     "concurrently": "^5.3.0",
     "copyfiles": "^2.4.1",
@@ -85,7 +85,7 @@
     "rimraf": "^2.6.2",
     "style-loader": "^2.0.0",
     "ts-loader": "^8.0.12",
-    "typescript": "4.7.4",
+    "typescript": "5.3.3",
     "url-loader": "^4.1.1",
     "webpack-cli": "^5.1.4",
     "webpack-dev-server": "4.15.1",
diff --git a/samples/ComponentExamples/package.json b/samples/ComponentExamples/package.json
diff --git a/samples/Server/package.json b/samples/Server/package.json
diff --git a/samples/StaticHtmlComposites/package.json b/samples/StaticHtmlComposites/package.json
diff --git a/samples/tests/package.json b/samples/tests/package.json

Original file line number	Diff line number	Diff line change
`@@ -26,6 +26,6 @@`
`26`	`26`	`"rollup-plugin-sourcemaps": "~0.6.3",`
`27`	`27`	`"rollup-plugin-svg": "~2.0.0",`
`28`	`28`	`"ts-node": "^10.9.2",`
`29`		`- "typescript": "4.7.4"`
	`29`	`+ "typescript": "5.3.3"`
`30`	`30`	`}`
`31`	`31`	`}`